Message-ID: <9d11640a-9adf-b1d5-b21a-8cfd5275aa5c@oracle.com>
Date:   Mon, 6 Feb 2023 08:05:28 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [GIT PULL] TTY/Serial driver fixes for 6.2-rc7
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Jiri Slaby <jslaby@suse.cz>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
References: <Y9+Yv1CQKNP0Bwqq@kroah.com>
 <CAHk-=whSQFHVzgQ+s8cbCSyE_yrd+BFuYktHe2=0h-nLXBi__Q@mail.gmail.com>
 <Y+Cuh3LmsF9PGO6z@kroah.com>
From:   George Kennedy <george.kennedy@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <Y+Cuh3LmsF9PGO6z@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnFZNlE0K1czcmpHWWhHQ0txMlllQzJKUlVmOHJWS3cvSURBZGlpMFFoU1Bt?=
 =?utf-8?B?THRxYk80N0c1VXZTazZuR2lLOUM1THdJVkMwd2VmSHVYamVsMVI0Ukp1RDdR?=
 =?utf-8?B?OTBJbDNOaWc0ZHZYK2VpcGZNMEZOdmtuS2U3NGxKay96dm1hZjlNOStONElT?=
 =?utf-8?B?dVNWVmRuQVlZeGJJNmlVdzhsbFpQWmk4TGhUSTZVOW55RkpFRG1GV1FIMXc5?=
 =?utf-8?B?VjVIcW1STWlIYnFYeDFVeFZFdGJiWDZCcVA1YytMd0NCNVQ0RGNlQ0tWTVdS?=
 =?utf-8?B?cThvdDRvclM5amxMaFdhTE9sczIyZnEvczhMNXNWaUs0Z0ZyRGJyMEpaT1VG?=
 =?utf-8?B?allCRDVWbkZDVkxqelJJOTh5K0hpWHJ2MCtmRUtBSWExZHE5Ylhwa0xkT1A3?=
 =?utf-8?B?TS9WazdzeFBiRzMrbzFsbGYzTU0vQXFrSWxFNFRLUS9UY2pES0Z0eGJia1Q5?=
 =?utf-8?B?alpsL2Y1STBBSExxTE1DUjlDcUZjczlVS2hpeXV3dm0xOEd4VnF1am53bUhU?=
 =?utf-8?B?WjZoR0puTVZQN0xidThzWDNVbEUxcTE5YnhQV2RoRVJMa3F4bVIvUm5mR2xB?=
 =?utf-8?B?bjFOcmpCWUVFenZnWExWN3JKUEthTjVrQ0dFeGx6S3RZNHU1TkpNdkJEV3Jh?=
 =?utf-8?B?S1Z3YWh2V2I4bjJNVlErSXF3b0cwbnRKazVNdXNxRkUxKzFyeTFvZDlPeDla?=
 =?utf-8?B?cVhCR2g1dGlRMEMrUnNydk9tVEk0UFNQMThUengwMHpvN21hcS9lR0paYXlN?=
 =?utf-8?B?RE1BRU5lTFBZM3BBV2hTYXNvRU9MNlROZWg2ZFRVbUpoRm16K1RGSXZ1R2kw?=
 =?utf-8?B?WTZmSEZqK3V6d2RLQkVYa3BZM2RoQXZWbzNiRHB2R1Rsd3NXaW53eEN6RmRy?=
 =?utf-8?B?dSt1WW1rRUlZL3plQjQ2ZHJRQm11RXBydnpTckFGbGk4MW9WeWZaTHFkVVZv?=
 =?utf-8?B?MVB6ZWcxM0xuRW9ZVlQxNGJqZytoTmlKSGM5THBacE1NV0xKV3IyTGVpVU9m?=
 =?utf-8?B?QnNNYVZ0Y0k4RFZZWlJkTi9IaVJRd2ZsNk1ydjgvRjRPN0dxdWtnalhpVVh5?=
 =?utf-8?B?REN1eVByQys0L0dhQm0rMWk4ZGxBUDhCc1BpZXdwbDRNQy94Y3pSSmtQcXU3?=
 =?utf-8?B?U2tTMExhSmsvZGVybHRPb2VPeG5SS2YrWCthN2NPRnF4VHFkUVdiOURzWHB4?=
 =?utf-8?B?Tk00YVFzREpzZXY3UVNKazJHWHRBRnY3QUZ5RCtOc2RneUgrK24xNEpxZWgv?=
 =?utf-8?B?c2V5NnRvUzdCMlRKb2dmMy9OR0NHS3YzRWJ1aGF0RjA1RzNXTkpTYnIwMGJp?=
 =?utf-8?B?RHFtQXg0ODdvVkkyNE5TWWxTMkc4Tlk2a1ZxMFI2RkdnWUllc3k2SEdRdys4?=
 =?utf-8?B?NjZnVTR2dnVramF1ZGtTQ1Z0UzJkOG11eFU1ZzJoMkMrRFl0NVZ4NmJQeXhY?=
 =?utf-8?B?am1wOWNXVGtzRUh6UGFPOUhmYzNaMXRSRUJnbENqUDhQZXE4Q2ZOYkVxS1Vw?=
 =?utf-8?B?MnQ3cWFES200TUcxd0JacjBLUzdsOW83K0JsbWZMVlpzSHg1VkZaNFVFc0xo?=
 =?utf-8?B?R0l4bGRwNWNTT0hEVy9ERGVySGVreEV2dU0raUgwdjlOcTVUZElPVnNQLzR0?=
 =?utf-8?B?cjR5V09mSThqYVBWekpvSVlCS3c3eTh1KzVQRHh0Yjg3ak5rclhoT2ZNa2hk?=
 =?utf-8?B?b0ZJWnZkb0lEeGJEd25BdzhNdzlZaWdBajBsQ1NJWXJJTUhUOWlvSFN6V2sv?=
 =?utf-8?B?TVlmT3BYNUltNXpQbHFYNiszOUhJd29LVGNMcGJMNUJOWC9rR1l1aGxYL1lo?=
 =?utf-8?B?TnFuMmd5M1I4T0trQ2FDVnpybnpjaXZjejJEaEM1aDFNbHpkclluWFRlSTh4?=
 =?utf-8?B?L3lHYlVFdE16TllvRHNrZ2lQRGRCWlFWbWZaNGgxdi9EcWJ5U2g2eWNkK2FM?=
 =?utf-8?B?NWcrWmhiOCtJeVJnWkdnWEg3NlpIajlIZGEvbmhvdDRxVHNPb2Q1WTJLa3dQ?=
 =?utf-8?B?ZUliTXRYQW1CQU1UemxWVnN3SllqeGxiVENtOGRCR3RXdnRFajVVMER2NW02?=
 =?utf-8?B?MlRhcWE2WGNDNEhyUXlUTmVNQmYvcHJOSXpOQVU3Ni85S1BGL2UxUCtxeWQ0?=
 =?utf-8?B?bWZFb0VqM1pmSzdMemw0cENBQ0lYeHBJbzNkUytnL05jZEd4ZU9kY3ZVQmVE?=
 =?utf-8?B?RGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?MWpSbzhkVzAxRHNYNk1rblFnWmQzNStJdFZ0L1h3eE5NU0NsZHVPcXpraDBs?=
 =?utf-8?B?c043Y2YzMDdOU1NjWktPUGxUajlMcTdhcjJ6d0RVZmJiblF1eEJINTVjNVNU?=
 =?utf-8?B?bVJMYzNweEU3cFl6eFlyM29qeUpDblpmUituaHRsYTNuYXRFbDlMMmJuV0dl?=
 =?utf-8?B?Ums4a2tTWUZtakR2N2RHT1ZRaHBsYnhGc0JnaEllN0dreXk1YjdhZlNaWXBN?=
 =?utf-8?B?NHlwY3hGNlVwMHVuU2JRcThRK0ZuRHp0c2tjL0ZLNzdaam5yUnZRK2lNNXJx?=
 =?utf-8?B?SUZPL0d6TFpWcHBBYlplVFRWYmlqQnRhTzNKNVhUbklhNFpFM3JDSW9wZWN4?=
 =?utf-8?B?b2FmRWVYVU4rVlhxOXlFbjg3R1Fxa1ZzZmxLUFV2c1F4bFRVU2JrL3AvZllI?=
 =?utf-8?B?MU9qWWM2azFTTUFSTEx4TlFLVGpkZjVYK1VxdVdUWDE2cVdodW5kU2Z6MDFv?=
 =?utf-8?B?ZHBKMXNYbEw2SmFTWGo0dytUTkNjSzROU3FxN2dSdUdlem50cm4zQzhIaGFH?=
 =?utf-8?B?VlEzeHdoN3JFOWd4RTRqS21teW1FTGtnVHl0NmYzNW8wb00wWnVkSXpLQ0ZY?=
 =?utf-8?B?SDMzRWtDUnFyaGIxZloyYnl1RVFqd0syZmdmdmcrVXhLaktCM0xXZFliRTEx?=
 =?utf-8?B?aUNVZGZDeUJuNmhzSHd4dmQvQWdQNnR1S0NrRzM4TE05WUlXNUtPcnh4WUt5?=
 =?utf-8?B?ak8wT3NtY1lzMjg1b1FEZWRtZ1gvbUxDbklyMko3N0I3RHpTLzU2N0pNdzh3?=
 =?utf-8?B?WG5MV0E5ZVU3UGRHaEt3NTN2TlJiTEgvK201NEJmVWVXUi95ODQ2YXVWa3BX?=
 =?utf-8?B?UXNOSENIVDZlb1pseGd0eDY1MzhmR1FwZVJkbGtsUXozMmptRDNPZ1FJTTVB?=
 =?utf-8?B?d3FXc0VoOWxVV2o0RnRmSTRrS1lNTjlGMTFuNkRub2RRNjArMy9aTnI1SnpZ?=
 =?utf-8?B?Z3pxT2F5NHEzTVJPWm1NS0tDc3p1VXdBTStwVHdDRUhsam43NnB0U2IvYjJa?=
 =?utf-8?B?ak1QRWswUjZvS1JmQytzaXQwSDFoUGl3Z2VXZVVsbG9vWHFMSDVLOVJrWlF4?=
 =?utf-8?B?WVpoQjFlVnVGN1YvSnlaUnJEYXd4R1Q2U21VM1JYUFZnVHg5YnJIUW54VjlJ?=
 =?utf-8?B?N2ZrRjNkRkVEZ1RjWmxuN3dnbktBM3o5Q2JjVlhRZ2QvMU5tVUFUZ0JpV0xq?=
 =?utf-8?B?UllCMTcrY1lLejZZTTlQVTJ4WWo3Y0dZemxvMmw0UW9Kcnc5ZEU2dUhtUWFL?=
 =?utf-8?Q?t64d5CChI+nAXsb?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60bae4cf-43c5-47b4-ab70-08db0842d33f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5895.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 13:05:30.9492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 03fayva8IuHv9zvMKuKoDr9rezo869Kym5lEXrW+zSqECd4EHcSsLyltu8INK9coJYjqBwjl2qV6WWNSIw9mSF68BfUs92z2RFaKYv+MhcE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4806
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-06_06,2023-02-06_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 adultscore=0
 malwarescore=0 mlxscore=0 phishscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302060111
X-Proofpoint-ORIG-GUID: QQixqgw1VCqEqKAy2k8E4UpvMIlh_B16
X-Proofpoint-GUID: QQixqgw1VCqEqKAy2k8E4UpvMIlh_B16
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/6/2023 2:38 AM, Greg KH wrote:
> On Sun, Feb 05, 2023 at 12:17:05PM -0800, Linus Torvalds wrote:
>> On Sun, Feb 5, 2023 at 3:53 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>>> George Kennedy (1):
>>>        vc_screen: move load of struct vc_data pointer in vcs_read() to avoid UAF
>> Hmm.
>>
>> I think the "goto unlock_out" should be a "break". A partial read
>> should return the partial success, not an error.
>>
>> That situation didn't exist when the check was outside the loop, but does now.
>>
>> Now, I don't think this matters for any sane situation, but since I
>> looked at this patch I thought I'd mention it.
> Fair enough, George, can you send a follow-on patch to fix this up?
Hi Greg,

Will send a follow-on patch.

Thanks,
George
>
> thanks,
>
> greg k-h