Message-ID: <7fb6fa717b2c8e7869e2a5c7abb299c365ec3af3.camel@linux.intel.com>
Subject: Re: [PATCH 0/7] Add TPMI support
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Hans de Goede <hdegoede@redhat.com>, markgross@kernel.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 06 Feb 2023 05:29:49 -0800
In-Reply-To: <14c1201b-7caf-e096-624c-e5ec3597d67f@redhat.com>
References: <20230202010738.2186174-1-srinivas.pandruvada@linux.intel.com>
         <918ac0c5-9f35-0099-5be8-6dbc72aa88e9@redhat.com>
         <14c1201b-7caf-e096-624c-e5ec3597d67f@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Hans,

On Mon, 2023-02-06 at 13:55 +0100, Hans de Goede wrote:
> Hi,
>=20
> On 2/6/23 13:49, Hans de Goede wrote:
>=20
> > Thank you for your patch-series, I've applied the series to my
> > review-hans branch:
> > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-=
x86.git/log/?h=3Dreview-hans
> >=20
> > Note it will show up in my review-hans branch once I've pushed my
> > local branch there, which might take a while.
> >=20
> > Once I've run some tests on this branch the patches there will be
> > added to the platform-drivers-x86/for-next branch and eventually
> > will be included in the pdx86 pull-request to Linus for the next
> > merge-window.
>=20
> One thing which I did notice, which is a pre-existing problem
> is that the IDA accesses in drivers/platform/x86/intel/vsec.c
> are not protected by any locking.
>=20
> This is likely ok for now because there is only 1 PCI device
> per type of ida and the enumeration of the vsec devices
> under the PCI device is done in a single loop, so all
> IDA accesses are single threaded atm.
>=20
> But still IMHO it would be good to protect the IDA accesses
> (ida_alloc() / ida_free()) with a mutex to protect against
> any future races.
>=20
> I think that a single global static mutex inside
> drivers/platform/x86/intel/vsec.c to protect the
> ida calls there should suffice for this.
Let me look into this and get back.

Thanks,
Srinivas

>=20
> Regards,
>=20
> Hans
>=20
>=20
>=20