MIME-Version: 1.0
Date:   Mon, 06 Feb 2023 13:09:48 +0100
From:   =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-kernel@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: Re: [RESEND PATCH 30/37] nvmem: core: fix
 nvmem_layout_get_match_data()
In-Reply-To: <Y+Dst2V9mfJbVrzD@kroah.com>
References: <20230206102759.669838-1-srinivas.kandagatla@linaro.org>
 <20230206102759.669838-31-srinivas.kandagatla@linaro.org>
 <Y+Dst2V9mfJbVrzD@kroah.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <c6394c5daead464df1ddad781829668e@milecki.pl>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023-02-06 13:04, Greg KH wrote:
> On Mon, Feb 06, 2023 at 10:27:52AM +0000, Srinivas Kandagatla wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>> 
>> This function was trying to match wrong OF node (parent device's)
>> against an of_match_table. It was always returning NULL.
>> 
>> Make it match layout's OF node against layout's of_match_table.
>> 
>> Note: __maybe_unused is needed to avoid:
>> warning: variable 'layout_np' set but not used 
>> [-Wunused-but-set-variable]
>> (of_match_node() is no-op without CONFIG_OF).
>> 
>> Fixes: 61a093b4a0e0 ("nvmem: core: introduce NVMEM layouts")
> 
> Nit, how can you have a git commit id if you are sending me patches to
> be applied to my tree?
> 
> That's never going to work, sorry.

That was commit I found in the:
https://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git/log/?h=for-next

With Srinivas sending patches and not merge request, it doesn't make
sense obviously.

Srinivas could you rebase your branch making my patch a fixup for the
commit 61a093b4a0e0?