Date:   Mon, 6 Feb 2023 06:23:29 -0500
From:   Gregory Price <gregory.price@memverge.com>
To:     Fan Ni <fan.ni@samsung.com>
Cc:     "alison.schofield@intel.com" <alison.schofield@intel.com>,
        "vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
        "ira.weiny@intel.com" <ira.weiny@intel.com>,
        "bwidawsk@kernel.org" <bwidawsk@kernel.org>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
        Adam Manzanares <a.manzanares@samsung.com>,
        "dave@stgolabs.net" <dave@stgolabs.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/region: Fix null pointer dereference for resetting
 decoder
Message-ID: <Y+DjMTSoG9nZwN+e@memverge.com>
References: <CGME20221215170915uscas1p262ccdf32fb2ccd3840189376c2793d06@uscas1p2.samsung.com>
 <20221215170909.2650271-1-fan.ni@samsung.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221215170909.2650271-1-fan.ni@samsung.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?37YwuTBDkun4PGQ48tVXBYvNqYT6LXmhWxmX5K5ry0BGI3YlVFsYGCEhPXq8?=
 =?us-ascii?Q?QTTSAAdAC2LytvBPQ2FNnWXbdTuIT0huTue573zJpZT3LTju8GebDG9tkY4t?=
 =?us-ascii?Q?m9cPtH/AW7rT74MLA8fgEUL+YGKDhjfEcjODF3fQ8NU8lyfbEh5RHxo2uEMO?=
 =?us-ascii?Q?nVrVGLZHPuM/gMfWwHcOJhzRLtULqOxCq/B5mky1qH/M1LGTaUjAn9FGy8K7?=
 =?us-ascii?Q?WsPksi8kVsl6ebdD/w5atFIF9Ozsr94R+d1+5QlYGMPok78j/AgLgxvcYMvJ?=
 =?us-ascii?Q?vY0VDxdv/lGOjbXuhxeSJTeMzo0W2iIibG6D8tB7IDX3AkTt8kszNGo5oQYJ?=
 =?us-ascii?Q?VpXYloiyoHh4iBBVppi5fhlBGwR+QZJLI7Q+CMrgwaPpNV+P3vy8NKU+W3zH?=
 =?us-ascii?Q?XuLPqR/z/iIPG4ynzHeA+UR9rYWpkwXMHdOrnqZ4TomC+lBXJl7ntRy/r9in?=
 =?us-ascii?Q?/pnIsdkvNekS57vroP7Umi5TrfHhSr/zmKjHi7yXDL/amb35Pw4c7s7Cp8Kn?=
 =?us-ascii?Q?cn0oYf+b6+3WLiyGOZTh1rlCS4Teyk6aDnaM+8CfCVQzwnKy/PjVEsfQeaFj?=
 =?us-ascii?Q?Pg33LFyncH1uyz/OQQamR9mRkAr31P4GFO6PDTcr5f/5VGN4wYgP83kNRpSe?=
 =?us-ascii?Q?ct3BC+Ry/1zLjJhE+V0/hjF6y0W/BHZf1zh0qcQKIJdKLw2bhXuYxLRWltlO?=
 =?us-ascii?Q?nyTkC276XQAG/BkefzSRlN6WdOPJj3QWe1uYodKzrA20bIQGmgI60C5SVbF2?=
 =?us-ascii?Q?hs/R9OdJRPa4RVrSQLL9rp1LN86nlYZwFTabd7B2h4OSxrTfsfnKiZMuNSkj?=
 =?us-ascii?Q?ugtOrzmB3oREJpYkqyqgDh54LH3B6UFzphxWFAAeaQ7hQPdl26RYuoYcBjlo?=
 =?us-ascii?Q?AjCduc5CC3LINbiky6Fy31MDhkJqE+VsbyrQK3EfRRbcF67tMWv+aS8+EPoa?=
 =?us-ascii?Q?+sjqF/ZfacG0Ufequ++5TMPrT9gniSLfYUU9mYVRXlqzRivmEXBOsOXC1Bth?=
 =?us-ascii?Q?9N236rfzpMc0cP4wmFE4ZnqIegr2y1gAbq6sfnRiYP9Jc/g2/M8Pvi1+7a4u?=
 =?us-ascii?Q?GtnDpyXNHg4W5bYWGXyZ+u5lSEk/leE60LuzllJmHdgLlGDzThhvLSIX2qyk?=
 =?us-ascii?Q?7BiI0P9CUqNPOjDfQd6nFGgveWb7W2tmr67VcpH9aFDZdu38sXpqXkGjHnoH?=
 =?us-ascii?Q?1OnhDRfxG9KHPfDHO3eCDwSGi49jyl6wndLrPKG2OrztsSdhgxAX8KmCztFg?=
 =?us-ascii?Q?zyqSnvzXHJ5I9yRBtIi9WgcK+MGKHehD6gvvvxoswK/xVUCWdlGggOD2gUpW?=
 =?us-ascii?Q?IuUZb6ncHtz/IrFxhGUVf0/lXI/qCRt5b90gaNX6XmDRzmZBszRiyDvzhVFr?=
 =?us-ascii?Q?vrnAoTX5QsDwOYTdou/JTxZCJdzRve/3cYosICnykCeujJSd/BcizvG/lyhN?=
 =?us-ascii?Q?qbHVa+bIa2OproO5iEt7mC8BMBqKrDJTcm9Ck93k8xGPeIx/NwXfQsEd31pc?=
 =?us-ascii?Q?HDmJENKM8eqCjKY3tIFfd3KRm9yurr+hFw/cQPH/5wRU/WsAw8ZUIZkZWkur?=
 =?us-ascii?Q?iOBZKOcgdN5XbRkP0ZBP+mLQDz/zvKx3CQmGv9zy0pdLyI4UfWIJP72jqrLu?=
 =?us-ascii?Q?Qw=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9d9fb5d-3d20-45d5-0dca-08db085975ea
X-MS-Exchange-CrossTenant-AuthSource: BN6PR17MB3121.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 15:47:32.9254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ne9H3N/LZ/UEt9q+A4B3YJjgbYsKexazIHIKT8lyDqd41A7N/1Qpy5HI8X4Pgi/W+84FFH/awFa8KHNHMGkXbcLtNa35RDdAdEayaqeA6r8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR17MB5757
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 15, 2022 at 05:09:14PM +0000, Fan Ni wrote:
> Not all decoders have a reset callback.
> 
> The CXL specification allows a host bridge with a single root port to
> have no explicit HDM decoders. Currently the region driver assumes there
> are none.  As such the CXL core creates a special pass through decoder
> instance without a commit/reset callback.
> 
> Prior to this patch, the ->reset() callback was called unconditionally when
> calling cxl_region_decode_reset. Thus a configuration with 1 Host Bridge,
> 1 Root Port, and one directly attached CXL type 3 device or multiple CXL
> type 3 devices attached to downstream ports of a switch can cause a null
> pointer dereference.
> 
> Before the fix, a kernel crash was observed when we destroy the region, and
> a pass through decoder is reset.
> 
> The issue can be reproduced as below,
>     1) create a region with a CXL setup which includes a HB with a
>     single root port under which a memdev is attached directly.
>     2) destroy the region with cxl destroy-region regionX -f.
> 
> Fixes: 176baefb2eb5 ("cxl/hdm: Commit decoder state to hardware")
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
> ---
>  drivers/cxl/core/region.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index f9ae5ad284ff..3931793a13ac 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -131,7 +131,7 @@ static int cxl_region_decode_reset(struct cxl_region *cxlr, int count)
>  		struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
>  		struct cxl_port *iter = cxled_to_port(cxled);
>  		struct cxl_ep *ep;
> -		int rc;
> +		int rc = 0;
>  
>  		while (!is_cxl_root(to_cxl_port(iter->dev.parent)))
>  			iter = to_cxl_port(iter->dev.parent);
> @@ -143,7 +143,8 @@ static int cxl_region_decode_reset(struct cxl_region *cxlr, int count)
>  
>  			cxl_rr = cxl_rr_load(iter, cxlr);
>  			cxld = cxl_rr->decoder;
> -			rc = cxld->reset(cxld);
> +			if (cxld->reset)
> +				rc = cxld->reset(cxld);
>  			if (rc)
>  				return rc;
>  		}
> @@ -186,7 +187,8 @@ static int cxl_region_decode_commit(struct cxl_region *cxlr)
>  			     iter = ep->next, ep = cxl_ep_load(iter, cxlmd)) {
>  				cxl_rr = cxl_rr_load(iter, cxlr);
>  				cxld = cxl_rr->decoder;
> -				cxld->reset(cxld);
> +				if (cxld->reset)
> +					cxld->reset(cxld);
>  			}
>  
>  			cxled->cxld.reset(&cxled->cxld);
> -- 
> 2.25.1


Should we try to get this upstreamed in 6.2-final?  Seems like a good
stable addition. Probably doesn't affect real hardware, but it certainly
affects QEMU.


Tested-by: Gregory Price <gregory.price@memverge.com>
Reviewed-by: Gregory Price <gregory.price@memverge.com>