Date:   Mon, 6 Feb 2023 17:10:32 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Paul Menzel <pmenzel@molgen.mpg.de>,
        Krishna Yarlagadda <kyarlagadda@nvidia.com>,
        robh+dt@kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
        jarkko@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        jonathanh@nvidia.com, skomatineni@nvidia.com, ldewangan@nvidia.com
Subject: Re: [Patch V2 2/4] tpm: tegra: Support SPI tpm wait state detect
Message-ID: <Y+EmeP3ccaxxaBHX@orome>
References: <20230203130133.32901-1-kyarlagadda@nvidia.com>
 <20230203130133.32901-3-kyarlagadda@nvidia.com>
 <d356a20f-629c-a534-7a80-b96d0940056d@molgen.mpg.de>
 <Y+D+SHT63awKdC4H@sirena.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="4jMQNYXv9g85GIdj"
Content-Disposition: inline
In-Reply-To: <Y+D+SHT63awKdC4H@sirena.org.uk>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--4jMQNYXv9g85GIdj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 06, 2023 at 01:19:04PM +0000, Mark Brown wrote:
> On Mon, Feb 06, 2023 at 12:02:56PM +0100, Paul Menzel wrote:
> > Am 03.02.23 um 14:01 schrieb Krishna Yarlagadda:
>=20
> > > +	/* If the SPI device has an IRQ then use that */
> > > +	if (dev->irq > 0)
> > > +		irq =3D dev->irq;
> > > +	else
> > > +		irq =3D -1;
>=20
> > Use ternary operator?
>=20
> >     irq =3D dev->irq > 0 ? dev->irq : -1;
>=20
> No, please write the code using normal conditional instructions.  This
> isn't the IOCCC and the ternery operator is rarely a legibility aid.

Looks like the SPI core sets dev->irq =3D 0 for any error other than
-EPROBE_DEFER and the TPM TIS core checks for irq !=3D 0 before trying to
setup that IRQ, so seems like we can just skip this altogether and pass
in dev->irq directly.

Thierry

--4jMQNYXv9g85GIdj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmPhJngACgkQ3SOs138+
s6GN1RAAraD6eFc9I0Ex4Xp09TLqgcmofp+GytuozfmFph+0j8hBhoCgH7meAK4X
v6Yj81wPmpX63ZK6wl2x8imrF3m/WbQalC/VHkHBOaEAwqcIQgxXuejPyFhdHUKH
4sp9kx1b/5wuCJRiQvw1w9OA70/tlBBpoA88y/03ErNrIcPskLB0DfrA38DgP3Nf
hDFwa95atSXIJpkY87QnGjRuDNWxdu0tfrDohWzqenaBiZ83u98oKSBPE19bc2+7
x5quKfv3t295OF2BSXJeVn5ktNlfsMHYlTIA5YEIkKtIKnfPz+LoUVwn2blTka29
ofqnDjAyEyyqZN8NdV71iZCGyUklN+rrahD/MQ7edGQePSPvX8DBnb9Y6MucRGHo
5EVdlmGBh+/Rqs5kdHZ1dqJjR3O7crR8DyrnfUuimMmRUGn0e6bEgx0NJ5z0K1VL
xth70QQ8wiie3VqC601OA57yQTPWzPL7sLfvGgA031jKDLKfuhKsG6DR260pRTRY
RnHz4NkACoO0Lso2M4GJVu14BvSKjBU2deUjws2Q2wZezgqADhJnoCepFqu2N1NO
7rXKeVGowUQCiFUIDql3+PATanYtwG1zYhZgMLFMUpBSKMoji/k0dUG6/IulZLYb
EYL4rxMYCHaazO+O9tXBZn4LSaZSyKdjpHBDHHij21fNLVpmD40=
=C7QB
-----END PGP SIGNATURE-----

--4jMQNYXv9g85GIdj--