MIME-Version: 1.0
References: <20230203175832.3406504-1-daniel.lezcano@linaro.org> <CAJZ5v0jzLCQt22MhfaAvL8w+RP7Y-YqxUdcgQ2u2Tz9i0CS+2A@mail.gmail.com>
In-Reply-To: <CAJZ5v0jzLCQt22MhfaAvL8w+RP7Y-YqxUdcgQ2u2Tz9i0CS+2A@mail.gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 6 Feb 2023 18:28:19 +0100
Message-ID: <CAJZ5v0gzaa5KMkULHtp9Vi-VTomOhkf2eP0eufHqz9NMx5crJA@mail.gmail.com>
Subject: Re: [PATCH] thermal: Hunt zero trip points thermal zones usage
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rjw@rjwysocki.net, linux-acpi@vger.kernel.org,
        linux-pm@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Kees Cook <keescook@chromium.org>,
        "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
        Chuansheng Liu <chuansheng.liu@intel.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 6, 2023 at 5:08 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Fri, Feb 3, 2023 at 6:59 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> >
> > Some drivers are declaring a thermal zone without any thermal trip
> > points.
> >
> > On the other side, we are introducing the function
> > thermal_zone_device_register_with_trips() which provides an array of
> > generic thermal trip points. When all the drivers will be converted to
> > the generic trip points, keeping two functions will be useless.
> >
> > Most of the drivers are now using
> > thermal_zone_device_register_with_trips() with the generic trip
> > points. As soon as the remaining drivers are merged, the
> > thermal_zone_device_register_with_trips() will be renamed to
> > thermal_zone_device_register().
>
> So why is this the first time I'm learning about this plan?
>
> > Obviously this renaming can only happen if there are no more user of
> > the thermal_zone_device_register() function.
> >
> > This change uses thermal_zone_device_register_with_trips() with a NULL
> > parameter for the trip point array instead of
> > thermal_zone_device_register().
>
> And later it will be renamed to thermal_zone_device_register() again?
>
> Can we just stop confusing people this way?
>
> What would be wrong with changing both
> thermal_zone_device_register_with_trips() and
> thermal_zone_device_register() together when we are ready?  And why
> can't the both be replaced with something line thermal_zone_register()
> doing all of the necessary things in one go?  Why do we have to make
> confusing and redundant changes?

Or you can define a thermal_register_tripless_zone() wrapper around
thermal_zone_device_register_with_trips() and make the drivers in
question use that, and modify them just once.