MIME-Version: 1.0
References: <20230203175832.3406504-1-daniel.lezcano@linaro.org>
 <CAJZ5v0jzLCQt22MhfaAvL8w+RP7Y-YqxUdcgQ2u2Tz9i0CS+2A@mail.gmail.com> <474338ff-26af-061e-1166-a1bd906ffe00@linaro.org>
In-Reply-To: <474338ff-26af-061e-1166-a1bd906ffe00@linaro.org>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 6 Feb 2023 19:13:12 +0100
Message-ID: <CAJZ5v0hfeeiBtVrN4e3JQcbTT1Jr1_iTWDUMZ4Yme3hvZeEkjA@mail.gmail.com>
Subject: Re: [PATCH] thermal: Hunt zero trip points thermal zones usage
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>, rjw@rjwysocki.net,
        linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
        Sebastian Reichel <sre@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Kees Cook <keescook@chromium.org>,
        "Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
        Chuansheng Liu <chuansheng.liu@intel.com>,
        ye xingchen <ye.xingchen@zte.com.cn>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 6, 2023 at 7:00 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> On 06/02/2023 17:08, Rafael J. Wysocki wrote:
> > On Fri, Feb 3, 2023 at 6:59 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> >>
> >> Some drivers are declaring a thermal zone without any thermal trip
> >> points.
> >>
> >> On the other side, we are introducing the function
> >> thermal_zone_device_register_with_trips() which provides an array of
> >> generic thermal trip points. When all the drivers will be converted to
> >> the generic trip points, keeping two functions will be useless.
> >>
> >> Most of the drivers are now using
> >> thermal_zone_device_register_with_trips() with the generic trip
> >> points. As soon as the remaining drivers are merged, the
> >> thermal_zone_device_register_with_trips() will be renamed to
> >> thermal_zone_device_register().
> >
> > So why is this the first time I'm learning about this plan?
>
> Well it is not a plan, it looked purely logical to me that the
> _with_trips variant was added to support the generic trip points in
> addition to the specific trips. As soon as all the drivers are
> converted, there is no need to have these two functions anymore and we
> can fall back to the previous name (or a shorter one).
>
> >> Obviously this renaming can only happen if there are no more user of
> >> the thermal_zone_device_register() function.
> >>
> >> This change uses thermal_zone_device_register_with_trips() with a NULL
> >> parameter for the trip point array instead of
> >> thermal_zone_device_register().
> >
> > And later it will be renamed to thermal_zone_device_register() again?
>
> Yes, that was the idea, unify the name and then use a cocci script to
> rename them all.
>
> > Can we just stop confusing people this way?
> >
> > What would be wrong with changing both
> > thermal_zone_device_register_with_trips() and
> > thermal_zone_device_register() together when we are ready?  And why
> > can't the both be replaced with something line thermal_zone_register()
> > doing all of the necessary things in one go?  Why do we have to make
> > confusing and redundant changes?
>
> For me the result will be the same, if you prefer to wait for all the
> drivers to be converted then it is fine for me.

Yes, please.