MIME-Version: 1.0
References: <20230203200138.3872873-1-jstultz@google.com> <20230203200138.3872873-2-jstultz@google.com>
 <20230205190753.4sgvtxxaqcvr45ei@offworld> <20230206172029.GO2948950@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20230206172029.GO2948950@paulmck-ThinkPad-P17-Gen-1>
From:   John Stultz <jstultz@google.com>
Date:   Mon, 6 Feb 2023 11:24:00 -0800
Message-ID: <CANDhNCrZg3RoC2q=323FTvcVoXD1gfQgXfdGw-Tgt4V7G7vk9g@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] locktorture: Add nested locking to mutex torture tests
To:     paulmck@kernel.org
Cc:     Davidlohr Bueso <dave@stgolabs.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 6, 2023 at 9:20 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> On Sun, Feb 05, 2023 at 11:07:53AM -0800, Davidlohr Bueso wrote:
> > On Fri, 03 Feb 2023, John Stultz wrote:
> >
> > > This patch adds randomized nested locking to the mutex torture
> > > tests, as well as new LOCK08 config files for testing mutexes
> > > with nested locking
> > >
> > > This was inspired by locktorture extensions originally implemented
> > > by Connor O'Brien, for stress testing the proxy-execution series:
> > >  https://lore.kernel.org/lkml/20221003214501.2050087-12-connoro@google.com/
> > >
> > > Comments or feedback would be greatly appreciated!
> > >
> > > Cc: Davidlohr Bueso <dave@stgolabs.net>
> > > Cc: "Paul E. McKenney" <paulmck@kernel.org>
> > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > Cc: Joel Fernandes <joel@joelfernandes.org>
> > > Cc: Juri Lelli <juri.lelli@redhat.com>
> > > Cc: Valentin Schneider <vschneid@redhat.com>
> > > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> > > Signed-off-by: John Stultz <jstultz@google.com>
> >
> > Just realized I sent two review tags for rtmutex, one was supposed
> > to be this patch.
> >
> > Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
>
> Thank you!
>
> I will apply this to these commits on my next rebase:
>
> f5a632cbbbea ("locktorture: Add nested locking to mutex torture tests")
> 83743c9839f5 ("locktorture: Add nested locking to rtmutex torture tests")
>
> John, if you send a new version of these, please add Davidlohr's review
> tags.

Yeah. I'll respin to address most of the feedback.

thanks
-john