Message-ID: <1760bfde-38b0-15e4-5cbf-ee60a15f2d7d@linaro.org>
Date:   Mon, 6 Feb 2023 21:17:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] soc: qcom: pmic_glink: add CONFIG_NET/CONFIG_OF
 dependencies
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
        YueHaibing <yuehaibing@huawei.com>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230206193804.191343-1-arnd@kernel.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20230206193804.191343-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6.02.2023 20:37, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> QMI is a network protocol, so anything using requires CONFIG_NET
> to be enabled as well:
> 
> WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS
>   Depends on [n]: NET [=n]
>   Selected by [m]:
>   - QCOM_PDR_HELPERS [=m]
> arm-linux-gnueabi-ld: drivers/soc/qcom/qmi_interface.o: in function `qmi_send_new_lookup':
> qmi_interface.c:(.text+0xf0): undefined reference to `kernel_sendmsg'
> 
> Add the dependency to both QCOM_PDR_HELPERS and QCOM_PMIC_GLINK to make
> it clearly what the dependency is when another PDR user is added.
> 
> pmic_glink also needs CONFIG_OF:
> 
> drivers/soc/qcom/pmic_glink_altmode.c: In function 'pmic_glink_altmode_probe':
> drivers/soc/qcom/pmic_glink_altmode.c:418:33: error: 'struct drm_bridge' has no member named 'of_node'
> 
> Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Missing sender s-o-b, but I think it's widely known that you're
the same Arnd.. :D

> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/soc/qcom/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 348fde2a8aae..a8f283086a21 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -91,12 +91,15 @@ config QCOM_OCMEM
>  config QCOM_PDR_HELPERS
>  	tristate
>  	select QCOM_QMI_HELPERS
> +	depends on NET
>  
>  config QCOM_PMIC_GLINK
>  	tristate "Qualcomm PMIC GLINK driver"
>  	depends on RPMSG
>  	depends on TYPEC
>  	depends on DRM
> +	depends on NET
> +	depends on OF
>  	select AUXILIARY_BUS
>  	select QCOM_PDR_HELPERS
>  	help