MIME-Version: 1.0
References: <20230203200138.3872873-1-jstultz@google.com> <20230203200138.3872873-4-jstultz@google.com>
 <20230205190548.7auywdoagy6txpla@offworld>
In-Reply-To: <20230205190548.7auywdoagy6txpla@offworld>
From:   John Stultz <jstultz@google.com>
Date:   Mon, 6 Feb 2023 12:37:56 -0800
Message-ID: <CANDhNCrG5zRZCFdz_k5fnsc8vqNbEu_9++qvR34FW_DXJcpVNA@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] locktorture: With nested locks, occasionally skip
 main lock
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Feb 5, 2023 at 11:33 AM Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Fri, 03 Feb 2023, John Stultz wrote:
>
> >@@ -754,21 +755,28 @@ static int lock_torture_writer(void *arg)
> >                       schedule_timeout_uninterruptible(1);
> >
> >               lockset_mask = torture_random(&rand);
> >+              skip_main_lock = nlocks && !(torture_random(&rand) % 100);
>
> For the sake of future readers of locktorture.c, this deserves a comment
> as to why we wanna skip the main lock (copy/paste from the changelog).

Good point! I'll send this update out soon.

Thanks again for the review and feedback!
-john