Date:   Mon, 6 Feb 2023 21:27:24 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Evan Green <evan@rivosinc.com>
Cc:     Palmer Dabbelt <palmer@rivosinc.com>,
        Conor Dooley <conor@kernel.org>, vineetg@rivosinc.com,
        heiko@sntech.de, slewis@rivosinc.com,
        Albert Ou <aou@eecs.berkeley.edu>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 6/6] selftests: Test the new RISC-V hwprobe interface
Message-ID: <Y+FwvI+xRg7zMhSx@sirena.org.uk>
References: <20230206201455.1790329-1-evan@rivosinc.com>
 <20230206201455.1790329-7-evan@rivosinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jIK7x70KbUt5/QNK"
Content-Disposition: inline
In-Reply-To: <20230206201455.1790329-7-evan@rivosinc.com>
Precedence: bulk


--jIK7x70KbUt5/QNK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 06, 2023 at 12:14:55PM -0800, Evan Green wrote:

> +int main(int argc, char **argv)
> +{

> --- /dev/null
> +++ b/tools/testing/selftests/riscv/libc.S

> +.global _start
> +_start:
> +.option push
> +.option norelax
> +	la gp, __global_pointer$
> +.option pop
> +
> +	la sp, stack
> +
> +	la t0, heap
> +	la t1, brk
> +	REG_S t0, 0(t1)
> +
> +	li a0, 0
> +	li a1, 0
> +
> +	call main

This looks like it's just a standard program entry but I don't speak
RISC-V asm so I might be missing something.  If that's the case might it
make sense to use nolibc here?

--jIK7x70KbUt5/QNK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPhcLsACgkQJNaLcl1U
h9AXOAf+KvTREbTPWHZKIdO47p4iBbiY9FSOG3Y7Acvd7aMmaPWWLQU1wRTSig9V
SfnXNrxRcXT7f9eKvDnU7SAYblPQOcEkK5tv6E2OWOY6H8VarpTCKT7rUvfKaV7A
+FKsr/AZsIH27agEvbS4fgCjyFR/MJtyK/PwzpwQ7bYPXQPAo6NVF/vniJj40HP0
5VGzoxXa+2r8AK0fbe3qDEeNcNe5piAGtK9BCUkaADpF3BZ/8qEhmGlM5bA39itb
qvgV/4NJ5VfUfWg+Te8h5j3VUprcPaX4epNacV5HP8lgfr3bO4ms4nl8pAqCGoTK
oPnl54sP9qzvh6fzkZropoE6/ek4AA==
=/PL7
-----END PGP SIGNATURE-----

--jIK7x70KbUt5/QNK--