Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <4d00ad17-3422-5b5f-b0bd-fc511e3eb21c@roeck-us.net>
Date:   Mon, 6 Feb 2023 14:11:25 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 1/2] platform/x86: dell-ddv: Add hwmon support
Content-Language: en-US
To:     Armin Wolf <W_Armin@gmx.de>, Hans de Goede <hdegoede@redhat.com>
Cc:     markgross@kernel.org, jdelvare@suse.com,
        platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230205205456.2364-1-W_Armin@gmx.de>
 <20230205205456.2364-2-W_Armin@gmx.de>
 <a7d2e011-142d-88b9-2591-cf4508f1b8c5@redhat.com>
 <20230206162303.GA195090@roeck-us.net>
 <08af724c-8c65-db41-ece8-f330f67a3dc2@gmx.de>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <08af724c-8c65-db41-ece8-f330f67a3dc2@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/6/23 13:19, Armin Wolf wrote:
> Am 06.02.23 um 17:23 schrieb Guenter Roeck:
> 
>> On Mon, Feb 06, 2023 at 03:13:25PM +0100, Hans de Goede wrote:
>>> Hi Armin,
>>>
>>> On 2/5/23 21:54, Armin Wolf wrote:
>>>> Thanks to bugreport 216655 on bugzilla triggered by the
>>>> dell-smm-hwmon driver, the contents of the sensor buffers
>>>> could be almost completely decoded.
>>>> Add an hwmon interface for exposing the fan and thermal
>>>> sensor values. Since the WMI interface can be quite slow
>>>> on some machines, the sensor buffers are cached for 1 second
>>>> to lessen the performance impact.
>>>> The debugfs interface remains in place to aid in reverse-engineering
>>>> of unknown sensor types and the thermal buffer.
>>>>
>>>> Tested-by: Antonín Skala <skala.antonin@gmail.com>
>>>> Tested-by: Gustavo Walbon <gustavowalbon@gmail.com>
>>>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>>> This looks nice and clean to me, thank you:
>>>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> I'm going to wait a bit with merging this to see if Guenter
>>> has any remarks. If there are no remarks by next Monday then
>>> I'll merge this for the 6.3 merge window.
>>>
>> I don't have any further remarks. I won't send an Ack, though.
>> I noticed that the empty lines before return statements distract
>> me sufficiently enough that I am not sure about the actual code.
>>
>> Guenter
> 
> I will send a 3rd revision of the patch series to remove those empty lines then.
> Speaking of a 3rd revision, i noticed that jiffies are not updated during suspend,
> so the sensor values might be wrong for a short time when resuming after a long time.
> 
> This can be solved by either usingktime_get_boottime_ns(), which does not stop during suspend, or by
> invalidating the sensor cache upon resume. Which method should be used
> in this case? Armin Wolf
> 

I would suggest to invalidate the sensor cache; that seems less complex.

Guenter