From:   Bjorn Andersson <andersson@kernel.org>
To:     agross@kernel.org, Tom Rix <trix@redhat.com>,
        konrad.dybcio@linaro.org
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: pmic_glink: remove redundant calculation of svid
Date:   Mon,  6 Feb 2023 14:30:39 -0800
Message-Id: <167572263441.3569822.2330094320781179275.b4-ty@kernel.org>
In-Reply-To: <20230206135831.1794583-1-trix@redhat.com>
References: <20230206135831.1794583-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 6 Feb 2023 05:58:31 -0800, Tom Rix wrote:
> gcc with W=1 reports
> drivers/soc/qcom/pmic_glink_altmode.c:223:13: error: variable ‘svid’ set but not used [-Werror=unused-but-set-variable]
>   223 |         u16 svid;
> 
> From reviewing the code, the setting of alt_port->svid does the same calculation.
> Both are not needed.  For debuggablity, keep the setting of local svid.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: pmic_glink: remove redundant calculation of svid
      commit: dcb4e7a57cbe8d85e4927f517ae28aab17596419

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>