MIME-Version: 1.0
References: <tencent_9E0636426959DE97692A50AF79A3D9888B08@qq.com>
In-Reply-To: <tencent_9E0636426959DE97692A50AF79A3D9888B08@qq.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 6 Feb 2023 14:54:03 -0800
Message-ID: <CAEf4BzZa2PxezazfhqUsDjcT0PJpk0rBOh=_9YdcXmc00dh6Kg@mail.gmail.com>
Subject: Re: [PATCH bpf-next] samples: bpf: Add macro SYSCALL() for aarch64
To:     Rong Tao <rtoax@foxmail.com>
Cc:     ast@kernel.org, Rong Tao <rongtao@cestc.cn>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        "open list:BPF [GENERAL] (Safe Dynamic Programs and Tools)" 
        <bpf@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 6, 2023 at 3:34 AM Rong Tao <rtoax@foxmail.com> wrote:
>
> From: Rong Tao <rongtao@cestc.cn>
>
> kernel arm64/kernel/sys.c macro __SYSCALL() adds a prefix __arm64_, we
> should support it for aarch64. The following is the output of the bpftrace
> script:
>
>     $ sudo bpftrace -l | grep sys_write
>     ...
>     kprobe:__arm64_sys_write
>     kprobe:__arm64_sys_writev
>     ...
>
> Signed-off-by: Rong Tao <rongtao@cestc.cn>
> ---

samples were converted to SEC("ksyscall") programs and BPF_KSYSCALL()
macro, there is not even samples/bpf/trace_common.h there. Please
check the latest bpf-next/master.


>  samples/bpf/trace_common.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/samples/bpf/trace_common.h b/samples/bpf/trace_common.h
> index 8cb5400aed1f..fafc699af0a3 100644
> --- a/samples/bpf/trace_common.h
> +++ b/samples/bpf/trace_common.h
> @@ -6,6 +6,8 @@
>  #define SYSCALL(SYS) "__x64_" __stringify(SYS)
>  #elif defined(__s390x__)
>  #define SYSCALL(SYS) "__s390x_" __stringify(SYS)
> +#elif defined(__aarch64__)
> +#define SYSCALL(SYS) "__arm64_" __stringify(SYS)
>  #else
>  #define SYSCALL(SYS)  __stringify(SYS)
>  #endif
> --
> 2.39.1
>