References: <cover.c238416f0e82377b449846dbb2459ae9d7030c8e.1675669136.git-series.apopple@nvidia.com>
 <44e6ead48bc53789191b22b0e140aeb82459e75f.1675669136.git-series.apopple@nvidia.com>
 <52d41a7e-1407-e74f-9206-6dd583b7b6b5@kernel.dk>
User-agent: mu4e 1.8.10; emacs 28.2
From:   Alistair Popple <apopple@nvidia.com>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     linux-mm@kvack.org, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org, jgg@nvidia.com, jhubbard@nvidia.com,
        tjmercier@google.com, hannes@cmpxchg.org, surenb@google.com,
        mkoutny@suse.com, daniel@ffwll.ch,
        "Daniel P . Berrange" <berrange@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org
Subject: Re: [PATCH 09/19] io_uring: convert to use vm_account
Date:   Tue, 07 Feb 2023 12:03:33 +1100
In-reply-to: <52d41a7e-1407-e74f-9206-6dd583b7b6b5@kernel.dk>
Message-ID: <87k00unusm.fsf@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWg3VTVMQStmYUR5QmlkN0hHdnloVkFuZzVUSURNMzh2dzg2MWNMVkp0bFU4?=
 =?utf-8?B?TXVmQVlTVFVhSUExNlkybWs2cVVqbzZjMXhNQXJCVWE3OVhKNmFyWTVEZUh1?=
 =?utf-8?B?THVvbnVxV3R1ZER2WjVMKzF1OGJHU2JITGVMRVZJaFMrWU5HbnY1a0NEUmVj?=
 =?utf-8?B?SUNGTC9sWmhNOG13MXV6QXF6ek9Vd3A3UHVFYjY2QkpzWEVhQnpFdTdzT0Zn?=
 =?utf-8?B?bURRS0xOT0dnM0R2bW9qVlA4VmJuL2pTbE5LVzJqcWNKQ1VabnA5QXgycUNH?=
 =?utf-8?B?aDJHZko0c1dMNDR5aThiMlc0WHpiNTlRN3E0eSs3R1VhWWM4dnBnSjEvNGhq?=
 =?utf-8?B?dDR0UFVVa29aSENtVTh0ZzhpdU9ESncvdzZ6Z0d4ZXRxVStUcDdoKy8zTHJI?=
 =?utf-8?B?aGpheW14U1ltRlpsclFvd09PeEN2NytOU21UeEU4NDArK01MVHh4VXB0RUlj?=
 =?utf-8?B?a3FHSGFLQTFpUXJab1E3TzM0UnMzMWZXK1FxcXdlTmhTKzByYjI1eFU2c1Vm?=
 =?utf-8?B?cFFmTnl1MEkrSlBTYnZuVVlRamd5L2tMcW1VY1Y3YTlKTmZxTFZLV0gxODZK?=
 =?utf-8?B?amtocmxUOWlpWkxlREdMNmdtbnZWNVEyMFpWN0xOYmcwaVluODNKMnZ0QlF0?=
 =?utf-8?B?YXpXZHdlMjduQUErQzlCYktLcUxpdktRdlV4YmFOMGdpWmN4alpQVkNMKy9y?=
 =?utf-8?B?eGh0MkFqejBncUdWNFBsaVp3Y0c1cXY5aU91KzNHR2NDMkc0VlJGNXNxYzF6?=
 =?utf-8?B?WEt5MS9hOWV5cFJXcVlyaFVoTkUzZDF6dGJ5Z0FPZTdsVVljVTlTOTc5cWdj?=
 =?utf-8?B?RFo5UktuTFBKRGhxdkpFYWpuQkk5eHcwYm00S2FmaThvWS9UQThBRmZXTThS?=
 =?utf-8?B?WkxIeXE3MVZQa3VpcTk4ZnBpSmF6WTQxUS9kcVZNZjA1L1Z1RUpwMCtWR2Nk?=
 =?utf-8?B?czBzOXdaYzFodk5XK1ZkRmVNVFlNNGxMUU14bkM0eUJmd2tIcHo3akp6blJ1?=
 =?utf-8?B?V1VsTzJOYjl2WWpBZkE5emdIRlZNUDBmZ2ZPaXNRL3EvaDF0U0RPZjRBOHFJ?=
 =?utf-8?B?Y3FjUEdDTnpKclYzNWFWVWNhSnJndGxKcWt4L3Z3UFhHUVhTMVArTnFSRnNY?=
 =?utf-8?B?MXVVdk5iVXJJamppdHdWbUZ1TmhMUmVKekY1b1RsQldrLytzdmtyWEJNVjVU?=
 =?utf-8?B?UG5XRWx0Tjg1Y0RmMTk1MTFWYk9YZzlYMW5UUnVaNjJ5T2I2STBFbXdBaUFi?=
 =?utf-8?B?bkZDMFNHM2JrNFlBdlcxM0JxWnJROStNQzh5M0JqZ1dnWW1UM0VVQ0I5YUQy?=
 =?utf-8?B?RUVlS1JjT1B4MzdBZC92SWNnYW9XUGxzNU11WkY3OE5Pc05XZzNrSlh3YjhL?=
 =?utf-8?B?NWFlUlExNzEyamtKVzdqVC9Qb201alI1cGYySzZPWm9ZSzhWVHNxTVZYbXZQ?=
 =?utf-8?B?QlIvYXF5UEtkRk9sTzJlcWZLRzEzWXd4eFpBUWhBaDBmYzZQNjU0L25lQWRW?=
 =?utf-8?B?bmIvbVVKS0VwVTZnZzNVKzVKUis1TG54SlNDY3BhZm05aWQxSVBQVDZEdWM2?=
 =?utf-8?B?WGxJRUFSTFJOOFBOYVR0SUIzdlRVdWtWRzJDamZJZlROTzN1TXdOd3Y4N1hC?=
 =?utf-8?B?VXZrMzcxWE9RVVMzVXY4OEloYjFSYTgraExZcE9tY0dtcnhocklId2FEeDgy?=
 =?utf-8?B?cEdTMGxsT2k2SDJ0Yk5KU0NUVmxsekpudlVLSGFOcVNzQjlYV010VjdqWkMw?=
 =?utf-8?B?RWJRa3R0VG42RGFBOHZQRkZYWHRPUDBhaDV3Uzl4RE5ZYitSdUtMWDJocWxY?=
 =?utf-8?B?SE92eXZpSTk4UEVwdjdrR2FTWVA4QzhQbjloYVJsSFpBNlNhL2xvT2lJVmVy?=
 =?utf-8?B?NDRhWHM1a0dCUmN4K2VXQXZNaU1NNmRIVG14TmNJaHBZYTJia0dGT3hhTTd2?=
 =?utf-8?B?YWRWSU1MNTlHZUJLQi9IT1VHclkxWndyeE5OVWNwQlUzTkhHTTlrLzZDM3VT?=
 =?utf-8?B?RkxQMmNoTXQwZW9QaitpUWROdTFYdE1XZGZOVXdlSDhhVkhubEEwVk1pNjRL?=
 =?utf-8?B?ZmxIQmlsME1UZ0ZSK2pOWS9vMm5MTVh6T3JyeWNCZldRQS9zYmFMSUN3amRQ?=
 =?utf-8?Q?NwqxvY6rok/UijyaFthKG701I?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb48ebc-2476-4309-bf48-08db08a84dfb
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 01:11:56.2210
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /5NFCdfWxqV09kgKurnP/sTRr0IlB65uKItveawSC4BIbc9GeDGAmhvroM78OBrJ68ZKE4Y94BXJfqeeDU9GBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5107
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Jens Axboe <axboe@kernel.dk> writes:

> On 2/6/23 12:47=E2=80=AFAM, Alistair Popple wrote:
>> Convert io_uring to use vm_account instead of directly charging pages
>> against the user/mm. Rather than charge pages to both user->locked_vm
>> and mm->pinned_vm this will only charge pages to user->locked_vm.
>
> Not sure how we're supposed to review this, when you just send us 9/19
> and vm_account_release() is supposedly an earlier patch in this series.
>
> Either CC the whole series, or at least the cover letter, core parts,
> and the per-subsystem parts.

Ok, thanks. Will be sure to add everyone to the cover letter and patch
01 when I send the next version.

For reference the cover letter is here:

https://lore.kernel.org/linux-mm/cover.c238416f0e82377b449846dbb2459ae9d703=
0c8e.1675669136.git-series.apopple@nvidia.com/

And the core patch that introduces vm_account is here:

https://lore.kernel.org/linux-mm/e80b61561f97296a6c08faeebe281cb949333d1d.1=
675669136.git-series.apopple@nvidia.com/

No problem if you want to wait for the resend/next version before
taking another look though.