Date:   Tue, 7 Feb 2023 11:28:11 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>
CC:     <linux-kernel@vger.kernel.org>, <bp@suse.de>, <x86@kernel.org>
Subject: Re: [PATCH 1/3] tools/x86/kcpuid: Fix avx512bw and avx512lvl fields
 in Fn00000007
Message-ID: <Y+HFSwrFmJdOdVsX@feng-clx>
References: <20230206141832.4162264-1-terry.bowman@amd.com>
 <20230206141832.4162264-2-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230206141832.4162264-2-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0jYw892W7Ucgf2D1t/wtkynvRzr3fzW9Ivk/NCpmaApw5IplEIp+sxgy5w1A?=
 =?us-ascii?Q?Q0R7UlVv+TQ0L2CuSwqaccTDEcXvNjJcLagCz1ku3ytOXDL5tA+VbCdICqGS?=
 =?us-ascii?Q?OMkyDYxtT6VxzUR0OCRLM6hlnWsxDQ4CO4YEgppR4iI+uuagdHPdti3TuK51?=
 =?us-ascii?Q?pkV1g2gXgEVrW+kHHoosk7rR33wpGDKiRy5ynYjAylsm8WSeMfjrrK+nWKEA?=
 =?us-ascii?Q?4k54BQEeiKGm9gbZpdkwh1gjyETnVG4gUwFjc1knPzT2GcyyPCzklF6kjBbR?=
 =?us-ascii?Q?7XFPc+f8JeErwy0IxfmTB3F/6uAH1C6Ex54eDuBstmbl+IWeGjHgOKnLgZp6?=
 =?us-ascii?Q?1CTF8jkg+FVgOIvliWMVJMBtnoerkxlWkeUNabTjdLJ+g5zTcviueoI4CUut?=
 =?us-ascii?Q?FiihwoZKXxSIRLLeOWPZOsEn36GJH8lRVF+P6CLAWy0yQBpUUkoIwwPtOG3H?=
 =?us-ascii?Q?hkShw5VICoXTvkZas5YkkRUimLNWSpxyMFbmAx4lH7gYhM5UEPs3e17ofzDn?=
 =?us-ascii?Q?CNaaOF4hOgu3tzqsZtt0056dCSi24MTEY/pyKktQueE4g9LqPw0ehfu8YgNb?=
 =?us-ascii?Q?IFMoCm22qJut15UQT3Mdd5x9FAlX1i7VLdpw5AQzA+0FDIw5vnhNF31S9J+1?=
 =?us-ascii?Q?51fHJ+UesNXO0bobhg1APMCl9U2THuqWSINO+SMQOx0jYFOsuqD0KXNgbNPT?=
 =?us-ascii?Q?Oo+Oc04SHf1DFjEVYs1iAfoFeA8LiC57RmUzAD1cHgIi/GZI69iRlWJuTCEG?=
 =?us-ascii?Q?tx047qxNurPNpKOyVJoIdOq6iKqbpEw7iirIQUCOvpIaOQahuhjuYtLJDt/W?=
 =?us-ascii?Q?e1yKJbaLWy/Vobvb2RsPWX9Xl/V1ITEwovSfLZNgvWgA4qEykwH6pIrbTxT7?=
 =?us-ascii?Q?JcYBDg3yr6kzhqF90KJ+kKkMDtd29AwFf/qAInBx2jdE8+rSzFy66WBYfP5K?=
 =?us-ascii?Q?isR+8szg5R2h2Ajji8X7l2MeL3yR3J+3C0eSFoB2C3pQec7UzKUCZIfUEQjH?=
 =?us-ascii?Q?011uv+wXZlx6dyi5Orz192qcJrzrorEfGe4+3iTAT4qOJpKe0MgjfAo+1Xdd?=
 =?us-ascii?Q?QeWqhtMFR71ZjeCsoQb4b9eOmfaOb2xN1+uK7tcYOVomEFbvP/TywlOup/b8?=
 =?us-ascii?Q?N7SseYNB0oxb2tCud51oRq5dp9ESJS7HPpOEErLCqDqV2Z9ALLOiDiOI9iRE?=
 =?us-ascii?Q?aLwA37A2u7cFwRis1aLa2dlzSBZ4h2YLOXmkR7gBEiTGp+x6LWgWxcI9K5wC?=
 =?us-ascii?Q?mUozrig3+En3t9ZgBgFeSh5/A42XDiQmp0KWMIlJiTtz5C+LwCIlR/tYepbD?=
 =?us-ascii?Q?gMjvfGDZc/PCTRPX2ygDBxn92mVcBUuqpoixLnSPzLfXFQq2FbpxG9GI46i2?=
 =?us-ascii?Q?noEiPpYfleOoQwlc5CqkefJTVAoxjmEmFgogOtW7nEHYFM2KkU6b6zfqvd+H?=
 =?us-ascii?Q?5EA0zndaqv27W6khCqRKbJ8zr8fCTZGdRqZb6lUm3Zvp8JEV6vY+Gze6VTcJ?=
 =?us-ascii?Q?z8+UjOvSjXFnDl8vUk/eeWb26s0ixK7H4l+sY2k4Rj1LqPJMB475+Q1jLzOl?=
 =?us-ascii?Q?/Z1Rlp6OAfUVHZUZHgLGqMBMQE0i/VOJV3GQbfZH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 92218c60-95be-44ab-0fcb-08db08bbfdd2
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 03:32:51.5097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rBJoD26Tkv9rkAIdNyNA5mx2UnvgBTcWhr4yhpC3zQHGcCokcQ7xW0ta0oaPx/3NgtvRTH4yPKnoSPSprPJzJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6806
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 06, 2023 at 08:18:30AM -0600, Terry Bowman wrote:
> Leaf Fn00000007 contains avx512bw at bit26 and avx512vl at bit28. This
> is incorrect per the SDM. Correct avx512bw to be bit30 and avx512lvl to be
> bit31.[1]
> 
> [1] Intel 64 and IA-32 Architectures Software Developer's Manual
>     Combined Volumes: 1, 2A, 2B, 2C, 2D, 3A, 3B, 3C, 3D and 4, December
>     2022, pg 3-220,Vol2A
> 
> Fixes: c6b2f240bf8d ("tools/x86: Add a kcpuid tool to show raw CPU features")

Thanks for the catch!

Reviewed-by: Feng Tang <feng.tang@intel.com>


> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Cc: feng.tang@intel.com <feng.tang@intel.com>
> Cc: x86@kernel.org
> ---
>  tools/arch/x86/kcpuid/cpuid.csv | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/arch/x86/kcpuid/cpuid.csv b/tools/arch/x86/kcpuid/cpuid.csv
> index 4f1c4b0c29e9..9914bdf4fc9e 100644
> --- a/tools/arch/x86/kcpuid/cpuid.csv
> +++ b/tools/arch/x86/kcpuid/cpuid.csv
> @@ -184,8 +184,8 @@
>  	 7,    0,  EBX,     27, avx512er, AVX512 Exponent Reciproca instr
>  	 7,    0,  EBX,     28, avx512cd, AVX512 Conflict Detection instr
>  	 7,    0,  EBX,     29, sha, Intel Secure Hash Algorithm Extensions instr
> -	 7,    0,  EBX,     26, avx512bw, AVX512 Byte & Word instr
> -	 7,    0,  EBX,     28, avx512vl, AVX512 Vector Length Extentions (VL)
> +	 7,    0,  EBX,     30, avx512bw, AVX512 Byte & Word instr
> +	 7,    0,  EBX,     31, avx512vl, AVX512 Vector Length Extentions (VL)
>  	 7,    0,  ECX,      0, prefetchwt1, X
>  	 7,    0,  ECX,      1, avx512vbmi, AVX512 Vector Byte Manipulation Instructions
>  	 7,    0,  ECX,      2, umip, User-mode Instruction Prevention
> -- 
> 2.34.1
>