Date:   Tue, 7 Feb 2023 11:49:24 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>
CC:     <linux-kernel@vger.kernel.org>, <bp@suse.de>, <x86@kernel.org>
Subject: Re: [PATCH 2/3] tools/x86/kcpuid: Update AMD leaf Fn80000001
Message-ID: <Y+HKRLN//GnP0c5r@feng-clx>
References: <20230206141832.4162264-1-terry.bowman@amd.com>
 <20230206141832.4162264-3-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230206141832.4162264-3-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dQ4/trRhzB1b+N6nBaieSR9la681lXy3jcN/8gt9xoldXmOi6KxjChowl8+X?=
 =?us-ascii?Q?amQLwhMFceOnuVEDEcfNtXldDFuG2ZHWYsSDMNXq76KVOMXkoMcDmvCo8yfO?=
 =?us-ascii?Q?tYuYdC0avpC2QerNYV0n53UIFk4cKfbvlKBN5FOdgWgK49vOslX7ix3olgY1?=
 =?us-ascii?Q?/cVkJta2uUeFeJjt4MhkwfioxPI/HN0CyELPjyaTUpJ7X2UF+mb7qw+Rs/B3?=
 =?us-ascii?Q?5GDlqE7QqPImLm243uRoBMUoBJoYJ1C18dGuLvAjzSQtUy+iJQUR3KLexpdU?=
 =?us-ascii?Q?burwOzbRCBrd59+JUO3EotvWOb5UJALmY9gwJSYJI1+B9j2LcKTz9OzZOsEd?=
 =?us-ascii?Q?IMx9pGBjNJMzQnqZAuowIaJTbXDNitHB9WN+7sDs8mQTYIhZ1S/sAKvqszx2?=
 =?us-ascii?Q?sJVqWQMB6szzPbZiOvKLuHuGvlMT673XY8Bqz6yrnWOrc2FqNa7GbgicVvl0?=
 =?us-ascii?Q?jJPWHQ8gVrrOV1CJCRAVj5ISz4Lcn+6QqCrn9kegdB2471TOmiwZEtLw3C/R?=
 =?us-ascii?Q?CtD6Ej/Q3HqKoQNeV7pJiBHzdbyXm/ZgpkJ/hCNXhGrMn6RxC0prgbTcRr3F?=
 =?us-ascii?Q?7ZsX+twJfFpM+rlYuHShKp7EObGqIeofDs3sjD87iNZg4PKA8QP2fwWJo5PA?=
 =?us-ascii?Q?egdwMsOWubO7ER81Z548bBqJNbLD0VeyDy4XYGyuuSzCLQpl2au2qSaeRIRO?=
 =?us-ascii?Q?rCeZPH++G1g6Eidro6CSbdDFbK0gYNy2zuY9TfyjOaZ3a5Ku6F4aDWmJPZDd?=
 =?us-ascii?Q?+2sAjxGuqleias/+g7MA2jLRjefiLHNdDWtFEch2dHgjO/ZbJ3GHXtJ5JfQ2?=
 =?us-ascii?Q?x+ulIO2nCFiq+Jqan0VpUSAClTG6cVQqUPnxrstytnSRqoWkATJJtim1dEID?=
 =?us-ascii?Q?65VSZSgupqD97+8NRayrPLGpoHUnJD6CfWLh86W9l4Xv+sOWvU4It+9APXTO?=
 =?us-ascii?Q?+bCBDlor+kqBB72q1+qgyFOcyZ/Q72UyiBHO6wild2FlSHL8MHbH1sf1b5OK?=
 =?us-ascii?Q?XGCca5jzeR0Pz+1ZWF6tWOsSt4K0WUq/D5IJI45qAXVykP+PvyJI5lkFzVNP?=
 =?us-ascii?Q?/4JR2PfBX8wghHjX2gp2nqAuD3Aa7sHvxqX3N9KvkO1jAcaUHBS0X7KXKXCf?=
 =?us-ascii?Q?QusjpRHIO74JLZKHbFo1t0Wh2LhVjch0eTQbli+vI4zxOYOcGlRPGc120iZy?=
 =?us-ascii?Q?G4RoNol8Utc4CYHpx9lW86Iuj6davWkkcpF3VMlfeRpfJVBVoiXp3GWv+Lpn?=
 =?us-ascii?Q?IxOcXNONpP7wBJD4fb05XbKr7szkAt6fEpBL8idf1WDEgUupXTZui0Ntpozo?=
 =?us-ascii?Q?MZ/cVhgGuPP4bODEXmngjCPAccji91xtIZ5IwCpkuAWzLSd0dyYDtQ1IoSyf?=
 =?us-ascii?Q?6RGcZTcGgm+1h6EuamuNQAw75WvGR2V4ymDEd43cSpwuKZNWPBNW0HG/kZYY?=
 =?us-ascii?Q?qiZK/nZtoGHu4Iu6qKVJrPNUIqlsgO6YWkZE+NA7ERqsrsWn8DEgA5kJ62Ja?=
 =?us-ascii?Q?9sWn7PF5NnbTqDZYzYmHDO7YGhdxmH2TLNDeWj01U4ILDvM6DfcIw38M3WXf?=
 =?us-ascii?Q?JT5O0t10xgfQM7C/2LWtoQ9PK6Pe26mKkcCadEMH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b09d0bc-5754-436e-db35-08db08bef4cb
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 03:54:04.8116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IGR0CnRRgTDY5BT+TCq0IQeOeqOLtttKU2VxQerh+qsgseln0W27uUuza2byZGnaGvd1ok+f3sClBLzDpu2pMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4851
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 06, 2023 at 08:18:31AM -0600, Terry Bowman wrote:
> Add missing features to sub-leafs EAX, ECX, and EDX of 'Extended
> Processor Signature and Feature Bits' leaf Fn80000001.

Looks good to me, with some nits, that we were trying to make
the abbreviation short and clear, and some below could be shorter? 

Reviewed-by: Feng Tang <feng.tang@intel.com>

> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> ---
>  tools/arch/x86/kcpuid/cpuid.csv | 57 +++++++++++++++++++++++++++++++--
>  1 file changed, 54 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/arch/x86/kcpuid/cpuid.csv b/tools/arch/x86/kcpuid/cpuid.csv
> index 9914bdf4fc9e..e0c25b75327e 100644
> --- a/tools/arch/x86/kcpuid/cpuid.csv
> +++ b/tools/arch/x86/kcpuid/cpuid.csv
> @@ -340,19 +340,70 @@
>  # According to SDM
>  # 40000000H - 4FFFFFFFH is invalid range
>  
> -
>  # Leaf 80000001H
>  # Extended Processor Signature and Feature Bits
>  
> +0x80000001,    0,  EAX,  27:20, extfamily, Extended family
> +0x80000001,    0,  EAX,  19:16, extmodel, Extended model
> +0x80000001,    0,  EAX,   11:8, basefamily, Description of Family
> +0x80000001,    0,  EAX,   11:8, basemodel, Model numbers vary with product
> +0x80000001,    0,  EAX,    3:0, stepping, Processor stepping (revision) for a specific model
> +
> +0x80000001,    0,  EBX,  31:28, pkgtype, Specifies the package type
> +
>  0x80000001,    0,  ECX,      0, lahf_lm, LAHF/SAHF available in 64-bit mode
> +0x80000001,    0,  ECX,      1, cmplegacy, Core multi-processing legacy mode
> +0x80000001,    0,  ECX,      2, svm, Indicates support for: VMRUN, VMLOAD, VMSAVE, CLGI, VMMCALL, and INVLPGA
> +0x80000001,    0,  ECX,      3, extapicspace, Extended APIC register space
> +0x80000001,    0,  ECX,      4, altmovecr8, Indicates support for LOCK MOV CR0 means MOV CR8
>  0x80000001,    0,  ECX,      5, lzcnt, LZCNT
> +0x80000001,    0,  ECX,      6, sse4a, EXTRQ, INSERTQ, MOVNTSS, and MOVNTSD instruction support
> +0x80000001,    0,  ECX,      7, misalignsse, Misaligned SSE Mode
>  0x80000001,    0,  ECX,      8, prefetchw, PREFETCHW
> -
> +0x80000001,    0,  ECX,      9, osvw, OS Visible Work-around support
> +0x80000001,    0,  ECX,     10, ibs, Instruction Based Sampling
> +0x80000001,    0,  ECX,     11, xop, Extended operation support
> +0x80000001,    0,  ECX,     12, skinit, SKINIT and STGI support
> +0x80000001,    0,  ECX,     13, wdt, Watchdog timer support
> +0x80000001,    0,  ECX,     15, lwp, Lightweight profiling support
> +0x80000001,    0,  ECX,     16, fma4, Four-operand FMA instruction support
> +0x80000001,    0,  ECX,     17, tce, Translation cache extension
> +0x80000001,    0,  ECX,     22, TopologyExtensions, Indicates support for Core::X86::Cpuid::CachePropEax0 and Core::X86::Cpuid::ExtApicId
				topoext or TopoExt?

> +0x80000001,    0,  ECX,     23, perfctrextcore, Indicates support for Core::X86::Msr::PERF_CTL0 - 5 and Core::X86::Msr::PERF_CTR
> +0x80000001,    0,  ECX,     24, perfctrextdf, Indicates support for Core::X86::Msr::DF_PERF_CTL and Core::X86::Msr::DF_PERF_CTR
> +0x80000001,    0,  ECX,     26, databreakpointextension, Indicates data breakpoint support for Core::X86::Msr::DR0_ADDR_MASK, Core::X86::Msr::DR1_ADDR_MASK, Core::X86::Msr::DR2_ADDR_MASK and Core::X86::Msr::DR3_ADDR_MASK
> +0x80000001,    0,  ECX,     27, perftsc, Performance time-stamp counter supported
> +0x80000001,    0,  ECX,     28, perfctrextllc, Indicates support for L3 performance counter extensions
> +0x80000001,    0,  ECX,     29, mwaitextended, MWAITX and MONITORX capability is supported

				mwaitext?
				
> +0x80000001,    0,  ECX,     30, admskextn, Indicates support for address mask extension (to 32 bits and to all 4 DRs) for instruction breakpoints
> +
> +0x80000001,    0,  EDX,      0, fpu, x87 floating point unit on-chip
> +0x80000001,    0,  EDX,      1, vme, Virtual-mode enhancements
> +0x80000001,    0,  EDX,      2, de, Debugging extensions, IO breakpoints, CR4.DE
> +0x80000001,    0,  EDX,      3, pse, Page-size extensions (4 MB pages)
> +0x80000001,    0,  EDX,      4, tsc, Time stamp counter, RDTSC/RDTSCP instructions, CR4.TSD
> +0x80000001,    0,  EDX,      5, msr, Model-specific registers (MSRs), with RDMSR and WRMSR instructions
> +0x80000001,    0,  EDX,      6, pae, Physical-address extensions (PAE)
> +0x80000001,    0,  EDX,      7, mce, Machine Check Exception, CR4.MCE
> +0x80000001,    0,  EDX,      8, cmpxchg8b, CMPXCHG8B instruction
> +0x80000001,    0,  EDX,      9, apic, advanced programmable interrupt controller (APIC) exists and is enabled
>  0x80000001,    0,  EDX,     11, sysret, SYSCALL/SYSRET supported
> +0x80000001,    0,  EDX,     12, mtrr, Memory-type range registers
> +0x80000001,    0,  EDX,     13, pge, Page global extension, CR4.PGE
> +0x80000001,    0,  EDX,     14, mca, Machine check architecture, MCG_CAP
> +0x80000001,    0,  EDX,     15, cmov, Conditional move instructions, CMOV, FCOMI, FCMOV
> +0x80000001,    0,  EDX,     16, pat, Page attribute table
> +0x80000001,    0,  EDX,     17, pse36, Page-size extensions
>  0x80000001,    0,  EDX,     20, exec_dis, Execute Disable Bit available
> +0x80000001,    0,  EDX,     22, mmxext, AMD extensions to MMX instructions
> +0x80000001,    0,  EDX,     23, mmx, MMX instructions
> +0x80000001,    0,  EDX,     24, fxsr, FXSAVE and FXRSTOR instructions
> +0x80000001,    0,  EDX,     25, ffxsr, FXSAVE and FXRSTOR instruction optimizations
>  0x80000001,    0,  EDX,     26, 1gb_page, 1GB page supported
>  0x80000001,    0,  EDX,     27, rdtscp, RDTSCP and IA32_TSC_AUX are available
> -#0x80000001,    0,  EDX,     29, 64b, 64b Architecture supported
> +0x80000001,    0,  EDX,     29, lm, 64b Architecture supported
> +0x80000001,    0,  EDX,     30, threednowext, AMD extensions to 3DNow! instructions
> +0x80000001,    0,  EDX,     31, threednow, 3DNow! instructions
				3dnowext
				3dnow

I'm not good at naming :) and you may find better names.

Thanks,
Feng

>  
>  # Leaf 80000002H/80000003H/80000004H
>  # Processor Brand String
> -- 
> 2.34.1
>