From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>
Subject: RE: [PATCH v2 10/14] vfio-iommufd: Add detach_ioas for emulated VFIO
 devices
Thread-Topic: [PATCH v2 10/14] vfio-iommufd: Add detach_ioas for emulated VFIO
 devices
Thread-Index: AQHZOgpBycYF2k4go06YrPFjr863NK7DAPzg
Date:   Tue, 7 Feb 2023 06:08:30 +0000
Message-ID: <BN9PR11MB5276A57FBB6F999DB242CFB78CDB9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230206090532.95598-1-yi.l.liu@intel.com>
 <20230206090532.95598-11-yi.l.liu@intel.com>
In-Reply-To: <20230206090532.95598-11-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hkwFRHftXwyCtKrA9RoZYoQEQ7hDn9bsAEJGFSFKqRajS58K+zhFDY+2USCi?=
 =?us-ascii?Q?qi5hdTtvuM5HyrP/+HI1y/1FWH/w0lRchPqqhTZ4JcPJPpQ9VdPzb5Dn9enQ?=
 =?us-ascii?Q?cqPtVYKkuBw87G6cTYH7xYOGAuOuKny0IwF7jWR6t3WwYJH+FppndvOWJggb?=
 =?us-ascii?Q?CHxi1PFF6MRsCswdjDip4LOvwi+QxmtHWG5oFGaW9bY8QK+DOtjjwJpC7vVo?=
 =?us-ascii?Q?cSahAPEsok0dm0RHvOfsfbqIIJ+81EaLV8z0It8VNKd1NLn8Hm++wCFLry+A?=
 =?us-ascii?Q?kMsz8kz06h47ZK1NQgf0yDkLAn7SfDISG0Efz1t+fQGurs0WfsT19KfTT9DG?=
 =?us-ascii?Q?2y3yX/e+5CcZyCBvKcbUGvL+pgBKF5El5GJm98VY6bmGAAvF302vLWI2BWBf?=
 =?us-ascii?Q?4OuqtazkuiH89YxgZh42/V8O2jDbHT1n/9mjnE994bLZ4OPdefebvHj74aN7?=
 =?us-ascii?Q?RO7NBZ/J/J53Fd6Md8OdPJK6cAheN/+kyQetZmdJB4W+5Vzs6v4AocJ9bpJ8?=
 =?us-ascii?Q?eW1n00QeyiLqrsOLJ/YMDJq/GXD7kxatJNnLr2S75zB6s/JzaX+IF/0gsIke?=
 =?us-ascii?Q?3LfQQr+8O2Ddp5yWmszGCGzO7l7aR8/0+RzLpGePLYkwyR7/7uxlDEL8rqvz?=
 =?us-ascii?Q?JMYW4diYcyToXNY44T0/MSfMPhgA0eJmyOdKaNdVhQMM0rFBF5Zm+H2ES1HY?=
 =?us-ascii?Q?/7JdpqZEO+bttEE8PC7XsaRoCA55h040E7ird8GF9nlFBTU1TDJByUEpvfDY?=
 =?us-ascii?Q?x6aS0zkFBWXh714oxSkqif6qTP+ICjETBsT5mkGx/IMnqyoxcgk6Edy4gbQw?=
 =?us-ascii?Q?vnerzpNSfVgy60H4uTTCxsUvUKo9uD4tFqfwoAvFVNPRYj2EejoBnTrjnu79?=
 =?us-ascii?Q?4oLOBcH8iwurnLck2Ouui1aNTWEgLpbgCKQivLKkb8Wsy9GVG3mBeNDMOgFQ?=
 =?us-ascii?Q?VJ2Yi7YoY0G3TjUPHjzcvDU+jy8BWzqpwoXsOTMj31tHdoY9AnUpvp7BB/MQ?=
 =?us-ascii?Q?2mmcnaTXtDPPOPxbDAprpLsoE2tmhOsXWa2ABFRHfacrO8FC3ivNjnpOR3en?=
 =?us-ascii?Q?UB6fn/w41MYHFFShBnMQoIpV1mzJtGS96DCk/0bjhZx9bOYVM35CxnEU0HXh?=
 =?us-ascii?Q?xk9qWCq7BoIShLSwNU3ay4tg1ihX8i9VqTzdtKqwsviUusCPDwafeVRgNMg7?=
 =?us-ascii?Q?NL3cCd4Y+0AWLj3DotaAmZHCTjcUAEKTMOpoagYwdmMX2GmVEnwHQxM4NhYx?=
 =?us-ascii?Q?8EC/8jFMYiJ5WAsVvWmLhso+iMtbCT06oAb6gQa9mm19kavhAhbWvrs6KwL8?=
 =?us-ascii?Q?oz77w5LNZF0nPUmHTjT3HQZ+mosg1tCgfGjF6iIz1nb5wRRRbNfJnx0zB6yD?=
 =?us-ascii?Q?c8r3irs7uZvjKCAZHqbjAjLkaM0tmuX/MPrE2lLmAu59bwTQABVLMeQlTCk0?=
 =?us-ascii?Q?BPuqzw6wjvFBeVhDOe1mTDyc0n/ROtzlNMzWsG+dqsltA61nFSHGD4lxgSBd?=
 =?us-ascii?Q?x6CL9EocFMyNf0vE9XCSiaZmJBgnioDEQKBra9LBT1xxA6+0pEJDTDnS/aMd?=
 =?us-ascii?Q?JjqsxwI89bLPkErAKRAGUO6o1+lqpdQpOB7QKpSQ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97495722-e618-4e87-c830-08db08d1bc5b
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 06:08:30.4063
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3NGS0Cq0THCWpOdjUw8fLJpznvs64JW7rt3QKOlaUrWuWox0x/8haaNwxY8QWbWP2o5jx7Lzo+Ao6UA0UrujSQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7509
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Monday, February 6, 2023 5:05 PM
> @@ -149,14 +149,18 @@ int vfio_iommufd_emulated_bind(struct
> vfio_device *vdev,
>  }
>  EXPORT_SYMBOL_GPL(vfio_iommufd_emulated_bind);
>=20
> +static void __vfio_iommufd_access_destroy(struct vfio_device *vdev)
> +{
> +	iommufd_access_destroy(vdev->iommufd_access);
> +	vdev->iommufd_access =3D NULL;
> +}
> +
>  void vfio_iommufd_emulated_unbind(struct vfio_device *vdev)
>  {
>  	lockdep_assert_held(&vdev->dev_set->lock);
>=20
> -	if (vdev->iommufd_access) {
> -		iommufd_access_destroy(vdev->iommufd_access);
> -		vdev->iommufd_access =3D NULL;
> -	}
> +	if (vdev->iommufd_access)
> +		__vfio_iommufd_access_destroy(vdev);

same comment as in last patch.