Message-ID: <bed49e26-bebe-bcd9-e69d-45981b86bf4e@gmail.com>
Date:   Tue, 7 Feb 2023 07:13:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 0/6] staging: r8188eu: remove intf_start and intf_stop
To:     Martin Kaiser <martin@kaiser.cx>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Michael Straube <straube.linux@gmail.com>,
        Pavel Skripkin <paskripkin@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20230206201800.139195-1-martin@kaiser.cx>
Content-Language: en-US
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <20230206201800.139195-1-martin@kaiser.cx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/6/23 21:17, Martin Kaiser wrote:
> Remove the two pointers to media-specific start and stop functions. The
> r8188eu driver supports only usb.
> 
> Update some of the functions in the start and stop paths to return
> standard error codes instead of _SUCCESS and _FAIL.
> 
> Martin Kaiser (6):
>    staging: r8188eu: pass a struct recv_buf to rtw_read_port
>    staging: r8188eu: use standard error codes in rtw_read_port
>    staging: r8188eu: use standard error codes in rtl8188eu_inirp_init
>    staging: r8188eu: remove intf_start pointer
>    staging: r8188eu: handle rtl8188eu_inirp_init errors
>    staging: r8188eu: remove intf_stop pointer
> 
>   drivers/staging/r8188eu/hal/usb_halinit.c   | 16 ++++++--------
>   drivers/staging/r8188eu/hal/usb_ops_linux.c | 20 ++++++++---------
>   drivers/staging/r8188eu/include/drv_types.h |  2 --
>   drivers/staging/r8188eu/include/hal_intf.h  |  2 +-
>   drivers/staging/r8188eu/include/rtw_io.h    |  2 +-
>   drivers/staging/r8188eu/os_dep/os_intfs.c   | 12 +++++------
>   drivers/staging/r8188eu/os_dep/usb_intf.c   | 24 +++------------------
>   7 files changed, 26 insertions(+), 52 deletions(-)
> 
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150