Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC433C636CC for ; Tue, 7 Feb 2023 07:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbjBGH0E (ORCPT ); Tue, 7 Feb 2023 02:26:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbjBGH0C (ORCPT ); Tue, 7 Feb 2023 02:26:02 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E97192F7A1 for ; Mon, 6 Feb 2023 23:26:00 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id mc11so40780929ejb.10 for ; Mon, 06 Feb 2023 23:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=4PbMaqlaAs8XwTKizqk29fmyW5QEUltN7QWV6+8gPqQ=; b=auNwRerGcNxS7nL+g62YAL6XH4KGoYQwg79fwLZymRUnNjD1fNsp6MJW0JPJCU+Zae rQEDHv8yXOdN9+ZvmR2Sgn6l5Q2tuHUzw0B+vvz/BlrXsd9yX90gnOuuZItK6QFJO5MV Wv94XwaiA1erkCCRuy/1ke/bDS6B4cCRXZojDJJWEW872XzsY58hJuzqhg9EF9TLWgun NlhC7jDNDiK63erMB+WaefZbpOdL21m8JEws0+ET0hxfzOMi8Sasx+T8y4GGbfGTKMic Uoquc9eKYixQnvlo/ONExiv9sLa+k1YrBw1HBTyu0xpTwD8F4JNfO4mbW0MFojl0+hXw jXGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4PbMaqlaAs8XwTKizqk29fmyW5QEUltN7QWV6+8gPqQ=; b=DQI26UlAf+3tupIwK0+yIhuLA5sN7hqLP4GI4d2VfzvaFKclvK3QXpN5tZP527U8a2 wgoT/aZNU0d7we3STS2Box67m8L2Fo5KKIHrCbSIeoT5j73z7YaIjepXs28JIxy9z3ZQ +XnX0v7OatzJFG6gX2+k+le7gbtoYbfZxopHmftwZc6ViEvZPqf6cj6/sZ6Czl8zlMiU UzbOORXzbjXd3vnxjr/3xGmSmQ9srakh7hU9X85uph8QiZQor2pRuXai7BWHKVT2UmtQ PREg/Y1ky6sDVKBHH9LJP8v6to7DviDD0S6LhF4tKfnsoxFJrs0A4PlLZNmdJXgknlhi NDIw== X-Gm-Message-State: AO0yUKU+6XXdA01LaOzH3qbXuJU99aVKDFKCBUyPnqgBET6L8n6YEhPQ ao0cYTEEYlCNwIkH9MXn7a4= X-Google-Smtp-Source: AK7set8k+E9hTWiTUn73QYFkHjaNl56pi6HHqcXSId5c7nl8yDJOlsSDQigICKFVI+o0BikZ9LRBnQ== X-Received: by 2002:a17:906:2ed4:b0:888:a32d:b50 with SMTP id s20-20020a1709062ed400b00888a32d0b50mr2115663eji.40.1675754759302; Mon, 06 Feb 2023 23:25:59 -0800 (PST) Received: from combine-ThinkPad-S1-Yoga (c-8ff371d5.879159-0-69706f6e6c79.bbcust.telenor.se. [213.113.243.143]) by smtp.gmail.com with ESMTPSA id w5-20020a170906968500b008aa05cacdb4sm292525ejx.165.2023.02.06.23.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 23:25:58 -0800 (PST) Date: Tue, 7 Feb 2023 08:25:57 +0100 From: Guru Mehar Rachaputi To: Greg Kroah-Hartman Cc: Christophe JAILLET , Forest Bond , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: vt6655: Macro with braces issue change to inline function Message-ID: References: <3cb45313-209a-8190-12f8-6a2d49e4173b@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2023 at 10:43:56AM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 06, 2023 at 12:39:08AM +0100, Guru Mehar Rachaputi wrote: > > On Sun, Feb 05, 2023 at 08:12:31PM +0100, Christophe JAILLET wrote: > > > Le 05/02/2023 ? 19:11, Guru Mehar Rachaputi a ?crit?: > > > > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better > > > > as '(iobase)' to avoid precedence issues" changed to inline function. In > > > > relation to this, names of the callers of macro are also modified to call > > > > this function. > > > > > > > > Signed-off-by: Guru Mehar Rachaputi > > > > > > Hi, > > > > > > this patch should be v4. > > > You re-sent it with a modified commit message (the position of your S-o-b) > > > > > > The idea behind patch versions is to help maintainer. With the way you did, > > > now 2 patches stating v3 are available. > > > Which one is the correct one? > > > The maintainer would need to look at both, search for differences, maybe > > > look at the date of the mails. > > > A v4 would be much easier for him. > > > > > > > > > Also, when you send an updated version of a patch, it should always be > > > "complete". I mean that the patch below seems to need v2, and maybe even v1 > > > (which is apparently not on the linux-kernel mailing list). > > > > > > A maintainer can't know by himself what is needed and what is not. > > > > > > So you should resend a new patch. > > > It should be a v4, and it should include what is needed from (v1?), v2 and > > > v3 all together. > > > > > > CJ > > > > > > > > > > --- > > > > Changes in v3: > > > > - Whitespace error from checkpatch fixed > > > > > > > > Changes in v2: > > > > - Macros with one statement that is to call 'iowrite8' function changed > > > > to inline function as reviewed by gregkh@linuxfoundation.org. > > > > In relation to this, names of the callers of macro are also modified > > > > to call this function. > > > > --- > > > > drivers/staging/vt6655/card.c | 3 +-- > > > > drivers/staging/vt6655/channel.c | 2 +- > > > > drivers/staging/vt6655/mac.h | 4 ++-- > > > > 3 files changed, 4 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c > > > > index a6ff496b01b6..d2d122dc16d8 100644 > > > > --- a/drivers/staging/vt6655/card.c > > > > +++ b/drivers/staging/vt6655/card.c > > > > @@ -643,8 +643,7 @@ void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type) > > > > &byRsvTime); > > > > iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_72); > > > > /* Set to Page0 */ > > > > - vt6655_mac_select_page0(priv->port_offset); > > > > - > > > > + vt6655_mac_select_page0(priv->port_offset); > > > > spin_unlock_irqrestore(&priv->lock, flags); > > > > } > > > > diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c > > > > index e9a44bcebe32..60b445c38424 100644 > > > > --- a/drivers/staging/vt6655/channel.c > > > > +++ b/drivers/staging/vt6655/channel.c > > > > @@ -121,7 +121,7 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch) > > > > iowrite8(priv->byCurPwr, priv->port_offset + MAC_REG_PWRCCK); > > > > RFbSetPower(priv, RATE_6M, priv->byCurrentCh); > > > > iowrite8(priv->byCurPwr, priv->port_offset + MAC_REG_PWROFDM); > > > > - vt6655_mac_select_page0(priv->port_offset); > > > > + vt6655_mac_select_page0(priv->port_offset); > > > > spin_unlock_irqrestore(&priv->lock, flags); > > > > } > > > > diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h > > > > index b9a7ca0fe604..ae3064303691 100644 > > > > --- a/drivers/staging/vt6655/mac.h > > > > +++ b/drivers/staging/vt6655/mac.h > > > > @@ -539,12 +539,12 @@ > > > > static inline void vt6655_mac_select_page0(void __iomem *iobase) > > > > { > > > > - iowrite8(0, iobase + MAC_REG_PAGE1SEL); > > > > + iowrite8(0, iobase + MAC_REG_PAGE1SEL); > > > > } > > > > static inline void vt6655_mac_select_page1(void __iomem *iobase) > > > > { > > > > - iowrite8(1, iobase + MAC_REG_PAGE1SEL); > > > > + iowrite8(1, iobase + MAC_REG_PAGE1SEL); > > > > } > > > > #define MAKEWORD(lb, hb) \ > > > > > > > Thanks for the explaination. > > Since I amended commit message and thought as there is no new commit it > > should still be the same patch. > > > > Is it ok if I send a new patchset based on the previous conversations? > > I have four commits now, 4th commit being just the commit message and > > this patchset doesn't have s-o-b issue. > > Look at other submissions on the mailing lists. When you submit a new > version of a patch, it is stand-alone, with no dependancies on anything > else, otherwise tracking that would be impossible, right? > > I suggest reading through the kernelnewbies.org "first patch submission" > tutorial first as I think it will answer questions like this. > > good luck! > > greg k-h Thanks for taking time. If my understanding is correct, every version of the patch should include all the patches/patchfiles and it should explain what happened in each version(in decrement order) through a coverletter. Please correct me otherwise. I do refer "first patch submission" and above is my current understanding. -- Thanks & Regards, Guru