From:   "Liu, Yi L" <yi.l.liu@intel.com>
To:     "Zhao, Yan Y" <yan.y.zhao@intel.com>
CC:     "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: RE: [PATCH v2 13/14] vfio: Add ioctls for device cdev using iommufd
Thread-Topic: [PATCH v2 13/14] vfio: Add ioctls for device cdev using iommufd
Thread-Index: AQHZOgpFACxvcC0IEkiFAGPnOf4DEa7C1/iAgABFGdA=
Date:   Tue, 7 Feb 2023 07:50:40 +0000
Message-ID: <DS0PR11MB752976AA5F3F5FF6A1CC246FC3DB9@DS0PR11MB7529.namprd11.prod.outlook.com>
References: <20230206090532.95598-1-yi.l.liu@intel.com>
 <20230206090532.95598-14-yi.l.liu@intel.com>
 <Y+HIWRM/TjWcuT6I@yzhao56-desk.sh.intel.com>
In-Reply-To: <Y+HIWRM/TjWcuT6I@yzhao56-desk.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kyASksqwhQ0HR7J0veWypp9c8dUVfeIfld2g1Qa5ZhY3R8MWotSpn7tzorDu?=
 =?us-ascii?Q?FrgMoLtQ0RUzLpSNyqtuT7b7YPg3EZ8HW/nCog5dF24qpPukfeWdXX3wT6Ky?=
 =?us-ascii?Q?np2H+uPwEfzotiVmhw1yOhFBrk6L1GQC/tEPS26xmt3ZoJmmisTf43Al8O+B?=
 =?us-ascii?Q?RHLF6KOBe3ioPIi8MmToL4u0rmyrY8PZfke4qrUkOnsx5bL5xox1jgecLqok?=
 =?us-ascii?Q?q7RQzyzZKK7GhpEPvkRtdoC9uTNJoOGU4U0hjSbvF6G92Gol7cVBt+wSdhny?=
 =?us-ascii?Q?RoPbtJaDgvqrwmsb3wpDlyCm2Ysv/xCHgGrWgKVVkpH3V545ncMmjaS1Sd63?=
 =?us-ascii?Q?R2J0uTRpizvGKE3iw6+Z7++SdG8w9nzp9E9VjuBYZvRQcfLaZjLpf1fuSKx5?=
 =?us-ascii?Q?1B1IiKYUukeIRhhIwzy3ISS8SP4FO6So0VlhigX1YjrTtpPolqyJmvV2w39K?=
 =?us-ascii?Q?x50EEWUnF36PTlHJ0hCMSUx/Ust+ocS3Pa4hiPiZ2RT3ihqF+Ou0Gk5MDZJs?=
 =?us-ascii?Q?pekVcR223v+iYVCkHDb+VtBGyrYnXclsW8R3gQv17Pj/Sg555PCKgAx3my7x?=
 =?us-ascii?Q?Xoozqp0SuTHE5emE+BH7E7krtACi3gOcbB1jYrAIMnAQbJ7r38RPrFuXIvSW?=
 =?us-ascii?Q?cEygu7nwmQvToaFloOj5bJ/q1Xag439WWb3ngZH6AQ7VFx/QaPqGQ/sOv/f4?=
 =?us-ascii?Q?uoDUwUXWGpYeRq0QRBhNL6j12tdmiNWH2C+gIT9wYr3aYHdk9FupMZHHxfid?=
 =?us-ascii?Q?dK/PHz8NMx3S7dFRkpiDPpc8MAolKM4gEv8mftC1IoAVvXkoRkBGP6CHFDCV?=
 =?us-ascii?Q?ebnYbPRLrQtQkj6ZDN72c/kFFdLsB72pGdBh+jY7azpnxIKuGr136DOles3D?=
 =?us-ascii?Q?P4Sac0D3padlkASTtZjxyNqlYDao91QySECTzk+jsh+eoHCi1BNEaWaFvTCb?=
 =?us-ascii?Q?jhy5WsKGARRi0WvZcVz/EsSm0iN78jlhFPzOWtL4OonCbJ9wlW1hI2cdvrB1?=
 =?us-ascii?Q?H8t2jZry8UNbI0kvlxADZ9tKN7KTBE4uMncJoz9xmR7qSwtQ0imxTDkP2CId?=
 =?us-ascii?Q?6NWjzEbL5iTyxWkIrxgpqoibb1tkVncuRLFdmhiLB7+xHvrEIzibKjNOUyew?=
 =?us-ascii?Q?9gZ+zivG91uA6o7Q1LLBjRLVoYVOR3k3PWeOEAB408gMXfEgqH/vFNEfRYJP?=
 =?us-ascii?Q?pIMhB3de2pB/qeK/HOnP9zJS5AvmkLz3ZxwvIVwByY8ZKG5Fsg2npdUahKBQ?=
 =?us-ascii?Q?ELaLWfzar6t9oPcLlG9CsgwGXPCa29epuGcLgmNYlrIqHwK6wLMqZ88Woc2a?=
 =?us-ascii?Q?+gSdAZ9thnpgNso0Rn2aMDiigf8AftkKGCDkG3leUBB3jVETDH8aFWQ7egll?=
 =?us-ascii?Q?Z06afHd3t+Q+cDeDPrxeYchrcplwh7hyqwczNGTAPG1pZBm5BpblopFtOOKa?=
 =?us-ascii?Q?xUrvO1VZ6UM4T79ak8pEJQUebUtjEoNDh8wgP1N9jdFXp7UAeyj2PxdBKe97?=
 =?us-ascii?Q?qFxpZvxpiTw+7c5w+Xyeacm2nSH4mFPXBS5afHLjK2+rLVvzpP2qSGfrQKZe?=
 =?us-ascii?Q?squTYEkQf9QFRKxFZe7QIsO0TQHGTZCJLquaznJk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7882da83-4530-449b-5ee6-08db08e0023f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 07:50:40.5836
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fH8/FEPEwC72SUNhphB/8ps1jALN/GYhWOqYlVVK2fiCUpUXLTX4Yy7NawKxrOrga9x8kZSySlVVpRE1uWWJFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8087
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Yan Zhao <yan.y.zhao@intel.com>
> Sent: Tuesday, February 7, 2023 11:41 AM
>=20
> On Mon, Feb 06, 2023 at 01:05:31AM -0800, Yi Liu wrote:
> ...
>=20
> > +void vfio_device_cdev_close(struct vfio_device_file *df)
> > +{
> > +	mutex_lock(&df->device->dev_set->lock);
> > +	vfio_device_close(df);
> > +	vfio_device_put_kvm(df->device);
> > +	mutex_unlock(&df->device->dev_set->lock);
> > +}
> > +
>=20
> ...
>=20
> > +long vfio_device_ioctl_bind_iommufd(struct vfio_device_file *df,
> > +				    unsigned long arg)
> > +{
> > +	struct vfio_device *device =3D df->device;
> > +	struct vfio_device_bind_iommufd bind;
> > +	struct iommufd_ctx *iommufd =3D NULL;
> > +	unsigned long minsz;
> > +	struct fd f;
> > +	int ret;
> > +
> > +	minsz =3D offsetofend(struct vfio_device_bind_iommufd, iommufd);
> > +
> > +	if (copy_from_user(&bind, (void __user *)arg, minsz))
> > +		return -EFAULT;
> > +
> > +	if (bind.argsz < minsz || bind.flags)
> > +		return -EINVAL;
> > +
> > +	if (!device->ops->bind_iommufd)
> > +		return -ENODEV;
> > +
> > +	mutex_lock(&device->dev_set->lock);
> > +	/*
> > +	 * If already been bound to an iommufd, or already set noiommu
> > +	 * then fail it.
> > +	 */
> > +	if (df->iommufd || df->noiommu) {
> > +		ret =3D -EINVAL;
> > +		goto out_unlock;
> > +	}
> > +
> > +	/* iommufd < 0 means noiommu mode */
> > +	if (bind.iommufd < 0) {
> > +		if (!capable(CAP_SYS_RAWIO)) {
> > +			ret =3D -EPERM;
> > +			goto out_unlock;
> > +		}
> > +		df->noiommu =3D true;
> > +	} else {
> > +		f =3D fdget(bind.iommufd);
> > +		if (!f.file) {
> > +			ret =3D -EBADF;
> > +			goto out_unlock;
> > +		}
> > +		iommufd =3D iommufd_ctx_from_file(f.file);
> > +		if (IS_ERR(iommufd)) {
> > +			ret =3D PTR_ERR(iommufd);
> > +			goto out_put_file;
> > +		}
> > +	}
> > +
> > +	/*
> > +	 * Before the first device open, get the KVM pointer currently
> > +	 * associated with the device file (if there is) and obtain a
> > +	 * reference. This reference is held until device closed. Save
> > +	 * the pointer in the device for use by drivers.
> > +	 */
> > +	vfio_device_get_kvm_safe(df);
> > +
> > +	df->iommufd =3D iommufd;
> > +	ret =3D vfio_device_open(df, &bind.out_devid, NULL);
> > +	if (ret)
> > +		goto out_put_kvm;
> > +
> > +	ret =3D copy_to_user((void __user *)arg + minsz,
> > +			   &bind.out_devid,
> > +			   sizeof(bind.out_devid)) ? -EFAULT : 0;
> > +	if (ret)
> > +		goto out_close_device;
> > +
> > +	if (iommufd)
> > +		fdput(f);
> > +	else if (df->noiommu)
> > +		dev_warn(device->dev, "vfio-noiommu device used by user
> "
> > +			 "(%s:%d)\n", current->comm,
> task_pid_nr(current));
> > +	mutex_unlock(&device->dev_set->lock);
> > +	return 0;
> > +
> > +out_close_device:
> > +	vfio_device_close(df);
> vfio_device_close() is called here if any error after vfio_device_open().
> But it will also be called unconditionally in vfio_device_cdev_close() an=
d
> cause a wrong value of device->open_count.

Oh, yes yes. Good catch. Vfio_device_cdev_close() should check either the
open_count or access_granted.

> df->access_granted in patch 07 can also be of wrong true value after
> this vfio_device_close().

access_granted will surely be wrong if open_count is not correctly
counted.

Regards,
Yi Liu