Message-ID: <b3b9d515-20b1-62a1-3243-b1bc36c306df@linaro.org>
Date:   Tue, 7 Feb 2023 08:59:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] arm64: dts: Add support for Unisoc's UMS512
Content-Language: en-US
To:     Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, soc@kernel.org,
        devicetree@vger.kernel.org,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20230118084025.2898404-1-chunyan.zhang@unisoc.com>
 <41fd5c2a-9fc5-8af8-b66e-45bb83b24179@linaro.org>
 <CAAfSe-v3VW_sE4FwjURoOapMXrGavOK0hzeU-84-U_6xfhYbQQ@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAAfSe-v3VW_sE4FwjURoOapMXrGavOK0hzeU-84-U_6xfhYbQQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07/02/2023 03:19, Chunyan Zhang wrote:
> On Thu, 19 Jan 2023 at 19:40, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 18/01/2023 09:40, Chunyan Zhang wrote:
>>> Add basic support for Unisoc's UMS512, with this patch,
>>> the board ums512-1h10 can run into console.
>>>
> 
> [snip]
> 
>>> +             ap-apb {
>>
>> Non-unit-address nodes cannot be mixed with unit address ones. Something
>> is wrong here.
> 
> To make sure I understand correctly, did you mean non-unit-address
> nodes shouldn't be the parent of unit-address nodes?
> 
> Does that mean the bus node should have a unique base address like:
>         ap-apb@70000000 {

No. I mean, run dtbs W=1 or dtbs_check DT_SCHEMA_FILES=simple-bus


Best regards,
Krzysztof