From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Natalia Petrova <n.petrova@fintech.ru>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
CC:     "lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v3] i40e: Add checking for null for
 nlmsg_find_attr()
Thread-Topic: [Intel-wired-lan] [PATCH v3] i40e: Add checking for null for
 nlmsg_find_attr()
Thread-Index: AQHZNlnuDC/c2QBywEW1r2ZcSsXzba7DVoLQ
Date:   Tue, 7 Feb 2023 10:48:14 +0000
Message-ID: <BYAPR11MB3367632E082D882E7A5D6D73FCDB9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20230125141328.8479-1-n.petrova@fintech.ru>
 <20230201090610.52782-1-n.petrova@fintech.ru>
In-Reply-To: <20230201090610.52782-1-n.petrova@fintech.ru>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HEa/K9GIW0BKdYhGe4rhdOzEfDYY8p1+rPTFKK/L6bPuod3WdwDRxAO5k1LW?=
 =?us-ascii?Q?TGfoTrQVafSAGpCvNfogCUXxi5Pm7dt1h2OJLqWGq/hftpBKqSnDyzerhQfs?=
 =?us-ascii?Q?qpVKPZVgR5o0eMIJZEujulfkI5sYTRXO1/ELvDa0NEP+xupUwTjxQD3JBezy?=
 =?us-ascii?Q?1I4SGClY/7tkF5zV5X8VybfCYvuUO38evHYFTJ6+5Oc1hZzee9gBwrBpHeHY?=
 =?us-ascii?Q?UdduFhW3j4iwwTHkg8r+bztF9ojMTFnQuOSnXaR8GwZRbrBnnUgYaMoheQYX?=
 =?us-ascii?Q?1wp8wyD8VV55uwD2qJFATDrKpEH3MjuiswmF4uUPllR8qAK3cW3I+uWcNW2P?=
 =?us-ascii?Q?9K5Gy5HYcV/ockRgIIaTgz81xlE8SasU4S1+I3jSYf4bOd2s/0iNx41baqMP?=
 =?us-ascii?Q?nwi/X17WbZVjSLDczrFuJLQWyg5W0QC0pHcQTwB1VBKcq03x6Anq6pPofkfE?=
 =?us-ascii?Q?jm/hxVuP//ZUp/3XmjlMGbNRwgUuHtaLp9uKN3vpQJr9rzlaJJxlHXvuiMlo?=
 =?us-ascii?Q?tkwwjcdrl1SWCYaoJfXEMgSU65bzi7CCfJl7Fv70ZtCyXNLjacLLwZ1rxqRd?=
 =?us-ascii?Q?jMPb6kY2Uaza/npwfO5HMk5vSTLuNi0VXbO4IVMxpW0ec1moq949wBTS7a7q?=
 =?us-ascii?Q?tvCRSG72ELyqqxOmrV2q6Ohk/bIAVTZIoYUyiEts4+vgN8eD1oDtfIHoENOt?=
 =?us-ascii?Q?R26d14BGtKUyjRnE5TR3kbbyuGX08DXPLhwiGpBhl6Ns3mbBi+eoaNkIraHx?=
 =?us-ascii?Q?oaqf+6XrBcL8MFvgTcSKoY070FI78rRrTIYrWtm/1FOwzPa0rMEGNhT09v2B?=
 =?us-ascii?Q?wl4FRBKG/dwcK0+vmqbATWMwbw4ASpuRiMUqwDjOqkRs3i7MG1XJX3KsGP2J?=
 =?us-ascii?Q?sxbMseNaRID+OzG3XwdITxjXt9sFw/69K8mFIkdG+0iiPo1+k8YhYWpv5dQa?=
 =?us-ascii?Q?kAiw6v8G+Z6DcB4akPn89fcIyWQ/B7AMU/qZFuaW/p9kAcAleMNANwIk3O/f?=
 =?us-ascii?Q?GrBQGdwive+nti6TvzefD8ybLMud0vJMOV+gpTpNcmwrIBi3LzxjGyQjxIWJ?=
 =?us-ascii?Q?yXv2LmBt6WjEgEc0fcF3k1rK+v0z7oCle9iw5r82mdTamFDgjrQQyarWbVd3?=
 =?us-ascii?Q?dzEY456j6CDWjgfKjgIAE31CKMuMmuZZl5IxVMPMhYD1Jh7b4lIBm90/tkkj?=
 =?us-ascii?Q?OiXLsd/0gtSCO8DPHU+UkDXnEexmDI6rM4Dpb3FmUNJxYlPV+2TqTmi/Cunv?=
 =?us-ascii?Q?/AsCMuaf99AgdDhIduCqymxJ6ZG2GoQBqDkMyiRcX8kyXbAKPNI9374XYfk1?=
 =?us-ascii?Q?MNfNbum/gs2MXhPVqDYe/eEqD0irPPJtlIke/3yu2kWgDtoEBtiIBSM7Y5b0?=
 =?us-ascii?Q?jD83zhPEN3nfhb7YFpAEkGsd4k/qrwfj6C4f/Gp5EdgZX6egKqH7L9/9L6UP?=
 =?us-ascii?Q?LHp9xhTVCNB0itmvq2nqLOp4SYVGeMbFadkYV7QhVM6KAFXr2aHfkvBRYev2?=
 =?us-ascii?Q?17L3LN4he86pFu2asjvO2PJ/PtCd+y0jYXBvjRtLY5YTj6xP3rHgQT305RA0?=
 =?us-ascii?Q?9hAXwMEtaSPss5H6ycvluTXeXCFP/XEI6SgWwv+0?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f80a807-d0eb-4603-ed35-08db08f8d03a
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 10:48:14.0866
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w0PIPvYghV+iWJGptBk4plnV4Tx95GQuB26yDtOcv6vg+5OLHiLVZQWFeTLeIU9Z8GIQCZXe6UfhYTO2153V5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6695
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Natalia Petrova
> Sent: Wednesday, February 1, 2023 2:36 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>
> Cc: lvc-project@linuxtesting.org; intel-wired-lan@lists.osuosl.org; Natal=
ia
> Petrova <n.petrova@fintech.ru>; linux-kernel@vger.kernel.org; Eric
> Dumazet <edumazet@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; netdev@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH v3] i40e: Add checking for null for
> nlmsg_find_attr()
>=20
> The result of nlmsg_find_attr() 'br_spec' is dereferenced in
> nla_for_each_nested(), but it can take NULL value in nla_find() function,
> which will result in an error.
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Fixes: 51616018dd1b ("i40e: Add support for getlink, setlink ndo ops")
> Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> v3: Fixed mailing list.
> v2: The remark about the error code by Simon Horman
> <simon.horman@corigine.com> was taken into account; return value -
> ENOENT was changed to -EINVAL.
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)