Message-ID: <115aca23-a47c-3a92-ae19-b4fa71412ca2@nxp.com>
Date:   Tue, 7 Feb 2023 13:21:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] ASoC: fsl_sai: fix getting version from VERID
To:     Shengjiu Wang <shengjiu.wang@nxp.com>, nicoleotsuka@gmail.com,
        Xiubo.Lee@gmail.com, festevam@gmail.com, shengjiu.wang@gmail.com,
        lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <1675760664-25193-1-git-send-email-shengjiu.wang@nxp.com>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <1675760664-25193-1-git-send-email-shengjiu.wang@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzB2VFQrVk9xYVRZMEZObWcyOThkQjdXR1VEa0xEclFNNUhzTGxUTG8zejlj?=
 =?utf-8?B?T0VkRkh3NVRZZURsNFBIaGNvN2UrTmQzdllxNDdUUEZTekF2UnB3SlJCMnl2?=
 =?utf-8?B?bHNDbE83QVVlZjFtaTQrMWh4YzhPSHBxVm1rME5sa084TXk5bzhOTXNJYTRt?=
 =?utf-8?B?MnBDNXBXNW55MFJGRWtpUERFcUl2YXUyckVEZnV0QXR2WGhhUS9abHRiMVFw?=
 =?utf-8?B?MUx6YmJpcjJRWWh0WXEwVFl5M0o3U1JmMUhUelBkY1pPSU5kQUpGZ2ZiNkF2?=
 =?utf-8?B?WldDOWhmOVorNGtGZHQwVFMzbkJHSE9sa1kzV2NkUzNJYmxNNGMyeTVvQVhJ?=
 =?utf-8?B?bmNLeDhrelZTSHZqUzhmQTVMUjZmRDhuaHliTkNHNVk4bTA1b1hEQ1d4Y0tF?=
 =?utf-8?B?aVYwZHI5c1JyZXhOekVNU1J0anlsTWtmakhrNWlkdnpwa3VIV1V4THVRY0xs?=
 =?utf-8?B?STc0WUJTaHRLQmZ2M3h0aHo0dStBZHo1enl4ZURjUWZUR0h3bDY4QU85ZS84?=
 =?utf-8?B?cUNPaUtVZEtaWm5keUprcjNGSUhuY2hWcE9jaWRGeDAzMWpaZE53TmtnVTNS?=
 =?utf-8?B?dmZ1VzhvUFRsNnQzUDdtdzNoZDNaVUlmSzlmS2tHVE8xZEIyalN3UHpSQ2N1?=
 =?utf-8?B?YlJ2RHpJMktPZkh3NWxUNTVUb3gvQXBFSjZQM3hMcE5CbDBFRVF3eDZ6SVFy?=
 =?utf-8?B?VU50NTdWdkEyT04rbUhPQXVOM255UTlhUjUyMlJRcmdENzV0UHNsSWVMcjRy?=
 =?utf-8?B?RHRoeVZaV2ZFc1d3OXQ1bGJaMkRScldXNkk2RTBtMVR0NHBkTVEwWUt0aFh4?=
 =?utf-8?B?dkpkNjh0WlQ2d3pjalExcER5RXcyNS9udXRDMk1rd3YyM3RoQW81a29sY1pP?=
 =?utf-8?B?V3FEaEk4ZWo0SElocVVjSUxQb1J4OGorOW51NDZBUjNNTFcrcTNNNndpbXRw?=
 =?utf-8?B?ZDFnRnRGWFBlWkMrZlFUam5HWHQ3eE5BYXBBNUVBT0NENmNtN1I1b0wzc2Rk?=
 =?utf-8?B?RG5Ua1B4bHVuTzJqaXlMRXRnaU9yWGZkeGhwL2U1d3ZPUjd3U3V6RGt0RFdZ?=
 =?utf-8?B?ejBMTHZCMHVrRG5RSld3Mk4rMFFpN1I2anpOeVg1elBzaWxqOHozcElObitZ?=
 =?utf-8?B?YnczWHFqZWRRMU1FS3luaEtkR2RQcjIyY29iL3JnL3RxRXhMQjlNamNMZ1Fl?=
 =?utf-8?B?Q0xmdExkMlEzS3pXRjV5UjJnaGsrZEhEdTZER0RKZWsyMTFqNUZjWEkvYm14?=
 =?utf-8?B?cWJwK25ES2R3R3FOMDVBd2w5VFFKU09XbkQ1VFBMWUhyUTM0Nk9iSWtndEVw?=
 =?utf-8?B?c2w2OEtEN0dhSDFGeS9ndzVVeXUwSStPWWVDaHlBRDYvUnR2SnpSOHduclRt?=
 =?utf-8?B?dHBPbERIVDNvaXJjTWg4djJCN2pYRFBNdzErQmdSNTBlNStjOTZ5Zi9hSTU1?=
 =?utf-8?B?YmhCOTh1Y2VHRlFKUlJObWdKTkJHKzJaZUsrUUowMnBFcDFINWwrWmtSZVBY?=
 =?utf-8?B?dkdpVjVxcy82bi91b21GeHRHdnpMVE1KZ1laYnlUZTJaaER2V0wwZVB4MEpr?=
 =?utf-8?B?ZWJJdGU1aGdyVFhTODVNWFZ4Sm5LYU1TM1dDeEIycm9GZ285TndKb3loS0tE?=
 =?utf-8?B?cituWjYzTGREQVFSS093WEVLeGFUeUVzalRqNldEdXlRVSsyNFlEZFMyS1Z0?=
 =?utf-8?B?RVc3RHdTaUl0REpheGZyNVpHUmkxVURtR3B5d3IxRGNHTmxWSzdpellJaEpv?=
 =?utf-8?B?SnovdmtUVXUrUlh1d2pkNDVyczNaTldDRWNiWXRTM1lIRE5rUndIWnF6OW9v?=
 =?utf-8?B?ZXNHZmdQYmE2bFJqLzk2eXl2OFpBY1RycVdSVTNaejE5MEl2TkRJczk2OUpJ?=
 =?utf-8?B?ZjRORlpzRkNmNlNiaEJmWHM3a1R0Ujh2MlpKZ2gwRmhZWGFxLzFBYWZIZVBH?=
 =?utf-8?B?ZDdtOGdnbm9QOU9oS2o3UXZINGJwNWdtQjh4aGNUZDJiajdOQ0ZySW1tQ2da?=
 =?utf-8?B?Nk9nd2UxU1V6VVdjMVNvcmZ3cEs2USt5UnhIUUFJQ3ZsakZDcjJaSkVGL1dR?=
 =?utf-8?B?UysyMjUveUNLMEk2OUdiRDIrK1ZLZFlSK2s2ZklBVHBmTlBXZUlYTGxINUlt?=
 =?utf-8?B?dFVUSmhxSTBScFpQQTJaQktCMUJQMnc5SWNqM1crY0s0OStRV1dOOUg1cEhy?=
 =?utf-8?B?a1E9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da656522-c7e8-4bc1-bdad-08db08fd85e8
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9628.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 11:21:57.1302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TfyqgjThoKfZbVB6zkedd7qzorjdGZGuRHXAl9UTvM5o+gs7kwdfC9XpbcWHq9dsi2A9CLi70sSAwV+BA8DYIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9434
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/7/2023 11:04 AM, Shengjiu Wang wrote:
> The version information is at the bit31 ~ bit16 in the VERID
> register, so need to right shift 16bit to get it, otherwise
> the result of comparison "sai->verid.version >= 0x0301" is
> wrong.
>
> Fixes: 99c1e74f25d4 ("ASoC: fsl_sai: store full version instead of major/minor")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>   sound/soc/fsl/fsl_sai.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index c365afd6c4ea..1b197478b3d9 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -1142,6 +1142,7 @@ static int fsl_sai_check_version(struct device *dev)
>   
>   	sai->verid.version = val &
>   		(FSL_SAI_VERID_MAJOR_MASK | FSL_SAI_VERID_MINOR_MASK);
> +	sai->verid.version >>= FSL_SAI_VERID_MINOR_SHIFT;
>   	sai->verid.feature = val & FSL_SAI_VERID_FEATURE_MASK;
>   
>   	ret = regmap_read(sai->regmap, FSL_SAI_PARAM, &val);


I would put the version in one line, but probably is easier to read this 
way.
Also, please explain, in commit message, what and from where is 0x0301 - 
might worth adding a macro for this, in another commit, of course.
Otherwise,

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>