Date:   Tue, 7 Feb 2023 13:25:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Arnd Bergmann <arnd@kernel.org>, linux-gpio@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] gpiolib: remove gpio_set_debounce
Message-ID: <Y+I1Orh74wR5Sese@smile.fi.intel.com>
References: <20230127101149.3475929-1-arnd@kernel.org>
 <20230127101149.3475929-5-arnd@kernel.org>
 <Y9n8P1rP+cYyoNIH@google.com>
 <Y9qwJtOaKrgB5n+T@smile.fi.intel.com>
 <Y9q4d50lSdPn8myb@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y9q4d50lSdPn8myb@google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Feb 01, 2023 at 11:07:35AM -0800, Dmitry Torokhov wrote:
> On Wed, Feb 01, 2023 at 08:32:06PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 31, 2023 at 09:44:31PM -0800, Dmitry Torokhov wrote:
> > > On Fri, Jan 27, 2023 at 11:11:46AM +0100, Arnd Bergmann wrote:

...

> > > > -	return !gpio_get_value(ts->gpio_pendown);
> > > > +	return !gpiod_get_value(ts->gpio_pendown);
> > > 
> > > No, we can not blindly do that without checking annotations on GPIOs.
> > 
> > But this is easy to fix, i.e. use raw API, no?
> 
> I'd rather not (I hope I can make this driver respect declared polarity
> at some point), so for debounce we could do:
> 
> 	gpiod_set_debounce(gpio_to_gpiod(), ...);
> 
> in ads7846 for now, and get rid of gpio_set_debounce() as a publc API.

This will work and we can keep it for a while (gpio_to_desc(), I believe you
meant this one, is part of the new API to keep this bridge for the cases like
this).

Arnd, are you going to send a v3? It would be really nice to have less
collisions next cycle if your series is applied.

-- 
With Best Regards,
Andy Shevchenko