Date:   Tue, 7 Feb 2023 11:29:41 +0000
From:   Will Deacon <will@kernel.org>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Liu Shixin <liushixin2@huawei.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Uladzislau Rezki <urezki@gmail.com>,
        Christoph Hellwig <hch@infradead.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for
 module_alloc() if CONFIG_RANDOMIZE_BASE is set
Message-ID: <20230207112940.GA12147@willie-the-truck>
References: <20221227092634.445212-1-liushixin2@huawei.com>
 <b93ec55c-f6f0-274a-e7d6-edb419b4be8a@huawei.com>
 <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org>
 <20230131150644.GA2605@willie-the-truck>
 <20230131150750.GB2605@willie-the-truck>
 <CAMj1kXGaxehOcrQqFZNA+C3dTk_H8sBr_1wsN3_KN82nXVaG_g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMj1kXGaxehOcrQqFZNA+C3dTk_H8sBr_1wsN3_KN82nXVaG_g@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Jan 31, 2023 at 05:03:32PM +0100, Ard Biesheuvel wrote:
> On Tue, 31 Jan 2023 at 16:07, Will Deacon <will@kernel.org> wrote:
> > On Tue, Jan 31, 2023 at 03:06:44PM +0000, Will Deacon wrote:
> > > On Sun, Jan 29, 2023 at 01:41:47PM -0800, Andrew Morton wrote:
> > > > On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin <liushixin2@huawei.com> wrote:
> > > > > On 2022/12/27 17:26, Liu Shixin wrote:
> > > > > > After I add a 10GB pmem device, I got the following error message when
> > > > > > insert module:
> > > > > >
> > > > > >  insmod: vmalloc error: size 16384, vm_struct allocation failed,
> > > > > >  mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0
> > > > > >
> > > > > > If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the
> > > > > > vmalloc region entirely. Although module_alloc() can fall back to a 2GB
> > > > > > window if ARM64_MODULE_PLTS is set, the module region is still easily
> > > > > > exhausted because the module region is located at bottom of vmalloc region
> > > > > > and the vmalloc region is allocated from bottom to top.
> > > > > >
> > > > > > Skip module region if not calling from module_alloc().
> > > > > >
> > > >
> > > > I'll assume this is for the arm tree.
> > > >
> > > > Acked-by: Andrew Morton <akpm@linux-foundation.org>
> > >
> > > This looks like the same issue previously reported at:
> > >
> > > https://lore.kernel.org/all/e6a804de-a5f7-c551-ffba-e09d04e438fc@hisilicon.com/
> > >
> > > where Ard had a few suggestions but, afaict, they didn't help.
> > >
> 
> Thanks for the cc.
> 
> So this is a bit clunky, and I wonder whether we wouldn't be better
> off just splitting the vmalloc region into two separate regions: one
> for the kernel and modules, and one for everything else. That way, we
> lose one bit of entropy in the randomized placement, but the default
> 48-bit VA space is vast anway, and even on 39-bit VA configs (such as
> Android), I seriously doubt that we come anywhere close to exhausting
> the vmalloc space today.

That sounds like a good idea to me.

Liu Shixin -- do you think you could have a go at implementing Ard's
suggestion instead?

Cheers,

Will