Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5130C636CC for ; Tue, 7 Feb 2023 12:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231685AbjBGMVY (ORCPT ); Tue, 7 Feb 2023 07:21:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbjBGMVX (ORCPT ); Tue, 7 Feb 2023 07:21:23 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09041EFA8 for ; Tue, 7 Feb 2023 04:21:21 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9F4021EC06C0; Tue, 7 Feb 2023 13:21:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1675772479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=5LWxEGrohFFdhKBL23ohMzv2EyTst8hduQlCMpvRp6s=; b=J9c5QYdbwgjioW71Jl+OKPXRUiEKuTEXEd+SGm6g3h6Kd4ZCyOhOiYVnGn6F/zP2CfFw2O fvzby235OJXhFo9Zv1biKZQ8dNmTXwdRrw1BPKTj/mwvJfJaoqpTWJ4qy7dAwsAP+SDTjD w7AwxG0qF2bNtfzEiI6VBneBZ+WRfD0= Date: Tue, 7 Feb 2023 13:21:15 +0100 From: Borislav Petkov To: Juergen Gross Cc: "Kani, Toshi" , linux-kernel@vger.kernel.org, x86@kernel.org, lists@nerdbynature.de, mikelley@microsoft.com, torvalds@linux-foundation.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: Re: [PATCH 5/6] x86/mm: only check uniform after calling mtrr_type_lookup() Message-ID: References: <20230207072902.5528-1-jgross@suse.com> <20230207072902.5528-6-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2023 at 12:54:53PM +0100, Juergen Gross wrote: > Fixed MTRRs are all below 1MB. So no, they can't cover a PMD. Good, belongs in the commit message. And we need more code staring like this to make sure nothing else breaks. As said, upsetting the universe is not easy. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette