Message-ID: <f5fd80ab32931e7367c3181635f40179536608b8.camel@redhat.com>
Subject: Re: [net-next PATCH V3 2/4] octeontx2-pf: qos send queues management
From:   Paolo Abeni <pabeni@redhat.com>
To:     Hariprasad Kelam <hkelam@marvell.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
        sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
        jerinj@marvell.com, sbhatta@marvell.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, saeedm@nvidia.com,
        richardcochran@gmail.com, tariqt@nvidia.com,
        linux-rdma@vger.kernel.org, maxtram95@gmail.com,
        naveenm@marvell.com, hariprasad.netdev@gmail.com
Date:   Tue, 07 Feb 2023 13:27:58 +0100
In-Reply-To: <20230206054640.5854-3-hkelam@marvell.com>
References: <20230206054640.5854-1-hkelam@marvell.com>
         <20230206054640.5854-3-hkelam@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-02-06 at 11:16 +0530, Hariprasad Kelam wrote:
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/d=
rivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> index 8a41ad8ca04f..f3ad4491ffb8 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> @@ -758,11 +758,16 @@ int otx2_txschq_stop(struct otx2_nic *pfvf)
>  void otx2_sqb_flush(struct otx2_nic *pfvf)
>  {
>  	int qidx, sqe_tail, sqe_head;
> +	struct otx2_snd_queue *sq;
>  	u64 incr, *ptr, val;
>  	int timeout =3D 1000;
> =20
>  	ptr =3D (u64 *)otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_STATUS);
> -	for (qidx =3D 0; qidx < pfvf->hw.tot_tx_queues; qidx++) {
> +	for (qidx =3D 0; qidx < otx2_get_total_tx_queues(pfvf);
> +	     qidx++) {

The above can and should fit a single line.

> @@ -189,7 +190,8 @@ struct otx2_hw {
>  	u16                     rx_queues;
>  	u16                     tx_queues;
>  	u16                     xdp_queues;
> -	u16                     tot_tx_queues;
> +	u16			tc_tx_queues;
> +	u16                     non_qos_queues; //tx_queues and xdp_tx_queues

Please, avoid c++ style comments. Use plain /* */ instead.

>  	u16			max_queues;
>  	u16			pool_cnt;
>  	u16			rqpool_cnt;

[...]

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c b/driver=
s/net/ethernet/marvell/octeontx2/nic/qos_sq.c
> new file mode 100644
> index 000000000000..13a8cc53eb19

[...]

> +static void otx2_qos_sq_free_sqbs(struct otx2_nic *pfvf, int qidx)
> +{
> +	struct otx2_qset *qset =3D &pfvf->qset;
> +	struct otx2_hw *hw =3D &pfvf->hw;
> +	struct otx2_snd_queue *sq;
> +	u64 iova, pa;
> +	int sqb;
> +
> +	sq =3D &qset->sq[qidx];
> +	if (!sq->sqb_ptrs)
> +		return;
> +	for (sqb =3D 0; sqb < sq->sqb_count; sqb++) {
> +		if (!sq->sqb_ptrs[sqb])
> +			continue;
> +		iova =3D sq->sqb_ptrs[sqb];
> +		pa =3D otx2_iova_to_phys(pfvf->iommu_domain, iova);
> +		dma_unmap_page_attrs(pfvf->dev, iova, hw->sqb_size,
> +				     DMA_FROM_DEVICE,
> +				     DMA_ATTR_SKIP_CPU_SYNC);
> +		put_page(virt_to_page(phys_to_virt(pa)));
> +	}
> +
> +	sq->sqb_count =3D 0;
> +
> +	sq =3D &qset->sq[qidx];
> +	qmem_free(pfvf->dev, sq->sqe);
> +	qmem_free(pfvf->dev, sq->tso_hdrs);
> +	kfree(sq->sg);
> +	kfree(sq->sqb_ptrs);
> +	qmem_free(pfvf->dev, sq->timestamps);
> +
> +	memset((void *)sq, 0, sizeof(*sq));
> +}
> +
> +/* send queue id */
> +static void otx2_qos_sqb_flush(struct otx2_nic *pfvf, int qidx)
> +{
> +	int sqe_tail, sqe_head;
> +	u64 incr, *ptr, val;
> +
> +	ptr =3D (u64 *)otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_STATUS);

This introduces a sparse warning:

drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:164:16: warning: cast r=
emoves address space '__iomem' of expression

...
	=09
> +	incr =3D (u64)qidx << 32;
> +	val =3D otx2_atomic64_add(incr, ptr);

... which means the above is likely broken on some arches.

Thanks,

Paolo