From:   Roberto Sassu <roberto.sassu@huawei.com>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        Christian Brauner <christian@brauner.io>,
        Seth Forshee <sforshee@kernel.org>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: RE: linux-next: build failure after merge of the integrity tree
Thread-Topic: linux-next: build failure after merge of the integrity tree
Thread-Index: AQHZOo5Tct5gClMYeE2iR8mZbs+mTq7DbyMw
Date:   Tue, 7 Feb 2023 12:48:19 +0000
Message-ID: <b02ea122f029407099950c5a0a8b935d@huawei.com>
References: <20230207115113.21efd917@canb.auug.org.au>
In-Reply-To: <20230207115113.21efd917@canb.auug.org.au>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Tuesday, February 7, 2023 1:51 AM
> Hi all,
> 
> After merging the integrity tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> security/integrity/ima/ima_main.c: In function 'ima_file_mprotect':
> security/integrity/ima/ima_main.c:473:34: error: implicit declaration of
> function 'file_mnt_user_ns'; did you mean 'get_user_ns'? [-Werror=implicit-
> function-declaration]
>   473 |         action |= ima_get_action(file_mnt_user_ns(vma->vm_file), inode,
>       |                                  ^~~~~~~~~~~~~~~~
>       |                                  get_user_ns
> security/integrity/ima/ima_main.c:473:34: error: passing argument 1 of
> 'ima_get_action' makes pointer from integer without a cast [-Werror=int-
> conversion]
>   473 |         action |= ima_get_action(file_mnt_user_ns(vma->vm_file), inode,
>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                                  |
>       |                                  int
> In file included from security/integrity/ima/ima_main.c:30:
> security/integrity/ima/ima.h:258:38: note: expected 'struct mnt_idmap *' but
> argument is of type 'int'
>   258 | int ima_get_action(struct mnt_idmap *idmap, struct inode *inode,
>       |                    ~~~~~~~~~~~~~~~~~~^~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   4958db3245fa ("ima: Introduce MMAP_CHECK_REQPROT hook")
> 
> interacting with commit
> 
>   39f60c1ccee7 ("fs: port xattr to mnt_idmap")
> 
> from the vfs-idmapping tree.
> 
> I have applied the following merge fix patch for today.

Hi Stephen

the fix looks ok for me.

Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>

Thanks

Roberto

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 7 Feb 2023 11:31:16 +1100
> Subject: [PATCH] fixup for "ima: Introduce MMAP_CHECK_REQPROT hook"
> 
> interacting with "fs: port xattr to mnt_idmap"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  security/integrity/ima/ima_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_main.c
> b/security/integrity/ima/ima_main.c
> index 7a05af9f481f..d66a0a36415e 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -470,7 +470,7 @@ int ima_file_mprotect(struct vm_area_struct *vma,
> unsigned long prot)
>  	action = ima_get_action(file_mnt_idmap(vma->vm_file), inode,
>  				current_cred(), secid, MAY_EXEC,
> MMAP_CHECK,
>  				&pcr, &template, NULL, NULL);
> -	action |= ima_get_action(file_mnt_user_ns(vma->vm_file), inode,
> +	action |= ima_get_action(file_mnt_idmap(vma->vm_file), inode,
>  				 current_cred(), secid, MAY_EXEC,
>  				 MMAP_CHECK_REQPROT, &pcr, &template,
> NULL,
>  				 NULL);
> --
> 2.35.1
> x
> --
> Cheers,
> Stephen Rothwell