Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361FBC636CD for ; Tue, 7 Feb 2023 14:07:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231528AbjBGOH6 (ORCPT ); Tue, 7 Feb 2023 09:07:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232363AbjBGOHj (ORCPT ); Tue, 7 Feb 2023 09:07:39 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92D481701 for ; Tue, 7 Feb 2023 06:06:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675778803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mJ8JQZnG+OjlrDJJhK5LXF+fnEiLqDMUtskISvma+18=; b=SA/KS42Mq6VcU6Kui97JUpP9l/WsvLnGDf7IDmmH1cOv/WpjLjueS6eQ9T8IdJxprt6YOF 9gAYYhLfmhGp0qax8g4fnvhTqSnafzuFq3zP4U5ZBcY3TdbgE8i+izZw0IcDlqRe8i2G06 /girXck4Tnhfrq8bb5fU+iwWUcHupj0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-474-jk5hakyWNLOpXo0vfUGfuw-1; Tue, 07 Feb 2023 09:06:37 -0500 X-MC-Unique: jk5hakyWNLOpXo0vfUGfuw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31BB5803D48; Tue, 7 Feb 2023 14:06:37 +0000 (UTC) Received: from T590 (ovpn-8-19.pek2.redhat.com [10.72.8.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 363E2492B21; Tue, 7 Feb 2023 14:06:32 +0000 (UTC) Date: Tue, 7 Feb 2023 22:06:27 +0800 From: Ming Lei To: Ziyang Zhang Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com Subject: Re: [PATCH RESEND 1/3] ublk: remove unnecessary NULL check in ublk_rq_has_data() Message-ID: References: <20230207070839.370817-1-ZiyangZhang@linux.alibaba.com> <20230207070839.370817-2-ZiyangZhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230207070839.370817-2-ZiyangZhang@linux.alibaba.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2023 at 03:08:37PM +0800, Ziyang Zhang wrote: > bio_has_data() allows a NULL bio so the NULL check in > ublk_rq_has_data() is unnecessary. > > Signed-off-by: Ziyang Zhang Reviewed-by: Ming Lei Thanks, Ming