Date:   Tue, 7 Feb 2023 06:19:45 -0800
From:   Bjorn Andersson <quic_bjorande@quicinc.com>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
CC:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
        "Subbaraman Narayanamurthy" <quic_subbaram@quicinc.com>,
        Johan Hovold <johan@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v4 4/4] power: supply: Introduce Qualcomm PMIC GLINK
 power supply
Message-ID: <20230207141945.GA1639831@hu-bjorande-lv.qualcomm.com>
References: <20230201041853.1934355-1-quic_bjorande@quicinc.com>
 <20230201041853.1934355-5-quic_bjorande@quicinc.com>
 <20230203112720.oa7e2psevbazicqo@mercury.elektranox.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230203112720.oa7e2psevbazicqo@mercury.elektranox.org>
Precedence: bulk

On Fri, Feb 03, 2023 at 12:27:20PM +0100, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Jan 31, 2023 at 08:18:53PM -0800, Bjorn Andersson wrote:
> ...
> > +static const enum power_supply_property sm8350_bat_props[] = {
> > +	POWER_SUPPLY_PROP_STATUS,
> > +	POWER_SUPPLY_PROP_HEALTH,
> > +	POWER_SUPPLY_PROP_PRESENT,
> > +	POWER_SUPPLY_PROP_CHARGE_TYPE,
> > +	POWER_SUPPLY_PROP_CAPACITY,
> > +	POWER_SUPPLY_PROP_VOLTAGE_OCV,
> > +	POWER_SUPPLY_PROP_VOLTAGE_NOW,
> > +	POWER_SUPPLY_PROP_VOLTAGE_MAX,
> > +	POWER_SUPPLY_PROP_CURRENT_NOW,
> > +	POWER_SUPPLY_PROP_TEMP,
> > +	POWER_SUPPLY_PROP_TECHNOLOGY,
> > +	POWER_SUPPLY_PROP_CHARGE_COUNTER,
> > +	POWER_SUPPLY_PROP_CYCLE_COUNT,
> > +	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
> > +	POWER_SUPPLY_PROP_CHARGE_FULL,
> 
> no CHARGE_NOW?
> 

This doesn't seem to be exposed by the firmware...

> > +	POWER_SUPPLY_PROP_MODEL_NAME,
> > +	POWER_SUPPLY_PROP_TIME_TO_FULL_AVG,
> > +	POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG,
> > +	POWER_SUPPLY_PROP_POWER_NOW,
> > +};
> 
> ...
> 
> > +static struct auxiliary_driver qcom_battmgr_driver = {
> > +	.name = "pmic_glink_power_supply",
> > +	.probe = qcom_battmgr_probe,
> > +	.id_table = qcom_battmgr_id_table,
> > +};
> > +
> > +static int __init qcom_battmgr_init(void)
> > +{
> > +	return auxiliary_driver_register(&qcom_battmgr_driver);
> > +}
> > +module_init(qcom_battmgr_init);
> > +
> > +static void __exit qcom_battmgr_exit(void)
> > +{
> > +	auxiliary_driver_unregister(&qcom_battmgr_driver);
> > +}
> > +module_exit(qcom_battmgr_exit);
> 
> module_auxiliary_driver()

Missed that we have one of those, will update and resend.

> 
> Otherwise LGTM.
> 
> -- Sebastian 


Thanks,
Bjorn