Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-156-g081acc5ed5-fm-20230206.001-g081acc5e
Mime-Version: 1.0
Message-Id: <1570009a-ca62-474d-b678-e6632b5b119e@app.fastmail.com>
In-Reply-To: <612947724da74327edb5e774de73d6d2a96d1648.1675734681.git.chenfeiyang@loongson.cn>
References: <cover.1675734681.git.chenfeiyang@loongson.cn>
 <612947724da74327edb5e774de73d6d2a96d1648.1675734681.git.chenfeiyang@loongson.cn>
Date:   Tue, 07 Feb 2023 15:25:50 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     chris.chenfeiyang@gmail.com, w@1wt.eu,
        "Paul E. McKenney" <paulmck@kernel.org>
Cc:     "Feiyang Chen" <chenfeiyang@loongson.cn>,
        "Huacai Chen" <chenhuacai@kernel.org>,
        "Jiaxun Yang" <jiaxun.yang@flygoat.com>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] nolibc: Add support for LoongArch
Content-Type: text/plain
Precedence: bulk

On Tue, Feb 7, 2023, at 03:09, chris.chenfeiyang@gmail.com wrote:
> From: Feiyang Chen <chenfeiyang@loongson.cn>
>
> Add support for LoongArch (32 and 64 bit) to nolibc.
>
> Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn>
> ---
> +
> +struct sys_stat_struct {
> +	unsigned long	st_dev;		/* Device.  */
> +	unsigned long	st_ino;		/* File serial number.  */
> +	unsigned int	st_mode;	/* File mode.  */
> +	unsigned int	st_nlink;	/* Link count.  */
> +	unsigned int	st_uid;		/* User ID of the file's owner.  */
> +	unsigned int	st_gid;		/* Group ID of the file's group. */
> +	unsigned long	st_rdev;	/* Device number, if device.  */
> +	unsigned long	__pad1;
> +	long		st_size;	/* Size of file, in bytes.  */
> +	int		st_blksize;	/* Optimal block size for I/O.  */
> +	int		__pad2;
> +	long		st_blocks;	/* Number 512-byte blocks allocated. */
> +	long		st_atime;	/* Time of last access.  */
> +	unsigned long	st_atime_nsec;
> +	long		st_mtime;	/* Time of last modification.  */
> +	unsigned long	st_mtime_nsec;
> +	long		st_ctime;	/* Time of last status change.  */
> +	unsigned long	st_ctime_nsec;
> +	unsigned int	__unused4;
> +	unsigned int	__unused5;
> +};

This definition should not be used after patch 1, I think you
should drop it.

      Arnd