From:   Zi Yan <ziy@nvidia.com>
To:     Huang Ying <ying.huang@intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Alistair Popple <apopple@nvidia.com>,
        Yang Shi <shy828301@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Oscar Salvador <osalvador@suse.de>,
        Matthew Wilcox <willy@infradead.org>,
        Bharata B Rao <bharata@amd.com>,
        haoxin <xhao@linux.alibaba.com>,
        Minchan Kim <minchan@kernel.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: Re: [PATCH -v4 9/9] migrate_pages: move THP/hugetlb migration support
 check to simplify code
Date:   Tue, 07 Feb 2023 09:53:02 -0500
Message-ID: <D5C828D9-2EE3-4E8C-B76A-5EF5684AAED3@nvidia.com>
In-Reply-To: <20230206063313.635011-10-ying.huang@intel.com>
References: <20230206063313.635011-1-ying.huang@intel.com>
 <20230206063313.635011-10-ying.huang@intel.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_62B9049D-6E74-49F4-B971-A942C71294A7_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7om21Mj9DbljBUpTagUmfSS1nBiQtSPGX0RVXC11t9dqpiidbc3gRumC2vU6?=
 =?us-ascii?Q?Jf8+QZ6lmjrkLCJ+Mu7160NRsHTUqNM3IRqGVOsZSMYnqpLy2OlaVPCWNsUO?=
 =?us-ascii?Q?EW0q+bgNMaXmnB3l//zhDQqvMBGoBbsELwQ93LNAPK1O2p+bB9jZCNkbNBtK?=
 =?us-ascii?Q?LOmjZ/50BNX/jw2LdaNh4jHLulJIYfYDfl+1w8YurwHF8CuPFPlEOnTOmKGo?=
 =?us-ascii?Q?o+hOFE/WrU9VoSY7rzLYwF29WvdgUK4+AiQIHFNJzWcvlq1ljqDKKNW6COx8?=
 =?us-ascii?Q?b5v+kJ+W7z60YAyOGpBWZdUUQmxAFTekRaefZJIqXAaLprpUBQH1G8tf3joR?=
 =?us-ascii?Q?eN7fBG28D7T8m0s1cGGSNIRkRza/RTTN9wi/qyAhSr6N6hLUWMdClzEigAeL?=
 =?us-ascii?Q?KigmfSJzCj4Hm4lLna2e0h0EPfCfD23z7oM2JHumCb5+rD2LUbAGr6kjrSOS?=
 =?us-ascii?Q?T25nRJLjWtfFiaYe+48rEuRofpxkDfV4jgZJp0mMyTo8abwhVqGwu4GUyHZd?=
 =?us-ascii?Q?ZSLu5sE3mAHEjQmNsdN2k7AD58OIm5P41xepO/LiZjGEzlRm6e2r71iqCbjg?=
 =?us-ascii?Q?ClwBQaOfc8s8B2+Qaok9XJ7ascy7uuo/ecuWGlhFMXHaRDVmdV/p8j5ygG/W?=
 =?us-ascii?Q?MmbQ91ZydmBzVb/dd7x+19JLpfDki4CcQKIxypERumzGdYkPrFBlyffcuwQ+?=
 =?us-ascii?Q?oWF1eBBb7o2zsS68R7EfsVBTLQwKBsLizpYxuQmTCYxh0JB+dqRvuuJDnGU3?=
 =?us-ascii?Q?4WCGaMe1gUW4XVjb6zoTwVymBvG+iugo77egLJSwyfRK5rCO3iSlGRuXbBOj?=
 =?us-ascii?Q?bTSm/ossTwV1nySZQKoI2HFZF7d23XRDS8eFujtC5k66AAL7v3JEaEuy23aZ?=
 =?us-ascii?Q?dqbpQxQ9zuTHDSQUUIW2lgf4Cy5SMj/qsuaKXR437JVVkorgpleCQtHHr+LG?=
 =?us-ascii?Q?d0obAq81k13diydXCaRuwexQ0WmbLCKyix9+VSrSaG8Pz89z4PhRh1YRfBVC?=
 =?us-ascii?Q?Bit9zpdTQ/WIFs59dS+zxfG5Amp5KjNeI8e3kK8QHOOkOegIsu0pcdMB0wcJ?=
 =?us-ascii?Q?C6IFWs7BQBTvXXjtOw0YG0cMLYPEN0mOknxp0bmdjaPsfCuNZoEbOJFWw1uj?=
 =?us-ascii?Q?JwO8Fs5de12zYf78pvHp0W1JPw3Um+CWhw7HqKO+VC/skb2brXyBcbuDKmAB?=
 =?us-ascii?Q?zFXEpdjY11BQunVRSLcsZBI3ZQYftm02i7gx5hKOs+nv4UfDjd7FYclypPYl?=
 =?us-ascii?Q?fDyoJ/uB1Rl+mft9XuIzgFs5O9LquyDBKByNlUtWGbYOAigTY52z4Z16s7af?=
 =?us-ascii?Q?DCMNFBPidkNMS+j5TOawR5/bmvxUrdJ9N1+5HtYw1/J7yTWXXHcIHL+/W1qr?=
 =?us-ascii?Q?bG7fla+DJB/BlbqeDE1PZJX49s12NQaSeEudKm121NMW11NQK5HgiEoKoWWP?=
 =?us-ascii?Q?YwIeGirr4OxHEAyZXcLdC3gf3qBkMcWr85I8tKtV+ypAK+7N9xf8MMrzREV9?=
 =?us-ascii?Q?+9e8gBEOXlFPtqfhzC9TUleIBc7h7p4/wQV6tEgsRQYgY4RTjeRn121Y+iR6?=
 =?us-ascii?Q?nEmkbRqAHRKeobNATDNY1rLCTd6fgKtsBviIsUZm?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9dd5f5a8-1f1d-49f9-27a6-08db091b04bb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 14:53:05.3072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zTvdCkx0bFnY1+hcKC40Lt08IYbJpVgabtKyo2ub7H/FQmYryhsq2L3h96oTioiT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7193
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_62B9049D-6E74-49F4-B971-A942C71294A7_=
Content-Type: text/plain

On 6 Feb 2023, at 1:33, Huang Ying wrote:

> This is a code cleanup patch, no functionality change is expected.
> After the change, the line number reduces especially in the long
> migrate_pages_batch().
>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Suggested-by: Alistair Popple <apopple@nvidia.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Yang Shi <shy828301@gmail.com>
> Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Bharata B Rao <bharata@amd.com>
> Cc: haoxin <xhao@linux.alibaba.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> ---
>  mm/migrate.c | 83 +++++++++++++++++++++++-----------------------------
>  1 file changed, 36 insertions(+), 47 deletions(-)
>
LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_62B9049D-6E74-49F4-B971-A942C71294A7_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmPiZc4PHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUglgQAJYPfrS9E4LuNeW+Q9DdqYvCJBngH38bSfBO
FE18dXhM8IxeXxv3cK4ClitRdxNuAuXLJQQxMwAQaJzt33gmMhF4RneazAh6VOu/
zgoGQTcsj+cW3gcLb70zSNr66FY9wStSBBRhXJlbUpe1y3vkpGidZJ+PGKB4Vp4u
2+65zLF7UL7YaKGWBYRiM5SqM+/khAf4lSwTwtHp/pjPGKWwC3YjJa0yCdcltLMc
/EBpevPifGksge0RrgsySXmnDAmBulr+mAtx+y7+nHb11hRp4nWAh1ong5V+33Ta
CGrtSvsYBfNQTcKwjKqzb6p4uCZyF6lxjqBlAbjvxzh1+Q2nVLy3Gm/tEecDjlZF
5Yn0G2QtdlIZc/ABDVyIp9GDkUhcBsR9Vo2n2WGUsLWoFwrzsrT1TYb09qPlfzYw
UpKSnvjLvSdTfsgKEgJdKLc8Dj7dBUJM8ZsYowpbuCugAlzIz5kih/W+5FBKllmo
CTI+vcdr9ZJwVJ7o7rDeG/Dq4p+NTqpOy19OYidrxth+FK0BMPZrPiEFRKJm3PMf
MC1kmM+6lAQbd3MNlZxVSkZiBKg+Dmry1EXgG5jtk8DdrYFqasOv0V3IrPXN0chq
qAW5n51Ep24nTM/8Z1gxZbEf5SY5Hv1OOD6cBBBbbjyK9aqjvBgVYdb5k1MICuXl
hWTj0n2i
=zgVC
-----END PGP SIGNATURE-----

--=_MailMate_62B9049D-6E74-49F4-B971-A942C71294A7_=--