Date:   Tue, 7 Feb 2023 10:55:48 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Alistair Popple <apopple@nvidia.com>, linux-mm@kvack.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        jhubbard@nvidia.com, tjmercier@google.com, hannes@cmpxchg.org,
        surenb@google.com, mkoutny@suse.com, daniel@ffwll.ch,
        "Daniel P . Berrange" <berrange@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org
Subject: Re: [PATCH 09/19] io_uring: convert to use vm_account
Message-ID: <Y+JmdMJhPEGN0Zw+@nvidia.com>
References: <cover.c238416f0e82377b449846dbb2459ae9d7030c8e.1675669136.git-series.apopple@nvidia.com>
 <44e6ead48bc53789191b22b0e140aeb82459e75f.1675669136.git-series.apopple@nvidia.com>
 <52d41a7e-1407-e74f-9206-6dd583b7b6b5@kernel.dk>
 <87k00unusm.fsf@nvidia.com>
 <eff3cc48-7279-2fbf-fdbd-f35eff2124d0@kernel.dk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eff3cc48-7279-2fbf-fdbd-f35eff2124d0@kernel.dk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v8+dojwfK3vQbmyoSC7XFNlANfA4r3Ey7nd5lnjTKv/4Cg1yhMJLicp3IeQc?=
 =?us-ascii?Q?AA2CEjDQiiWkwyZf+0B2T0LdXoM0zHnD9Ac3Fj+vg5a4q3zOsfpabpG0NP0V?=
 =?us-ascii?Q?yKsf0a/m2qsg/U2n+IWsdbZZKDqiMzSewJpEBxyCe+0LO3ZG3LwqdFS57+v8?=
 =?us-ascii?Q?v0VU1C8iEf00x3vSBJx/t3jQtGcMRq7VEdJKxoR7qzsl1Iml14t1UO2bsDDb?=
 =?us-ascii?Q?Kdfw6ZR2WZSF9euxwdOFbPMerAEEdr4i/YS3mVJ07OewdoQ8PBKEqJPb8QZd?=
 =?us-ascii?Q?PzMomKvGNd7apTQVNPdPmlLIHai4YnvVe13DqEFpQ06KEr75+BXdRtDw3wWJ?=
 =?us-ascii?Q?0eHDCe/irRhzKqRBkkVcV+gKpk/MVjqvCc6aXVrB9RXnnuDme2Xy/S8JBr56?=
 =?us-ascii?Q?hT1a6ul5vIPqrwVeFyCgCFLtMLTF0nhL8oqarzBZUf4kHvOtR1a13SI5wcsN?=
 =?us-ascii?Q?9tGW9y9w8MFdRpul64evwjBGSFKxPor7YMTDE8gv5U1UJrAIdRBXYrCmrNvz?=
 =?us-ascii?Q?QBhLN2n4xFEkIboCuGBS7NtuB4wVkQqnqjhdPlfGtYxbq95Zh4he1CfQWCFn?=
 =?us-ascii?Q?2qiQKHMSdWk3bRZYKYMLn4yV5FgCu1jGQ+Qk/IyUnCpNJvdsX7oU+rWDVMTT?=
 =?us-ascii?Q?b5ZwOE6nv+EUbbHkX5cILetyyLrBHRBDeS0K7nJfgrOwE+4f/NYc4GeWseSS?=
 =?us-ascii?Q?2gy6DqcQci0PkKE043MjlmuAWHfm3ICaJdT5mrWj8bBWH2iRG3PTddM9JToS?=
 =?us-ascii?Q?lTgAMN+lfqypMqzYyUw0kiLGTGY2VKSv7Hi1pYuCAlkgouGpgeoKSsR9VaaS?=
 =?us-ascii?Q?ThqgOjmIRg1FrH4NwC18RnfMBK+t49BUYT5vX7p+J012Ruqnxcfq4820IGyh?=
 =?us-ascii?Q?D3BkmDg6eTvKfuR3UsHF7tYpTiOOSF8o15PO0cCJEkkmrpF7IuboX5f+j50l?=
 =?us-ascii?Q?SsqbTpITwl7gyGJeksPzPDZVMX38VsWTCWvD2X4qwQ0TVVoqUqfLWU07OpR0?=
 =?us-ascii?Q?R9nc07H7hAEYI5O91st2ryzkpBMAwGSO6ncT2zJJRVWZOTamnJXdxIP8wNqF?=
 =?us-ascii?Q?/rXU46h2vOGxxJSDNxh6oB8iG5pzR5E+u5AOoZZwCf1R885UQQjbaZ+hsjoB?=
 =?us-ascii?Q?df9nrgcAiyt2RtXgd5ZF0qiFzrNCxYKXQjfALgzqZ0uB91hhjnV4+i0fjPAI?=
 =?us-ascii?Q?zYxGEy8HF8+N7Rahd2yHjEMOdGLoENluqY44y4M/99n8g/l5pNDsbax32kZt?=
 =?us-ascii?Q?IHjMUOKJlRzdYIOcxhp5D8e4As4wWFAFuU3tnsAzAye/g8xHZLivgQxLUNVn?=
 =?us-ascii?Q?LN1GQqqVXTopUhj9bmwwIBVlwiVkINBCedj030O17+PCQ+M0HsLVa5vy6W7R?=
 =?us-ascii?Q?7DGiBGIq9v3jqvV9OO5uDfyZnkNkbmocaS9UIhH4FByT7aCQ6TSQSikoiWOM?=
 =?us-ascii?Q?shOGQepexalrPDf9/SKXR3sb/mxgiZo1zsJAv/3X+LFmIjhoe9LaExFEh7+I?=
 =?us-ascii?Q?g31BHkqOefiSlNAubKSWBg8arHXRNzmC3ODZGPSfqBgn+6WtPH2XyzOMIxOZ?=
 =?us-ascii?Q?YKHwikn+IIfCemO2eAUGWPp3k+bBPfn08O7/Qe4E?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c310ee7b-eef7-4953-1536-08db091b665d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 14:55:49.1075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ieEMflrR2+0Mxi7ReO5EKqlJ9irYdqDNketM6XqDgr8Rq41/HjYbd1VXx547D2c6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7874
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 07, 2023 at 07:28:56AM -0700, Jens Axboe wrote:

> Outside of that, we're now doubling the amount of memory associated with
> tracking this. That isn't necessarily a showstopper, but it is not
> ideal. I didn't take a look at the other conversions (again, because
> they were not sent to me), but seems like the task_struct and flags
> could just be passed in as they may very well be known to many/most
> callers?

For places doing the mm accounting type it cannot use the task struct
as the underlying mm can be replaced and keep the task, IIRC.

We just had a bug in VFIO related to this..

If we could go back from the mm to the task (even a from a destroyed
mm though) that might work to reduce storage?

Jason