Message-ID: <3a43ce55-ff6a-0cd2-b020-d5fefe8aca0a@collabora.com>
Date:   Tue, 7 Feb 2023 16:17:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3
Content-Language: en-US
To:     Matthias Brugger <matthias.bgg@gmail.com>,
        Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org
Cc:     Frank Wunderlich <frank-w@public-files.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20230205174833.107050-1-linux@fw-web.de>
 <8f04f2b5-320e-50d4-9517-6dac989f63b3@gmail.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <8f04f2b5-320e-50d4-9517-6dac989f63b3@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Il 06/02/23 21:20, Matthias Brugger ha scritto:
> 
> 
> On 05/02/2023 18:48, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Leds for Wifi are low-active, so add property to devicetree.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts 
>> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> index 33bd6febc160..2b028141f1f7 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> @@ -446,5 +446,9 @@ &wifi {
>>       pinctrl-names = "default", "dbdc";
>>       pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
>>       pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
>> +
>> +    led {
>> +        led-active-low;
>> +    };
> 
> The binding is missing this property also the driver implements it. Could you 
> please update the bindind description properly?
> Thanks
> Matthias


After and only after [1] is picked,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

[1]: 
https://patchwork.kernel.org/project/linux-mediatek/patch/20230207133504.21826-1-linux@fw-web.de/