Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B41EC636CD for ; Tue, 7 Feb 2023 15:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232433AbjBGPeV (ORCPT ); Tue, 7 Feb 2023 10:34:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232045AbjBGPeT (ORCPT ); Tue, 7 Feb 2023 10:34:19 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D4D430EB3 for ; Tue, 7 Feb 2023 07:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675784057; x=1707320057; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=42w1wIYF683VoCz886YPm1YRwgV+fo0rImnP0BLPJIs=; b=SxWsh9F90V+qiIH2o1mKn/Z/483ZIUwdSgO55kWY/2Nl5AP4XZmzua5l kCAtg/XOxizJENmFQiKHDjh2il5tucOUP3i/EvEX6VaUY4rJZbdcbiDel aOrDUp0WdNZsOMG5evRsdMitp9bE8r1ETmkRESHERX+SYAnWuyhduc8oM 36kc92QhTtpSh/HWmZ4oqi6wQveSm7mEkq5zhoS/z+o1TJ1HX9e0atKpO m5GWx5zEsARvLtiG8tJVoMAMalMQsnTxPKRke80FjYdlPU/2M5MC0CEiF 6ucfAD5cEwhj1ufYBnLu9FfyR0lfHdD28hybo7133ribQ5dRinRmsIm7a A==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="327225045" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="327225045" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 07:33:58 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="912370499" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="912370499" Received: from rwalujo-mobl.amr.corp.intel.com (HELO [10.212.133.200]) ([10.212.133.200]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 07:33:57 -0800 Message-ID: <9fb39b3a-2edb-7fd3-2b7c-3a347478083f@intel.com> Date: Tue, 7 Feb 2023 07:33:56 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] x86/kprobes: Fix 1 byte conditional jump target Content-Language: en-US To: "Masami Hiramatsu (Google)" Cc: Nadav Amit , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , X86 ML , kernel list , Peter Zijlstra References: <20230204210807.3930-1-namit@vmware.com> <20230207095424.42f4c0147f693a8cef25757c@kernel.org> <20230208002132.63b70cb9d6e5badad45fb828@kernel.org> From: Dave Hansen In-Reply-To: <20230208002132.63b70cb9d6e5badad45fb828@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/7/23 07:21, Masami Hiramatsu (Google) wrote: >> Nadav, can you update your patch to assign immediate.value directly? > BTW, there are many similar casts around there. I'll fix those too. > If we need to be more conservative, Let's focus on fixing the known bug first, please. Cleanups can come later.