Date:   Tue, 7 Feb 2023 08:19:03 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Sumit Garg <sumit.garg@linaro.org>, Ira Weiny <ira.weiny@intel.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Christoph Hellwig <hch@lst.de>, <linux-kernel@vger.kernel.org>,
        <op-tee@lists.trustedfirmware.org>, <linux-mm@kvack.org>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v2 0/4] Remove get_kernel_pages()
Message-ID: <63e279f730612_104ce22946f@iweiny-mobl.notmuch>
References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com>
 <CAFA6WYM5tzs3T1tDgspA=R=VxfWrknm2YPHMCZihx405pF-ftA@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAFA6WYM5tzs3T1tDgspA=R=VxfWrknm2YPHMCZihx405pF-ftA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X6CR6K6IChj/JjSIqe4+M+T2MUWESCOvvK3fB1lrafbjSHcrD3ijxlGchHsU?=
 =?us-ascii?Q?qdEIJEs4L0uBf5Nfh09w8Babq5ErBDv4fbZ3y1/z5kLJ8LmKOSEh1EJORezG?=
 =?us-ascii?Q?etcBDpBOqyv6gqT7T6IuyTIS/1F6eHdyXmxx4NZWOPT51kby3K/UKih9aaiL?=
 =?us-ascii?Q?2UONkPIImoVJ5dLbKBeh5sjcH92ptwB1MoWv/ipLdYF+n955D8Eshe53yTxG?=
 =?us-ascii?Q?e0d456f8EGKF5rf2trR5xASUN+5f5PWGEqpvHQJEbPJ6U+2sggK2bdDWW0WY?=
 =?us-ascii?Q?ORA0AVhi7lX2VV+midLlfOQ+kTdgP0CJsRZ7R6Jw5EYvdexLd55I9A/343lY?=
 =?us-ascii?Q?XnEP32/1m3tOO+xin5fdB3EsznzfGDlp87V7wmBy4dPMXlx/u/UQwZG75gg7?=
 =?us-ascii?Q?G+G0RtdYnex5xIu0OiPu8xyx/5OrBZDqQME2x/gw9H4t5RFht3C/15e/UR71?=
 =?us-ascii?Q?SvoVBRdeipYvJBY6nNT3w4apwd0ef5dx9WCYj2HCbPJachTckUzYSU3i2/Es?=
 =?us-ascii?Q?E7Vj+xQ1hM5KY+J0MMYxUj1IPOA/ycQzkU7SGZ1t5heHlJJK+0d7khvI5w0I?=
 =?us-ascii?Q?1GyP/UpL7hHK3t5c6AEABndCw0rzl795bBm0jKGrETmUnFuwtjM8hYtI+ynH?=
 =?us-ascii?Q?YiKDEJYyn2DM7Jpp9V/VEWx/k3yc+YLgxOB0zrcNfOcWUgUU8Vdf5df7IfI6?=
 =?us-ascii?Q?NkQGxDg5oE7Y/O2A8yRmDd0dW/VZP8dki1/omBD21fChmVGK3NUTSlBNGoFB?=
 =?us-ascii?Q?KopFYmAwQPo1Tmw0EaEXqupuUwQFC3Dz8nlmIq4rNVADFAUAyORkI+1yxsVz?=
 =?us-ascii?Q?wiP3R68VmOQUQwHSFUqRoyBsGqzDn6VPLatGR4+3gJ16ebHS46ab34ys6vES?=
 =?us-ascii?Q?KF3HQ6WSs4R5MyE3WCI90Zr17OZIRaqZ0fpf64KrepJc9B1uVjsJKk/X7Wwi?=
 =?us-ascii?Q?9SFx6gWcrPm2u5FLaiKiYbThQcmIa2EjNIMpYbf4jugzPp0F/Ret+Wl3daFB?=
 =?us-ascii?Q?hGgZceiooPf9CchSj3WC3eBb9TDAXB++gcDx9Ae64Ophp8jNj30fM0dXqj9B?=
 =?us-ascii?Q?wbw4+6OLeaKi6dKWjEgZfzrnw/RuXzMtnMhfD6PANn5wC3OkDhj+CFYYNzDQ?=
 =?us-ascii?Q?ZDIg5kvuc/G0yAF95hfbZ9FBE9h7AuHe4RvgECMM0RujG8HvgIxanvQp4kEH?=
 =?us-ascii?Q?YuAe5QN/D0PIMl1mgkL1L4o9lckiv5yNU1ygkLk5v6MrxjgMOvIm/J4JcvsJ?=
 =?us-ascii?Q?nmeT/wmpE5yXqd1s1PV213rgQvs9OJ2wzaJnd02o2gfo/tTbmxP6zsI0a8MX?=
 =?us-ascii?Q?JaKeBK8Nm64o3sHFgt17ttF5ChooRBUSoAXdfqVMlWmvMP8dEEUckFgmmZlO?=
 =?us-ascii?Q?KOYWp1o+OqE9iPBnaix9r3A5Mckl99xrDyCikn/xKrd6Xb15A0WC/O1j+DuC?=
 =?us-ascii?Q?Z0I59PUZWX2inY/uFEFyi3Fa7KxD3VXElpJq3bw9FX0cELX9jAhJE2T3wJO3?=
 =?us-ascii?Q?MHzIKDlHWbqU7Ratanaw0L/11+0Uk64OtWNzLU007NnbBnr0ZDJFdV47lbaM?=
 =?us-ascii?Q?snXx01TIcDqfHmMqPa5N1aVPwrXcEFxoRTO3irTt5JVl+YVgYJe7NQjuYz49?=
 =?us-ascii?Q?Aw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 26e06d0e-9652-4ac5-1bad-08db0927096c
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 16:19:07.1854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PvzsbP8DHCbPxljn8gIa21wiepLRWcLobawOed3AyM7QeZGLwAsVRKKv/RY3Fp0ktalSONXKGdJU7OGa7MKURg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5218
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sumit Garg wrote:
> On Sat, 4 Feb 2023 at 09:36, Ira Weiny <ira.weiny@intel.com> wrote:
> >
> > Sumit,
> >
> > I did not see a follow up on this series per your last email.[1]  I'd like to
> > move forward with getting rid of kmap_to_page().  So Hopefully this can land
> > and you can build on this rather than the other way around?
> 
> Apologies Ira for keeping you waiting. Actually I was fully involved
> with other high priority work with my upstream review backlog
> increasing. So I wasn't able to devote time to this work. Sure I will
> rebase my work on top of your changes.

No problem on my end.  I just wanted to ensure that I did not miss
something.

Thanks for the reviews!
Ira

> 
> -Sumit
> 
> >
> > All,
> >
> > Al Viro found[2] that kmap_to_page() is broken.  But not only is it broken, it
> > presents confusion over how highmem should be used because kmap() and friends
> > should not be used for 'long term' mappings.
> >
> > get_kernel_pages() is a caller of kmap_to_page().  It only has one caller
> > [shm_get_kernel_pages()] which does not need the functionality.
> >
> > Alter shm_get_kernel_pages() to no longer call get_kernel_pages() and remove
> > get_kernel_pages().  Along the way it was noted that shm_get_kernel_pages()
> > does not have any need to support vmalloc'ed addresses either.  Remove that
> > functionality to clean up the logic.
> >
> > This series also fixes is_kmap_addr() and uses it to ensure no kmap addresses
> > slip in later.
> >
> > [1] https://lore.kernel.org/all/CAFA6WYMqEVDVW-ifoh-V9ni1zntYdes8adQKf2XXAUpqdaW53w@mail.gmail.com/
> > [2] https://lore.kernel.org/lkml/YzSSl1ItVlARDvG3@ZenIV
> >
> > To: Sumit Garg <sumit.garg@linaro.org>
> > To: Andrew Morton <akpm@linux-foundation.org>
> > Cc: "Al Viro" <viro@zeniv.linux.org.uk>
> > Cc: "Christoph Hellwig" <hch@lst.de>
> > Cc: linux-kernel@vger.kernel.org
> > Cc: op-tee@lists.trustedfirmware.org
> > Cc: linux-mm@kvack.org
> > Cc: Jens Wiklander <jens.wiklander@linaro.org>
> > Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> >
> > ---
> > Changes in v2:
> > - Al Viro: Avoid allocating the kiov.
> > - Sumit: Update cover letter to clarify the motivation behind removing
> >   get_kernel_pages()
> > - Link to v1: https://lore.kernel.org/r/20221002002326.946620-1-ira.weiny@intel.com
> >
> > ---
> > Ira Weiny (4):
> >       highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings
> >       tee: Remove vmalloc page support
> >       tee: Remove call to get_kernel_pages()
> >       mm: Remove get_kernel_pages()
> >
> >  drivers/tee/tee_shm.c            | 37 ++++++++++---------------------------
> >  include/linux/highmem-internal.h |  5 ++++-
> >  include/linux/mm.h               |  2 --
> >  mm/swap.c                        | 30 ------------------------------
> >  4 files changed, 14 insertions(+), 60 deletions(-)
> > ---
> > base-commit: 0136d86b78522bbd5755f8194c97a987f0586ba5
> > change-id: 20230203-get_kernel_pages-199342cfba79
> >
> > Best regards,
> > --
> > Ira Weiny <ira.weiny@intel.com>