Message-ID: <acb79609-ca85-dab4-c4f8-6f37ec279d13@siemens.com>
Date:   Tue, 7 Feb 2023 17:32:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] scripts/gdb: fix 'lx-current' for x86
Content-Language: en-US
To:     Jeff Xie <xiehuan09@gmail.com>, kbingham@kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org
References: <20230204090139.1789264-1-xiehuan09@gmail.com>
 <CAEr6+EA7L68kGPW43YwDOhpBVMQhJ0WNbMEreNFpz=8Q=C_S+A@mail.gmail.com>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <CAEr6+EA7L68kGPW43YwDOhpBVMQhJ0WNbMEreNFpz=8Q=C_S+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHlBUGdNS2xIbXU1SWtsUEU5YU5meXRudWZGSUZMeDE1bGhoMFp0MmxnUEox?=
 =?utf-8?B?YlBvVVZyeHA5T0VxTzZCVWU3aGJEdFRlb2F5TEw3aVhSMVVJeEtiRWtUeVh5?=
 =?utf-8?B?RUlSODVqNmJsR3dOclVMY29jNUs4V2xxZFpaQWZ3T2ZhRTlxaHZrSXZrZEJK?=
 =?utf-8?B?Qjk5UjVMdHFCRDlyMkwxSk9HQXJRcVVjMUVXK1RmckpOTFdXOUNkRWtlWnN0?=
 =?utf-8?B?M1M1NG5KWDJ5RVhsUlJHVW1pRFNuMDB1ZTdwdkY4Z1F4VjZRaEg3V2tKaFhE?=
 =?utf-8?B?aVRPVzVOb1BLcUJqWjZSNGFHVEpQNS9FZGVsMDZnWENIWDlrSFB1U2FYUEhj?=
 =?utf-8?B?M0V5WmhQOE9lclg3bXRGbE1neVdVc3RoRCtNaldYc1RGMTg1NGdETDdwVVM2?=
 =?utf-8?B?czB4VkpDWW0xalh2dUtOTS9pRWZjWm95bjlqVEd5SkZveVJzYUU1WHptVEpx?=
 =?utf-8?B?NDdwOHY1emhJeFp6alVNZlJ2Y1R4dUZEcXBVRHR4V3VkaHY1WnBnRlA4bUMv?=
 =?utf-8?B?ZTZTM2RXUGZOdVdsWE5kV1FacTJqZm9wZlNtOUdkQmtWTG8zekJNQmVJTlFa?=
 =?utf-8?B?ODlWYW5GaTkyTGZHZ20xOS9BK3N5WTJwOFpiVzJFcExOUlU0UXkvUXlmVUZS?=
 =?utf-8?B?RTFiZTZscXBnYzBPZi9vK0VxTTlpM1Urc21DSDR5L0tHZHJDWVN3bHhQWXlm?=
 =?utf-8?B?dXhkMDh0Njc3cE1rbTF1a1BGL0hFU3FMM3NQTjdKUzJZZmlYN05IL0NNMlBW?=
 =?utf-8?B?NFJyNGprR3Z6WERHTEdmWUljc2NNUDh0ajlYcWRxM0lLbEU3eUhxNjJTTnZE?=
 =?utf-8?B?ajZpMVp2ZFdrUzBOcDRnL1M4dEhUa1p2UVNpTVhXWmFkRXRTSlBUR1Z2ZGRm?=
 =?utf-8?B?N3BmeGRMMHA0SlpVeXAxZVBVb1FvODJHWHJrVFladUNyL0pQY0x1dGNBS00z?=
 =?utf-8?B?cDRBVGhaRk5Gb2h6Y3ZheXFoQytDVCtVV2tWT2FFT21zQ1FhejJ5dDhzMUMw?=
 =?utf-8?B?Y3l4MlFRdk4rSGVtMldIeVhyazF0SllkYllmU1VmaTV5RjZtays0UFZ2dHdy?=
 =?utf-8?B?Ry9WTWtCVHh4bnkzNmcwdFlXSHl3Z0ZjdmZ0NXllUlRkNGExMzVrenRSd0xq?=
 =?utf-8?B?RllZSEZKNHFMaU4yaHhWczcrNlFwNUNrOURmUGdrK2EzSUw4cTZZQWZ4UVl3?=
 =?utf-8?B?SFJ0U1pVZ2Ftc2EwWVg3L3ZkeXNuQXlRNHNGY21ja2h1RkJUYW5KSFhndWdG?=
 =?utf-8?B?TitZZU8vTnkycXIwTEllbUlCQ3Q2MHQ5cFNKQ29EK2duMWFvclpKZHpmWm5X?=
 =?utf-8?B?ZlBYNTRJVGVPT0ZzVDF0T3pEMXI4YVBpQzNtdWFhMDZoUUdHWGhmajNrRW15?=
 =?utf-8?B?NkR2VHJpbTdGT3lkNDVyZUlXSEIxbktVM2VPYU40aHQ0ak5NaW4yTHU0M3ZN?=
 =?utf-8?B?QUJVMjcxekxadmhWQ2hjVmFDRU41eU1IWFplTFhoMHNCamVJN2FsdCtyc25E?=
 =?utf-8?B?aXdSK0ZHelp2Q056SEx3KzVaeWdvT2gxcDZndzRTRUJJOFhtdm9BN0lnTHd1?=
 =?utf-8?B?dHlpenJTVzkyVldHQXBxZit2bzEzY0pVK3ZnazVLRWhaSy9HeDZXTGNTSkdk?=
 =?utf-8?B?bjVSUEdJOUxWTW9rWVVxN2VPU205aFRTTEtwL0NwYWhqVkwwSGhmdnFMYWhM?=
 =?utf-8?B?N1Nwd2cyMXliNzVab2hrWEFoMzlBVjYrOXdZa0YvS0E0RUVhNVRXbUltTGdy?=
 =?utf-8?B?bkpBTnVvZDdMSjdNZVhKOGIzMWhUbDJaSzAzdVFZT1JlVXRrKy8yTHFOQXBi?=
 =?utf-8?B?Ym05ZnNCaEpqb3FPcFBpVDRMY3QveDljZmN4bjdwci9RTFlzZnAyd1lPN200?=
 =?utf-8?B?dTJYM0dVSEtTZWFIOVhPUWpseitqYWVMZXE0YWN4REtvZjE1Qm9OWFVaRDFV?=
 =?utf-8?B?YXd2c0RlRHhxaXVhaDFtWHkzYTdtNXBtRHVFSjdnenZoRlJ2ZTBBQlJTVFBk?=
 =?utf-8?B?cGIzaTJlc3VkYnk2azd2Z3VYaTVpdkVyNW5zYWtWdytMcHd6Qm1ZVnVzTVZm?=
 =?utf-8?B?TFh0dmduN0tCUDRUeWtnbGdFR211cTVHWnpINE1laG8rVCs0ZzRqU0g1Q1Nt?=
 =?utf-8?B?dklWS3BnYUFaUGM1NGRTMi92WmdITlEwaGNyRVd2WC9OcEdqbEhFcGxsSWlu?=
 =?utf-8?B?aGc9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84c00673-54d0-46eb-e7c7-08db0928ee20
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 16:32:40.4501
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ywPn8hhXDWBW8y5sTIjpuYOAr9lo+QiiPZ0tPo17+TTnGA0WU27xV0QwR1godBKpOqZ9WbPA2kd3CHm7lhGs8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7203
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07.02.23 16:48, Jeff Xie wrote:
> Andrew was added.
> 
> Hi Andrew,
> 
> I found the patches for the ./scripts/gdb/*  were merged by you before,
> but the "./scripts/get_maintainer.pl ./scripts/gdb/linux/cpus.py"
> can't find your name,  so added you.
> 

Yes, Andrew is merging scripts/gdb stuff.

> Can you review this patch ;-)
> 
> On Sat, Feb 4, 2023 at 5:02 PM Jeff Xie <xiehuan09@gmail.com> wrote:
>>
>> When printing the name of the current process, it will report an error:
>> (gdb) p $lx_current().comm
>> Python Exception <class 'gdb.error'> No symbol "current_task" in current context.:
>> Error occurred in Python: No symbol "current_task" in current context.
>>
>> Because the commit <e57ef2ed97c1> ("x86: Put hot per CPU variables into a struct")
>> changed it.
>>
>> Signed-off-by: Jeff Xie <xiehuan09@gmail.com>
>> ---
>>  scripts/gdb/linux/cpus.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/cpus.py b/scripts/gdb/linux/cpus.py
>> index 15fc4626d236..9ee99f9fae8d 100644
>> --- a/scripts/gdb/linux/cpus.py
>> +++ b/scripts/gdb/linux/cpus.py
>> @@ -163,7 +163,7 @@ def get_current_task(cpu):
>>      task_ptr_type = task_type.get_type().pointer()
>>
>>      if utils.is_target_arch("x86"):
>> -         var_ptr = gdb.parse_and_eval("&current_task")
>> +         var_ptr = gdb.parse_and_eval("&pcpu_hot.current_task")
>>           return per_cpu(var_ptr, cpu).dereference()
>>      elif utils.is_target_arch("aarch64"):
>>           current_task_addr = gdb.parse_and_eval("$SP_EL0")
>> --
>> 2.25.1
>>
> 

FWIW:

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Should go into 6.2 if possible.

Thanks
Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux