MIME-Version: 1.0
References: <9698eff1-9680-4f0a-94de-590eaa923e94@app.fastmail.com>
 <Y+J5ev/R/Sz6nwBF@hirez.programming.kicks-ass.net> <20230207174227.rimpkz3b3y7m4fch@treble>
In-Reply-To: <20230207174227.rimpkz3b3y7m4fch@treble>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 7 Feb 2023 09:50:16 -0800
Message-ID: <CAKwvOdnd2X+m9YhOqXbw912BW2vP-RtFusch3_fughriqvruaw@mail.gmail.com>
Subject: Re: current objtool warnings from randconfig builds
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        Josh Poimboeuf <jpoimboe@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Feb 7, 2023 at 9:42 AM Josh Poimboeuf <jpoimboe@kernel.org> wrote:
>
> On Tue, Feb 07, 2023 at 05:16:58PM +0100, Peter Zijlstra wrote:
> > On Tue, Feb 07, 2023 at 11:25:27AM +0100, Arnd Bergmann wrote:
> > > Hi Josh and Peter,
> > >
> > > I've updated my randconfig test setup to use gcc-13 and clang-16, and
> > > have sent fixes for all normal WERROR=3Dy build warnings, but there a=
re a
> > > lot of objtool warnings that remain. I've reported some of them in
> > > the past, some others are new. It would be nice to at least reduce
> > > the number of warnings either through code changes or workarounds
> > > in objtool for any false positives.
> > >
> > > Out of 1500 builds, about a third had any warnings, this is the full
> > > list sorted by frequency. Let me know if there are any that you haven=
't
> > > seen before, I can provide the corresponding object and config files
> > > for reproducing.
> > >
> > >     Arnd
> > >
> > > 8<---
> > > 205 mm/kasan/shadow.o: warning: objtool: __asan_memset+0x2e: call to =
__memset() with UACCESS enabled
> > > 205 mm/kasan/shadow.o: warning: objtool: __asan_memmove+0x48: call to=
 __memmove() with UACCESS enabled
> > > 205 mm/kasan/shadow.o: warning: objtool: __asan_memcpy+0x48: call to =
__memcpy() with UACCESS enabled
> >
> > Patch pending here:
> >
> >   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/comm=
it/?h=3Dsched/core-robot&id=3D79cdfdacd5b8d1ac77e24ccbc178bba0294d0d78
> > =EF=BF=BC
> >
> > > 80 vmlinux.o: warning: objtool: ibt_selftest+0x11: sibling call from =
callable instruction with modified stack frame
> >
> > Can you provide details on how to reproduce this?
>
> Arnd, thanks for rounding these up and posting them.
>
> I agree we need to get these all cleaned up, but before we go too far
> down the rabbit hole, is there some better way to track these?
>
> Not that I would suggest using an external tracker, but maybe at least
> put each set of related warnings (e.g., those having the same frequency)
> in its own subthread with the config/compiler info included.

If any are specific to clang, please use
https://github.com/ClangBuiltLinux/linux/issues
We have a tag for issues flagged by objtool
https://github.com/ClangBuiltLinux/linux/issues?q=3Dis%3Aopen+is%3Aissue+la=
bel%3A%22%5BTOOL%5D+objtool%22

>
> --
> Josh
>


--=20
Thanks,
~Nick Desaulniers