Date:   Tue, 7 Feb 2023 23:20:47 +0530
From:   Deepak R Varma <drv@mailo.com>
To:     Oliver Neukum <oliver@neukum.org>
Cc:     Ali Akcaagac <aliakc@web.de>, Jamie Lenehan <lenehan@twibble.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        dc395x@twibble.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        Deepak R Varma <drv@mailo.com>
Subject: Re: [PATCH] scsi: dc395x: Replace arithmetic addition by bitwise OR
Message-ID: <Y+KPd4JSGR9Eyc7d@ubun2204.myguest.virtualbox.org>
References: <Y+IQoG3aYdTfMStu@ubun2204.myguest.virtualbox.org>
 <02269e84-5ca8-f150-b225-c4d8898624ec@neukum.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <02269e84-5ca8-f150-b225-c4d8898624ec@neukum.org>
Precedence: bulk

On Tue, Feb 07, 2023 at 03:25:09PM +0100, Oliver Neukum wrote:
> 
> 
> On 07.02.23 09:49, Deepak R Varma wrote:
> > When adding two bit-field mask values, an OR operation offers higher
> > performance over an arithmetic operation.
> 
> Hi,
> 
> I am sorry, but this change log makes no sense. These are constants.
> The compiler turns that into one value in any case.

Hello Oliver,
Yes, I received a feedback for another similar patch. Please disregard my patch
proposal.

> If you do a clean up, say so.
I did not understand this comment. Are you suggesting another opportunity that I
can take up? Could you share some details please?

Thank you.
deepak

> 
> 	Regards
> 		Oliver
>