Date:   Tue, 7 Feb 2023 11:02:52 -0700
From:   Jack Rosenthal <jrosenth@chromium.org>
To:     Douglas Anderson <dianders@chromium.org>
Cc:     Benson Leung <bleung@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Julius Werner <jwerner@chromium.org>,
        David Gow <davidgow@google.com>,
        chrome-platform@lists.linux.dev,
        Stephen Boyd <swboyd@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF
 Kconfig entries
Message-ID: <Y+KSTG92TtFK4PQm@chromium.org>
References: <20230207081130.1.I657776750156793721efa247ce6293445137bc8a@changeid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230207081130.1.I657776750156793721efa247ce6293445137bc8a@changeid>
Precedence: bulk

On 2023-02-07 at 08:12 -0800, Douglas Anderson wrote:
> Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
> drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
> and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
> text and thus aren't user choosable. They also aren't "select"ed by
> anything. They also control the compilation of no code.
> 
> Let's remove them.
> 
> Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>

> ---
> 
>  drivers/firmware/google/Kconfig | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index 9f190eab43ed..1bc7cbf2f65d 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE
>  	  device tree node /firmware/coreboot.
>  	  If unsure say N.
>  
> -config GOOGLE_COREBOOT_TABLE_ACPI
> -	tristate
> -	select GOOGLE_COREBOOT_TABLE
> -
> -config GOOGLE_COREBOOT_TABLE_OF
> -	tristate
> -	select GOOGLE_COREBOOT_TABLE
> -
>  config GOOGLE_MEMCONSOLE
>  	tristate
>  	depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT
> -- 
> 2.39.1.519.gcb327c4b5f-goog
>