Message-ID: <8d2ec49e-9023-5180-54c4-c09db24d2225@intel.com>
Date:   Tue, 7 Feb 2023 11:03:09 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH net v3 1/3] ixgbe: allow to increase MTU to 3K with XDP
 enabled
To:     Jason Xing <kerneljasonxing@gmail.com>,
        <jesse.brandeburg@intel.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <richardcochran@gmail.com>, <ast@kernel.org>,
        <daniel@iogearbox.net>, <hawk@kernel.org>,
        <john.fastabend@gmail.com>, <alexandr.lobakin@intel.com>,
        <maciej.fijalkowski@intel.com>
CC:     <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
        Jason Xing <kernelxing@tencent.com>
References: <20230204133535.99921-1-kerneljasonxing@gmail.com>
 <20230204133535.99921-2-kerneljasonxing@gmail.com>
Content-Language: en-US
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20230204133535.99921-2-kerneljasonxing@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHFDaTFsMHV6ZkUxN2xTbXNEN0o0N29xUUlTSGpPR1NRREFrcXVWd1VRU1JT?=
 =?utf-8?B?UHlJSmZrVHZEelM1alFMdXc3NDFYYmFwcVJtLytsdHk2WC9MYXF3KzN2ZWwr?=
 =?utf-8?B?dVRZdE5BVnkyVHZIWEtjTEJIMC9oaDNqTUVFWXU3YW5jZkpqUjRiNWdOOXR5?=
 =?utf-8?B?amViMjVzWm1LNGtyMGFNcWREMWtVdEVxeVUwQlRJM0ZKSDExMTJlK2NVVU9U?=
 =?utf-8?B?Q3c5ZVgvdGx2QVNHSVBoL0I3b3ZXY3UxdVVxbnpVTnBZeVZWbjBiZGJtL1U4?=
 =?utf-8?B?Z2RrNmVHOVRBVDZzLzEzSUZtRWNTMmptMjUxYVpBNXIrNGpqQ05ySVFNczBQ?=
 =?utf-8?B?VzRVeDJwdzZaN0pHRTdsazJQRFpQQkRqQmNQeXN3OGZTT0JyeHk5Qy9XRHM5?=
 =?utf-8?B?RStocmx3UE4zNDh5L2JxZUFOV2llQUZTUDBLTThBN05TYXZWOGRKN0NrNE43?=
 =?utf-8?B?c01TaWJQUms0dEgwaWxiL1BwKzBYRS9odjRkdWJ4d2Vad1dtUS9sM1V4QTRi?=
 =?utf-8?B?SFJoSWF2NE9OYUsrK1NaOGhoSFRpd0JjbUZDa0krSHlPWU4yN2pmSWg5Tmty?=
 =?utf-8?B?emE0UlNFcXRRc092dlVCT1lyM3FPV1REdXpkdTBJUHllWDJiaUVqSzROMkJQ?=
 =?utf-8?B?YXZQckJOM21XNmpXd2ltSXdRMHNxSk8xT245eDMyVWt0UW9xNDZaV0dTblFZ?=
 =?utf-8?B?RnZXL0gyWTNHejZrWE1FdjYzbzhzeXRNSDNLMUl6Qy92U3ZLMlZvT0IxWVVi?=
 =?utf-8?B?UTBFZUV6U3d0OCs1dTdJSXNDd1BQQVRIR3lpNVkzemlFRmZwTHFSNlJEOUlt?=
 =?utf-8?B?U0dQWWgwUTBEODJLbUE4M29HYmsxVFYxaEtEU2Z2ZGZaejRaTFZabDcrRXpo?=
 =?utf-8?B?M3Bkb0h2Q3ZNazFEcmtIZWJ1VUxmTFJOVkdld0dNSWd1Rm9ZRWFxMGR1bjA2?=
 =?utf-8?B?RlpUMUkyYUx0NTVKb2JJckJuSTN6TnVqRDJ4NUZxeXJORVprR2NkUzhxQkZs?=
 =?utf-8?B?OFVROGY5b0xDcThXOUh1NG56SlBPRWZwaGVLSmFRUkZUWFhYWTU2bEh0MWUy?=
 =?utf-8?B?cmZIbjFzMkRCOFJLYXVacDJYTndYbnhWUGs4MFRmMkxia3h4TGUveEFYQnZU?=
 =?utf-8?B?dURncXV3cDE2VlRvOFhGWHlDSDRFQlQzL1gzeTNtcHRNRzRIQ21YWEtEcnA5?=
 =?utf-8?B?bWI4aUNRQ1YwY1RxaG5RVUxOVmk1dkNmbGd5RHVvRjRibFM4aUJzT3cxV3RW?=
 =?utf-8?B?d0wxS1Y5ZU8rV3JDT216VGhDclNKei9oZmszVjdsV3ByckxOSkNIQk1CMGFv?=
 =?utf-8?B?NnNESVFFZHlsY0luai80SjZKSnBFcnRDc1pnL09LdXhzVW9PQ3VPcFNoK3ZC?=
 =?utf-8?B?SDNNaEZ6ZUJzNUV3UDAyYWJieDZGT2ZjcDRtU3lXY1o4U0tHRmo4VlV0aTVE?=
 =?utf-8?B?bC95NzB2dXhISFhMMjBBQ0JyRUtZUXFUVjEwc3lBZXJlV0hJWWZ5cjJ4dVJV?=
 =?utf-8?B?UkQvUkNYOVRhbXFnL1F1VHZ1a2dlN1QxNWZCSkxjOUY3ZzQra21Qcm1QMklW?=
 =?utf-8?B?OXJyVzRuTFR2TjRLamhhYkVmK090ZW5aaXMwNmsrNlp5K3BnSXgzMWxLaG0v?=
 =?utf-8?B?c2NDQ21QSXR2dVJ1MjVzNDhzY2V0SHY4RmVWWnVuR0ZmTUVRaWo4NTJQNUQ1?=
 =?utf-8?B?OWI0dVBEUHpacEtXc1ZmaFJScGdTcXVqZlpRbTdETktxYWJTV2hTYkUvQjE4?=
 =?utf-8?B?ZEtrcmhzNmZTTTJvNXFSS2pLNUVFenF1WjNGTjF2Qlp3UHh0Vzk2SnZWc1RM?=
 =?utf-8?B?SHFwWFdoajFkNDN5eERPcnpFVnluVlZvenBYMFJ2eFhPMFZYOEc2QzBjVlM1?=
 =?utf-8?B?SUU5a1U4dnlDMTZ5SkNqYmtoWUczYlNwS1NqMmdzekhBeHlVczFJdXpUWTBS?=
 =?utf-8?B?YzN2MjBnNy81NDZYTjhnZ3BYR1ozVkltRitscEc0RXFMYU1QeEtDUFNEdG55?=
 =?utf-8?B?eDRwZFpjdldpMHlpallRTzl3MHZ0YmIvVENlSHB1T0RLM2lKaWJjT2JxRjNQ?=
 =?utf-8?B?bFFCTFhiM0QwQlJQK3IyOWwrc2x2SDEwdUxmMmhVTTRuL3p2M3RBZlhOWWNi?=
 =?utf-8?B?aGZTVitLNlQxbFJGeDM2aEwyV1BTNEhIMktYbnFxaTRDN3BPejdOdDg0RmJs?=
 =?utf-8?B?eHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7597dc6a-1964-4a08-6e28-08db093df5cf
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 19:03:12.6911
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zs2I/TvweDHph9kiVFH95Rc38owBoOaG4CpLzMIJzvkXLzS4LhJQfxhqZ7eLVRWPrRQY8MXViUXU/GDVsFWZnzQpRZBMV9r2TgMmyODk0H0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6734
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/4/2023 5:35 AM, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>

...

> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index ab8370c413f3..2c1b6eb60436 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -6777,6 +6777,18 @@ static void ixgbe_free_all_rx_resources(struct ixgbe_adapter *adapter)
>   			ixgbe_free_rx_resources(adapter->rx_ring[i]);
>   }
>   
> +/**
> + * ixgbe_max_xdp_frame_size - returns the maximum allowed frame size for XDP
> + * @adapter - device handle, pointer to adapter
> + */

Please use ':' instead of '-' for kdoc

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:6785: warning: Function 
parameter or member 'adapter' not described in 'ixgbe_max_xdp_frame_size'

i.e.

@adapter: device handle, pointer to adapter

> +static int ixgbe_max_xdp_frame_size(struct ixgbe_adapter *adapter)
> +{
> +	if (PAGE_SIZE >= 8192 || adapter->flags2 & IXGBE_FLAG2_RX_LEGACY)
> +		return IXGBE_RXBUFFER_2K;
> +	else
> +		return IXGBE_RXBUFFER_3K;
> +}
> +