Message-ID: <04027deb-71f0-ae2e-029d-d35f307d6d80@amd.com>
Date:   Tue, 7 Feb 2023 13:07:55 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: [PATCH v1 3/3] x86/MCE/AMD: Handle reassigned bit definitions for CS
 SMCA
Content-Language: en-US
To:     Ingo Molnar <mingo@kernel.org>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com,
        yazen.ghannam@amd.com
References: <20230116191102.4226-1-avadnaik@amd.com>
 <20230116191102.4226-4-avadnaik@amd.com> <Y8Zo+hj8qxYpZdAl@gmail.com>
From:   Avadhut Naik <avadnaik@amd.com>
In-Reply-To: <Y8Zo+hj8qxYpZdAl@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUdaMEtxaDVPWWtXeFA0Z3lxMGpqalM3ak94Zkw3LzdqMmV0ZkthVGxXRGkz?=
 =?utf-8?B?b2J5QisrS2oza014MURLeW4zUU1YekNXQTRmME5UZ1R0eEk2SW43NnFydUEr?=
 =?utf-8?B?TWRGcFFmaHc3OTIxS2VweHhZVUpaZnFuZFh6QkZlVW9UZHcyeHp0US9yUWsy?=
 =?utf-8?B?cGZsSHQzbkk3bDljR1dPK2sxT012WjE5TnRWYWV1SHJRLzF0WWNFRWd3RURt?=
 =?utf-8?B?eDRkQ1BLZG5VTEVXU0RaZHRwcXhTbjMvcmxjTXFsUW5XZTBFaS9GVGtTc3Rq?=
 =?utf-8?B?bURTbGRObWlQNVkvM2RXUjcxdWlzQWF4azFIT1lwZkxMc01Xekp1SkxJWDRV?=
 =?utf-8?B?cnc3QkZNK1VhRExyT0RXbk4zeFo2c3NsdU5OOFFraDFaMjAxajUvc0Y4MVB3?=
 =?utf-8?B?U1RYdGFqalRuMjN1dDZpbWpNL2pOcCt1Q0FjL3ZJbnNHZkJlbTFHS0t6cWc1?=
 =?utf-8?B?L3U0RUdqbHhrZHNqQWY1bDZFdlJDeEZNMWdsS1g4cHN3Qmg5Mkl1WW5seThk?=
 =?utf-8?B?WU1oWk82aXBNVWkyL2V6WG9VU1BJWC9JcHJLVW1UcUNTK2dFY1d5b0lDUVJP?=
 =?utf-8?B?aHl0RVVyeStYaUlSakozVWQ2TzZvanl5SlZiOHAyamduemlQdUdjc0pjRWYw?=
 =?utf-8?B?N2NiaHhkVm1CaldHbnc0SWY0am5YSGxRTERIMjV0T0hXZHR3TTlRMm15bnl6?=
 =?utf-8?B?cEZubHczVnRocmxpaGZRN0tnUm41N2tmK25ISmJFVDdlUUQ0RktzaW12SzZZ?=
 =?utf-8?B?cnZYa0RtY1ZNa25UVW1nUlJ2SVJ4VTdsYUlHM2tqNThHWTJtT2YybWFrcTJD?=
 =?utf-8?B?c1FEMDFieEJBZEZCWmYza2lIditKbktGWXd2cUhaQWFsa3NoOTdzTzdWMFB1?=
 =?utf-8?B?WWl2RTAwRG1SMk5uK01QbWZLVnEzbFpvNTVHK28wQy8wZW1TUkpDdGlxQ3c2?=
 =?utf-8?B?OW5WcGpXNXJMcm1aWUhiSXJCS1dScHA2R0lETWNHc2QrQkl4a0xJSXl6WWZO?=
 =?utf-8?B?aUE0MjJTQ3dvL2w3d250dnZhMC9WMVU5cGlFd3VZcitxRTlES0xzaU5aaWhy?=
 =?utf-8?B?Wjdla3hXUWhaNHhCNm9za1ZRcXVGbUxhZkRXOFlRNldydkRoRGNjMVM3L3Ar?=
 =?utf-8?B?U3U3M2JwSHROYVVBbkMzK05ybEVOd0I5c3JPdytNdkxENFExVWt4YWtHOEl0?=
 =?utf-8?B?Q2UxWkZ1akJGTW9Cb0Q1a1lzYjlxd09TeUtyUFlWMllYZlBTRDlnSmdxWmIr?=
 =?utf-8?B?NEIrOUhCYzVQWVJTTGdwMEJZKzNNNUJFcGp3Z1hQdTFXaktJVVh6NWpyV2JQ?=
 =?utf-8?B?S2s2dDgxaXpaUElqd0JGU29IL0NPenBlVFErL2U0TXUvK3NGUnJETlBWMS9D?=
 =?utf-8?B?TUg1NkJreVZ6bE5rMUFhZHNrVkgyNkFJR01HcG15cHd3M084OTlweWdtSk5l?=
 =?utf-8?B?U0I0VUpOajVENFZWWlUrdDYycE1ubm11dWFQbFYrYkd4aThHWTFrY0Q5c21x?=
 =?utf-8?B?QURkZm9BMGZTNFZybmRnR2xDMlN4VjQzQ0gxSUxWbU5NdkxpTFF1ZERrQ0JM?=
 =?utf-8?B?RkFyUzZRV1M2dStESWM5NkdmVUROZ3dQakRJQkNrYkxJZi91ZDAwQUcwZ0xD?=
 =?utf-8?B?TmIvOU84QjhEakQxcFJqVXNQeExNdTFiRlZ3UUorMW03bFRwQmtKQSt6ZjlQ?=
 =?utf-8?B?TXBQZDVodTM1R0pjZWR5RWpNQzhEaEhRZDM0b2llQ3FHVEw3OXkwWVlCa0pz?=
 =?utf-8?B?WitLRTFjb1IzUStnWE1zd3hCRjAvOWFGdU9naTdBanVHeXpCdjNJZCtzNDBB?=
 =?utf-8?B?QjVaQVFOQ2ZETU9rM1VIdFpkRFBVYTZLQ2phZkJWYUhTUnNVRGYwWTNoWGda?=
 =?utf-8?B?a2pId0c3MVU1YUZUOUxoOEdXWjhTMHRWcEk2dm1hTko5N0syNmkzTFVBYUlF?=
 =?utf-8?B?dTNDOVEzcEUwUkZLenozTW5FUG5leFJtWDZCM3NwU0M2Tjl3cVFFZ2FwOHdv?=
 =?utf-8?B?TGhOZUgxZDVETURIdFhEcE5nZGhXTEpVTW1WREZNYUw5ZjZqMkQvMjhQWTZv?=
 =?utf-8?B?SHM5RTBzSzc3enBnOE0yZG1vRFFkclhsMTAxd3MvVzZkTWNTd2tLZWZaUWRM?=
 =?utf-8?Q?/L5F1QPfDxT8GRVDuBlFw1B3V?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1949222-7f5c-4353-ee2c-08db093ea01c
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6203.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 19:07:58.3492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PziebPXqUyQYuHv1BsIf3HBKjpzmsJlYDwomCEU0K1MtbJ/NUhA3CSVFlLL1/6+l5F32lRblzdjeJzr5YChXvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6828
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 1/17/2023 03:23, Ingo Molnar wrote:
> 
> * Avadhut Naik <avadnaik@amd.com> wrote:
> 
>> @@ -178,6 +178,8 @@ static const struct smca_hwid smca_hwid_mcatypes[] = {
>>  	{ SMCA_CS,	 HWID_MCATYPE(0x2E, 0x0)	},
>>  	{ SMCA_PIE,	 HWID_MCATYPE(0x2E, 0x1)	},
>>  	{ SMCA_CS_V2,	 HWID_MCATYPE(0x2E, 0x2)	},
>> +	/* Software defined SMCA bank type to handle erratum 1384*/
>> +	{ SMCA_CS_V2_QUIRK, HWID_MCATYPE(0x0, 0x1)  },
>>  
>>  	/* Unified Memory Controller MCA type */
>>  	{ SMCA_UMC,	 HWID_MCATYPE(0x96, 0x0)	},
>> @@ -259,6 +261,17 @@ static inline void fixup_hwid(unsigned int *hwid_mcatype)
>>  
>>  	if (c->x86 == 0x19) {
>>  		switch (c->x86_model) {
>> +		/*
>> +		 * Per Genoa's revision guide, erratum 1384, some SMCA Extended
>> +		 * Error Codes and SMCA Control bits are incorrect for SMCA CS
>> +		 * bank type.
>> +		 */
>> +		case 0x10 ... 0x1F:
>> +		case 0x60 ... 0x7B:
>> +		case 0xA0 ... 0xAF:
>> +			if (*hwid_mcatype == HWID_MCATYPE(0x2E, 0x2))
>> +				*hwid_mcatype = HWID_MCATYPE(0x0, 0x1);
> 
> Why are we open-coding these types?
> 
> Why not use smca_hwid_mcatypes[SMCA_CS_V2], etc.?

If I understood correctly (And please rectify me if I didn't), did you mean using something like the below snippet instead of what I have used?

if (*hwid_mcatype == smca_hwid_mcatypes[SMCA_CS_V2].hwid_mcatype)
	*hwid_mcatype = smca_hwid_mcatypes[SMCA_CS_V2_QUIRK].hwid_mcatype;

If yes, then SMCA_CS_V2, SMCA_CS_V2_QUIRK etc. originate from the enum smca_bank_types in arch/x86/include/asm/mce.h.
As the enum stands now, it cannot be used for indexing into the smca_hwid_mcatypes array since it might result in incorrect indexing.

Please advise.

Thanks,
Avadhut Naik
> 
>> +			if (*hwid_mcatype == HWID_MCATYPE(0x2E, 0x2))
>> +				*hwid_mcatype = HWID_MCATYPE(0x0, 0x1);
> 
> Ditto.
> 
> Thanks,
> 
> 	Ingo