MIME-Version: 1.0
References: <20230207002403.63590-1-namhyung@kernel.org> <20230207002403.63590-2-namhyung@kernel.org>
In-Reply-To: <20230207002403.63590-2-namhyung@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Tue, 7 Feb 2023 14:22:23 -0800
Message-ID: <CAM9d7ch4k8PFt1fB4MPaGVmz6P4HJZ48Yi6HA_Ec5Pe9GL_F9A@mail.gmail.com>
Subject: Re: [PATCH 1/3] perf lock contention: Fix to save callstack for the
 default modified
To:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Song Liu <song@kernel.org>, Hao Luo <haoluo@google.com>,
        bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 6, 2023 at 4:24 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> The previous change missed to set the con->save_callstack for the
> LOCK_AGGR_CALLER mode resulting in no caller information.
>
> Fixes: ebab291641be ("perf lock contention: Support filters for different aggregation")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Arnaldo, can you please take this one asap?

Thanks,
Namhyung


> ---
>  tools/perf/builtin-lock.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index 0d11f301fd72..a4b5c481129c 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -1806,6 +1806,9 @@ static int __cmd_contention(int argc, const char **argv)
>         con.aggr_mode = aggr_mode = show_thread_stats ? LOCK_AGGR_TASK :
>                 show_lock_addrs ? LOCK_AGGR_ADDR : LOCK_AGGR_CALLER;
>
> +       if (con.aggr_mode == LOCK_AGGR_CALLER)
> +               con.save_callstack = true;
> +
>         /* for lock function check */
>         symbol_conf.sort_by_name = true;
>         symbol_conf.allow_aliases = true;
> --
> 2.39.1.519.gcb327c4b5f-goog
>