MIME-Version: 1.0
References: <cover.1672730839.git.chiaen_wu@richtek.com> <664b47539b9773425556f569e40d687e33799c53.1672730839.git.chiaen_wu@richtek.com>
In-Reply-To: <664b47539b9773425556f569e40d687e33799c53.1672730839.git.chiaen_wu@richtek.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 7 Feb 2023 16:36:59 -0600
Message-ID: <CAL_JsqJ4gueN3UFfea5JC6xfPjaH6a+7+dioTw=s0W-gBf6Anw@mail.gmail.com>
Subject: Re: [PATCH v3 RESEND 2/3] power: supply: rt9467: Add Richtek RT9467
 charger driver
To:     ChiaEn Wu <peterwu.pub@gmail.com>, sre@kernel.org
Cc:     krzysztof.kozlowski+dt@linaro.org, chiaen_wu@richtek.com,
        cy_huang@richtek.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 3, 2023 at 1:30 AM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
> RT9467 is a switch-mode single cell Li-Ion/Li-Polymer battery charger
> for portable applications.
>
> It integrates a synchronous PWM controller, power MOSFETs,
> input current sensing and regulation, high-accuracy voltage regulation,
> and charge termination. The charge current is regulated through
> integrated sensing resistors.
>
> The RT9467 also features USB On-The-Go (OTG) support. It also integrates
> D+/D- pin for USB host/charging port detection.
>
> Co-developed-by: ChiYuan Huang <cy_huang@richtek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
>  drivers/power/supply/Kconfig          |   19 +
>  drivers/power/supply/Makefile         |    1 +
>  drivers/power/supply/rt9467-charger.c | 1282 +++++++++++++++++++++++++
>  3 files changed, 1302 insertions(+)
>  create mode 100644 drivers/power/supply/rt9467-charger.c

[...]

> +static const struct of_device_id rt9467_charger_of_match_table[] = {
> +       { .compatible = "richtek,rt9467", },

This does not match the binding. Probably the binding should be fixed
if this is only a charger. In that case, '-charger' is redundant.

FYI, 'make dt_compatible_check' will detect this.

Rob