Date:   Wed, 8 Feb 2023 00:49:53 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Mathias Nyman <mathias.nyman@linux.intel.com>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 2/7] xhci: mem: Use __GFP_ZERO instead of explicit
 memset() call
Message-ID: <Y+LVkVvqknr/z3D5@smile.fi.intel.com>
References: <20230206161049.13972-1-andriy.shevchenko@linux.intel.com>
 <20230206161049.13972-3-andriy.shevchenko@linux.intel.com>
 <31a4cfbe-2c23-cda2-2d92-9d15a5d4bcb3@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <31a4cfbe-2c23-cda2-2d92-9d15a5d4bcb3@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Feb 07, 2023 at 05:11:23PM +0200, Mathias Nyman wrote:
> On 6.2.2023 18.10, Andy Shevchenko wrote:
> > Use __GFP_ZERO instead of explicit memset() call in
> > xhci_alloc_stream_ctx().

...

> > +	mem_flags |= __GFP_ZERO;
> 
> How about calling dma_pool_zalloc() instead of setting __GFP_ZERO flag?
> Memory returned by dma_alloc_coherent() should already be zeroed if I remember correctly

That will work too.

-- 
With Best Regards,
Andy Shevchenko