From:   "Kani, Toshi" <toshi.kani@hpe.com>
To:     Borislav Petkov <bp@alien8.de>, Juergen Gross <jgross@suse.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "lists@nerdbynature.de" <lists@nerdbynature.de>,
        "mikelley@microsoft.com" <mikelley@microsoft.com>,
        "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: RE: [PATCH 5/6] x86/mm: only check uniform after calling
 mtrr_type_lookup()
Thread-Topic: [PATCH 5/6] x86/mm: only check uniform after calling
 mtrr_type_lookup()
Thread-Index: AQHZOulntijzch8290iNnvSGN6nRvK7ENriA
Date:   Wed, 8 Feb 2023 01:13:05 +0000
Message-ID: <PH7PR84MB18382D0F717742662E520AC782D89@PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230207072902.5528-1-jgross@suse.com>
 <20230207072902.5528-6-jgross@suse.com> <Y+I5NyAeu4LWFBcA@zn.tnic>
In-Reply-To: <Y+I5NyAeu4LWFBcA@zn.tnic>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V09Ibf5uJgOHfeQdovB4fa+GZjjqJcBuII1LqOfTfjJYv14Y6l6BawvoDvup?=
 =?us-ascii?Q?SdvDyCMDdl+pg9u9iPWOLRhm7db60WMv2H+9yjgoA4B6nbs6kfkYYUmrsd3A?=
 =?us-ascii?Q?EGTB0vo3Pl/RSaTLYsyqLGSnNJC+95+zzHupCm+mx2CSjJTiV/pG31OOcq+D?=
 =?us-ascii?Q?kf3g0YDb3DmjawKDyOuhLhootHBcN69cC/vCk5EUGCIBUufUp9Jty62JDq2Z?=
 =?us-ascii?Q?rBNOPJXyX1KHIGqz114o+PGKNMXq0TAF/l7vgQJbEvndlsJMqqXk7BBb89Dw?=
 =?us-ascii?Q?/UfDJy3p6pPH4A1ReyDDrISY8gMuraszPTqy0879cGEiFHePxrJKC9X0ALxP?=
 =?us-ascii?Q?Jt/T/RLjBCsmdIEg0pysqPxvQKY9APNn5EX4RF18NhdZDG61QGl+aV3h6hrv?=
 =?us-ascii?Q?6YcD8Xb10NVcExspRnyMePqGwuG85HhFxFXGYrqZMQSdZdkbNR/d/DiAPDS4?=
 =?us-ascii?Q?SQb8jh8X4qvmbhnNvDr9rGzKKwxSkIJJOZhKxMoNmGtblg1HheZSSqrcVR/g?=
 =?us-ascii?Q?PfSDTr2Up/rIpWxvhVX3J6lWySI7utzbApLr3H3592csa3yb8MJ5z2rn12Lq?=
 =?us-ascii?Q?s6MY9iPkSUYdQmeLSveJF1Qah4KSkAeAO8d8D/JVyiMUaSQz1j1GgR4r3++N?=
 =?us-ascii?Q?vAk7Rk7Q+nZ6CMUN/61jONKAzidbYMVHElnzRDXcXT9yvpE/gOkyhzzyYsF5?=
 =?us-ascii?Q?mSzAroxgX483DMmwpMHMW+PXMhp0LiZAbdhM4ZQZuhj9YIV/66+YjM+jdSYE?=
 =?us-ascii?Q?l4Xs19U+J8Lw1j0vR9hJSFE2LCNqj380FM5HFy0tvEuu2IYZ9iqBIuTQypF0?=
 =?us-ascii?Q?di+d6ZaS+5LAj7gCxA5SzDYLjTu5OBtYGhNZ6KyERpq9So0QMJ17qMAebtqp?=
 =?us-ascii?Q?wqfMPzmIWNonYPG1GdPKXbaz3SfREiFLPhx7015gesVaLFf1D0nl+qEHzXZ7?=
 =?us-ascii?Q?XCIYvlQ9vFFKGnghYOZI6Mk38aOjcoDRxwvohgx4UHRMobHDtKm+Bf4xrqpy?=
 =?us-ascii?Q?odaC4D0ogHg2cX2R0g5mYhhdFgFpo8n1Bbj8TkOyO8uclB6ArTLnEXaqTqsG?=
 =?us-ascii?Q?DKD1JmGaEf9qSOgRmp/SCblmI3Z3yYuJT5829seRzv7wKArhaRpY8Y1O+SNt?=
 =?us-ascii?Q?5UzaFsE3kmXt+SBbU7/fxGr+DSXDjAglU1QffxbKBgpGYZBs4ukpN6y2L6hs?=
 =?us-ascii?Q?CLk+IgM5O1D8Mu9cESoohatqdVPpejXc/qKzYjNfgcDfv6axIq1Qsu3ETKCj?=
 =?us-ascii?Q?rDMKRjp8GzTlcs0MoEaQWxyeU8O1Dc0Inrj2vdERK2FYAD9JgK6YOt2+WJ+c?=
 =?us-ascii?Q?Ef8ntq925Sl6Uj8S6CcM9EoCv1HLXTL/NRuRjZJE+2BXiwJGtiM4dNVuHq1D?=
 =?us-ascii?Q?vf5gaEeJuzHj2V5TZWlwukAZwlX2RB8wJ89YDpjexWhucP1APtQktzbPCziD?=
 =?us-ascii?Q?xBmhfaN/Y9oLVJr5lp/3LnkR/TB3hQVPtzzU0qFSpZXUiNAarrpKVwAXTSSX?=
 =?us-ascii?Q?IYu7l8PCnxbZaAhXkQ6Iq3X00WIOgNDfvJvx0ACGK3Dn3EzBzSgH2gh9zn2q?=
 =?us-ascii?Q?pKiXZk7QYESvS2cToxEeGo4Rmk++znDOFWk7YMFi?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: c6e546de-ab71-44ec-f266-08db0971a1a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2023 01:13:05.0706
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JNjiKMPeqZ7MU6N6wK35P6iJO/qvXRKTpgWZoclN5Ty0uyVSzfCg5zwruczNmrQGVp8Vqcy6VJ9aBcPI1yoDaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1804
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: rTYcXWGlLs65UR_FSsxAGOhXgE2HJCWY
X-Proofpoint-GUID: rTYcXWGlLs65UR_FSsxAGOhXgE2HJCWY
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-02-07_15,2023-02-06_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0
 lowpriorityscore=0 mlxlogscore=791 mlxscore=0 phishscore=0 impostorscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302080010
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07.02.23 12:42, Borislav Petkov wrote:
> On Tue, Feb 07, 2023 at 08:29:01AM +0100, Juergen Gross wrote:
> > Today pud_set_huge() and pmd_set_huge() test for the MTRR type to be
> > WB or INVALID after calling mtrr_type_lookup(). Those tests can be
> > dropped, as the only reason to not use a large mapping would be
> > uniform being 0. Any MTRR type can be accepted as long as it applies
> > to the whole memory range covered by the mapping, as the alternative
> > would only be to map the same region with smaller pages instead using
> > the same PAT type as for the large mapping.
:
> Lemme add Toshi who authored that code - he might have a comment or
> two.

The current mtrr_type_look() does not set 'uniform' for MTRR_TYPE_INVALID.
Please also update it to set 'uniform', if not done in other patches.

Toshi