MIME-Version: 1.0
References: <20230123182732.188863-1-sj@kernel.org> <20230206225652.89873-1-sj@kernel.org>
In-Reply-To: <20230206225652.89873-1-sj@kernel.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Wed, 8 Feb 2023 10:27:42 +0900
Message-ID: <CAK7LNAQf=9NJWRAFkcA=GXHh2bmh8N22iTJHqL1wDbyiB2Kfow@mail.gmail.com>
Subject: Re: Linux 6.2-rc2
To:     SeongJae Park <sj@kernel.org>
Cc:     Ard Biesheuvel <ardb@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>, Arnd Bergmann <arnd@arndb.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Palmer Dabbelt <palmer@rivosinc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 7, 2023 at 7:56 AM SeongJae Park <sj@kernel.org> wrote:
>
> On Mon, 23 Jan 2023 18:27:32 +0000 SeongJae Park <sj@kernel.org> wrote:
>
> > On Mon, 23 Jan 2023 18:09:27 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > > On Wed, Jan 11, 2023 at 4:14 AM SeongJae Park <sj@kernel.org> wrote:
> > > >
> > > > Hi Masahiro,
> > > >
> > > > On Wed, 11 Jan 2023 03:39:58 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> > > >
> > > > > On Tue, Jan 10, 2023 at 9:32 AM SeongJae Park <sj@kernel.org> wrote:
> > > > > >
> > > > > > On Tue, 3 Jan 2023 11:58:48 +0100 Ard Biesheuvel <ardb@kernel.org> wrote:
> > > > > >
> > > > > > > On Tue, 3 Jan 2023 at 03:13, Linus Torvalds
> > > > > > > <torvalds@linux-foundation.org> wrote:
> > > > > > > >
> > > > > > > > On Mon, Jan 2, 2023 at 5:45 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > > > > > > > >
> > > > > > [...]
> > > > > > > --- a/include/asm-generic/vmlinux.lds.h
> > > > > > > +++ b/include/asm-generic/vmlinux.lds.h
> > > > > > > @@ -896,7 +896,7 @@
> > > > > > >   * Otherwise, the type of .notes section would become PROGBITS
> > > > > > > instead of NOTES.
> > > > > > >   */
> > > > > > >  #define NOTES                                                          \
> > > > > > > -       /DISCARD/ : { *(.note.GNU-stack) }                              \
> > > > > > > +       .note.GNU-stack : { *(.note.GNU-stack) }                        \
> > > > > > >         .notes : AT(ADDR(.notes) - LOAD_OFFSET) {                       \
> > > > > > >                 BOUNDED_SECTION_BY(.note.*, _notes)                     \
> > > > > > >         } NOTES_HEADERS                                                 \
> > > > > > >
> > > > > > > The .note.GNU-stack has zero size, so the result should be the same.
> > > > > > >
> > > > > >
> > > > > > This also fixes ARCH=um build error on my system.
> > > > > >
> > > > > > Tested-by: SeongJae Park <sj@kernel.org>
> > > > >
> > > > >
> > > > >
> > > > > I am able to build ARCH=um defconfig at least.
> > > > >
> > > > > Can you provide the steps to reproduce the build error?
> > > >
> > > > I do the build for kunit test, like below.
> > > >
> > > >     mkdir ../kunit.out
> > > >     echo "
> > > >         CONFIG_KUNIT=y
> > > >
> > > >         CONFIG_DAMON=y
> > > >         CONFIG_DAMON_KUNIT_TEST=y
> > > >
> > > >         CONFIG_DAMON_VADDR=y
> > > >         CONFIG_DAMON_VADDR_KUNIT_TEST=y
> > > >
> > > >         CONFIG_DEBUG_FS=y
> > > >         CONFIG_DAMON_DBGFS=y
> > > >         CONFIG_DAMON_DBGFS_KUNIT_TEST=y
> > > >     CONFIG_DAMON_PADDR=y" > ../kunit.out/.kunitconfig
> > > >     ./tools/testsing/kunit/kunit.py run --build_dir ../kunit.out
> > > >     [19:12:37] Configuring KUnit Kernel ...
> > > >     [19:12:37] Building KUnit Kernel ...
> > > >     Populating config with:
> > > >     $ make ARCH=um O=../kunit.out/ olddefconfig
> > > >     Building with:
> > > >     $ make ARCH=um O=../kunit.out/ --jobs=36
> > > >     ERROR:root:`.exit.text' referenced in section `.uml.exitcall.exit' of arch/um/drivers/virtio_uml.o: defined in discarded section `.exit.text' of arch/um/drivers/virtio_uml.o
> > > >     collect2: error: ld returned 1 exit status
> > > >     make[2]: *** [/home/sjpark/linux/scripts/Makefile.vmlinux:34: vmlinux] Error 1
> > > >     make[1]: *** [/home/sjpark/linux/Makefile:1252: vmlinux] Error 2
> > > >     make: *** [Makefile:242: __sub-make] Error 2
> > > >
> [...]
> >
> > Thank you for sharing your results.  I think it may depend on the compiler
> > version, because I use a quite old compiler.
> >
> >     $ gcc --version
> >     gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
>
> I'm still getting the failure on my setup with latest mainline.  Could we merge
> the fix for now?  Or, was there some updates that I was missing?
>
>
> Thanks,
> SJ
>
> [...]


Sorry for delay. I submitted a patch.

https://lore.kernel.org/all/20230207164156.537378-1-masahiroy@kernel.org/


-- 
Best Regards
Masahiro Yamada