Date:   Wed, 8 Feb 2023 04:16:25 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc:     robh+dt@kernel.org, broonie@kernel.org, peterhuewe@gmx.de,
        jgg@ziepe.ca, krzysztof.kozlowski+dt@linaro.org,
        linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        skomatineni@nvidia.com, ldewangan@nvidia.com
Subject: Re: [PATCH 0/4] Tegra TPM driver with hw flow control
Message-ID: <Y+MF+SdrE99YCuQB@kernel.org>
References: <20230202161750.21210-1-kyarlagadda@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230202161750.21210-1-kyarlagadda@nvidia.com>
Precedence: bulk

On Thu, Feb 02, 2023 at 09:47:46PM +0530, Krishna Yarlagadda wrote:
> Tegra234 and Tegra241 chips have QSPI controller that supports TCG
> PC Client Specific TPM Interface Specification (TIS) flow control.
> Since the controller only supports half duplex, sw wait polling
> (flow control using full duplex transfers) method implemented in
> tpm_tis_spi_main.c does not suffice.
> Added extended driver to disable sw flow control and send

s/Added/Add/

What is "extended driver"?

> all transfers in single message. Flow control is handled by hardware.
> 
> Krishna Yarlagadda (4):
>   dt-bindings: tpm: Add compatible for Tegra TPM
>   tpm: tegra: Support SPI tpm wait state detect
>   spi: dt-bindings: Add Tegra TPM wait polling flag
>   spi: tegra210-quad: Enable TPM wait polling
> 
>  .../security/tpm/nvidia,tegra-tpm-spi.txt     |  14 ++
>  ...nvidia,tegra210-quad-peripheral-props.yaml |   6 +
>  drivers/char/tpm/Makefile                     |   1 +
>  drivers/char/tpm/tpm_tis_spi.h                |   1 +
>  drivers/char/tpm/tpm_tis_spi_main.c           |   4 +-
>  drivers/char/tpm/tpm_tis_spi_tegra.c          | 123 ++++++++++++++++++
>  drivers/spi/spi-tegra210-quad.c               |  16 +++
>  7 files changed, 164 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/security/tpm/nvidia,tegra-tpm-spi.txt
>  create mode 100644 drivers/char/tpm/tpm_tis_spi_tegra.c
> 
> -- 
> 2.17.1
> 

BR, Jarkko