Subject: Re: block: sleeping in atomic warnings
To:     Jens Axboe <axboe@kernel.dk>, Dan Carpenter <error27@gmail.com>,
        linux-block@vger.kernel.org
Cc:     Julia Lawall <julia.lawall@inria.fr>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Hongchen Zhang <zhanghongchen@loongson.cn>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Christian Brauner (Microsoft)" <brauner@kernel.org>,
        David Howells <dhowells@redhat.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        maobibo <maobibo@loongson.cn>,
        Matthew Wilcox <willy@infradead.org>,
        Sedat Dilek <sedat.dilek@gmail.com>,
        "yukuai (C)" <yukuai3@huawei.com>
References: <20230129060452.7380-1-zhanghongchen@loongson.cn>
 <CAHk-=wjw-rrT59k6VdeLu4qUarQOzicsZPFGAO5J8TKM=oukUw@mail.gmail.com>
 <Y+EjmnRqpLuBFPX1@bombadil.infradead.org>
 <4ffbb0c8-c5d0-73b3-7a4e-2da9a7b03669@inria.fr> <Y+Ja5SRs886CEz7a@kadam>
 <4321724d-9a24-926c-5d2d-5d5d902bda72@kernel.dk>
From:   Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <339bf113-3ac1-7e62-3cca-45bb8b53d291@huaweicloud.com>
Date:   Wed, 8 Feb 2023 11:15:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <4321724d-9a24-926c-5d2d-5d5d902bda72@kernel.dk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2023/02/08 2:31, Jens Axboe 写道:

>> block/blk-wbt.c:843 wbt_init() warn: sleeping in atomic context
>> ioc_qos_write() <- disables preempt
>> -> wbt_enable_default()
>>     -> wbt_init()
> 
> Also definitely a bug.
> 

This won't happen currently, wbt_init() will be called while
initializing device, and later wbt_enable_devault() from iocost won't
call wbt_init().

However, we might support rq_qos destruction dynamically in the
future, I'll fix this warning.

Thanks,
Kuai